)]}'
{
  "commit": "02c56438fa447df9e3fcc680d6ad53c6cbd52981",
  "tree": "d682e18b9371c63c1e869574ea4cf7a0fde1c350",
  "parents": [
    "604d3a1d1ab869182b84ccfe976f8b7b5e6d1a51"
  ],
  "author": {
    "name": "jmmv",
    "email": "jmmv@google.com",
    "time": "Wed Sep 18 14:02:22 2019 -0700"
  },
  "committer": {
    "name": "Copybara-Service",
    "email": "copybara-worker@google.com",
    "time": "Wed Sep 18 14:03:11 2019 -0700"
  },
  "message": "Try to bring some more clarity into DynamicSpawnStrategyTest.\n\nThe tests derived from strategyWaitsForBothSpawnsToFinish were really\ndifficult to understand due to the booleans passed to this function\nand the various state checks based on them. I haven\u0027t been able to\neliminate the booleans without a lot of code duplication, but moving\nthe logic to verify their impact on execution to a per-test lambda\nmakes things slightly easier to reason about.\n\nAs part of the reverse-engineering of what this is supposed to do, this\nsprinkles comments throughout the tests based on my understanding so far.\n\nAnd while here (which is the smaller thing that started this CL),\neliminate the booleans from the strategyPropagatesException helper\nfunction.\n\nThese changes fix some pre-existing flakiness in this test related to\nbad interrupt handling.\n\nRELNOTES: None.\nPiperOrigin-RevId: 269885062\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "957ff6af80a33fe98b0d80ae52e89027702f425f",
      "old_mode": 33188,
      "old_path": "src/test/java/com/google/devtools/build/lib/dynamic/DynamicSpawnStrategyTest.java",
      "new_id": "96bb8448bb9e97f5d747e2509ac2bc6d644b0cab",
      "new_mode": 33188,
      "new_path": "src/test/java/com/google/devtools/build/lib/dynamic/DynamicSpawnStrategyTest.java"
    }
  ]
}