tree 7e98f3cf6a0c660128b2f752361ae14ad6f12322
parent 3a57a5276a0694fffab3d40fef8a42a1bc44680d
author nharmata <nharmata@google.com> 1573688885 -0800
committer Copybara-Service <copybara-worker@google.com> 1573688939 -0800

Prefer rethrowing Skyframe globbing errors rather than legacy globbing errors.

Skyframe globbing errors are more useful to the user (e.g. in the case of a symlink cycle, the error message contains the cycle) and are also persistent. Contrast with legacy globbing errors which are more opaque and are conservatively assumed to be transient.

Unsurprisingly, this change fixes a long-standing discrepancy between incremental and non-incremental package loading. The new, self-consistent behavior, is that PackageFunction will throw a NoSuchPackageException if any glob evaluation encounters a symlink cycle, regardless if glob evaluations were cached via Skyframe globbing. The discrepancy with the old code was that legacy globbing ignores some symlink issues (see UnixGlob.GlobVisitor#processSymlink), and so on non-incremental package loading with a symlink ignored by legacy globbing, PackageFunction wouldn't throw a NoSuchPackageException.

RELNOTES: Package loading now consistently fails if package loading had a glob evaluation that encountered a symlink cycle or symlink infinite expansion. Previously, such package loading with such glob evaluations would fail only in some cases.
PiperOrigin-RevId: 280298226