tree 5a223893087517ea1d425907312c667ce4d8850d
parent 6462d87752999d46e8528b52412dbf39d26f4288
author Ulf Adams <ulfjack@google.com> 1453205306 +0000
committer Lukacs Berki <lberki@google.com> 1453210114 +0000

Rewrite SkylarkAspectsTest to inherit AnalysisTestCase.

While BuildViewTestCase now has an update() function, it also has a lot of
legacy cruft that doesn't match how the code is used in production. This also
makes the test code a bit simpler.

Also add a couple missing fail() statements.

This is in preparation for adding a couple more tests; we don't have good
test coverage for interaction between Skylark aspects and native rules and
vice versa, especially for error scenarios.

I may reuse some of the AspectTest code, but that inherits AnalysisTestCase.
Inheriting AnalysisTestCase here also makes that easier.

--
MOS_MIGRATED_REVID=112460142