tree b74f6fa19c44c4369e7311bca0f1dc2d1a6dcb20
parent ea1dcb78541dd1a7a1cb8c1f2fa081013560e671
author jmmv <jmmv@google.com> 1549981760 -0800
committer Copybara-Service <copybara-piper@google.com> 1549981860 -0800

Fix resource unlimiting on macOS when the hard limit is above allowed max.

On macOS, it is possible for certain hard limits to be set to a value that
is higher than the configured kernel limit for such resources.  We were
already handling "unlimited" correctly by capping this to the kernel setting
but we did not account for actual values higher than the kernel setting.
Fix this now by capping the value in all cases.

You can imagine doing "ulimit -H -n 2048" and *then* lowering the kernel
max to a value below 2048, in which caseI'd expect the reported hard rlimit
to have also been lowered, but it isn't, so we must cope with that.  Or you
can also imagine setting the hard limit to a value higher than the
per-process kernel limit but lower than the total aggregate limit, which is
only possible as root.

Should fix https://github.com/bazelbuild/bazel/issues/6776.

Tested: I have manually tested this and it seems to work, but I cannot add
a test.  Adding a test would involve administrator privileges and is hard.

RELNOTES: None.
PiperOrigin-RevId: 233595690