tree e61894f4b41180439726adba3df48b21090e116f
parent 4d3b8c4e029b5bd91b53cd2196df71c805d14183
author Jakob Buchgraber <buchgr@google.com> 1573043656 -0800
committer Copybara-Service <copybara-worker@google.com> 1573043707 -0800

Refactor SimpleBlobStore#get(ActionResult)(...)

The change update methods signatures to be compatible with those in
AbstractRemoteActionCache:
  1) Future<Boolean> get(String, OutputStream) -> Future<Void> downloadBlob(Digest, OutputStream)
  2) Future<Boolean> getActionResult(String, OutputStream) -> Future<ActionResult> downloadActionResult(ActionKey)

The refactoring uncovered a bug in CombinedDiskHttpBlobStore. We did not
close the output stream *before* moving a file to the disk cache, thus
potentially moving a corrupted file to the disk cache as any errors
would only be reported afterwards.

Closes #9200.

PiperOrigin-RevId: 278830531