tree 4c4f87df5b1a67488cf58cafa77d87fc30f89288
parent fb016b67e67a2f3354b93fcd9259fb8ac788ada5
author laszlocsomor <laszlocsomor@google.com> 1550223717 -0800
committer Copybara-Service <copybara-worker@google.com> 1550223830 -0800

subprocesses: customizable SubprocessFactory

Individual SubprocessBuilder instances can now use
a SubprocessFactory object other than the static
SubprocessBuilder.factory.

Also, WindowsSubprocessFactory is no longer a
singleton because it now stores state: whether to
use windows-style argument escaping or to use the
(broken) Bash-style escaping (causing https://github.com/bazelbuild/bazel/issues/7122).

These two changes allow:
- a safer way to mock out SubprocessFactory in
  tests, because it's no longer necessary to
  change global state (i.e. the static
  SubprocessBuilder.factory member)
- testing old and new argument escaping semantics
  in WindowsSubprocessTest
- adding a flag that switches between old and new
  semantics in the SubprocessFactory, and thus
  allows rolling out the bugfix with just a flag
  flip

See https://github.com/bazelbuild/bazel/issues/7122

PiperOrigin-RevId: 234105692