)]}'
{
  "commit": "24caa1d30a7cce01a61fcd70f6a65378bf9c261e",
  "tree": "f2274077a5ece01577c554f62eb7f72c5c51cf37",
  "parents": [
    "bcc4e9f2af252ee7b3fda717edb701eb81f11160"
  ],
  "author": {
    "name": "Yun Peng",
    "email": "pcloudy@google.com",
    "time": "Wed Nov 06 19:21:59 2024 +0100"
  },
  "committer": {
    "name": "GitHub",
    "email": "noreply@github.com",
    "time": "Wed Nov 06 18:21:59 2024 +0000"
  },
  "message": "[7.4.1] Remove DownloadManager instance from RegistryFactoryImpl. (#24228)\n\nThis PR removes the DownloadManager from the registry factory\r\nimplementation. As the registry created by the factory is cached by the\r\nSkyFunction mechanism, the DownloadManager instance was living too long\r\n- it is supposed to be re-created for every command instantiation to\r\nrespect changes in command line options, but for the registry, it\r\nignored those changes.\r\n\r\nInstead, the DownloadManager is set directly into the affected\r\nSkyFunctions that require access to it. This way, the per-command\r\nDownloadManager instance is correctly used.\r\n\r\nThis fixes https://github.com/bazelbuild/bazel/issues/24166.\r\n\r\nNote for reviewers: This is my first time touching code with\r\nSkyFunctions, so I don\u0027t really know what I\u0027m doing.\r\n\r\nCloses #24212.\r\n\r\nPiperOrigin-RevId: 693644409\r\nChange-Id: I7b16684e52673043615290d114f078ab7ab99fcf\r\n\r\nCo-authored-by: Cornelius Riemenschneider \u003ccornelius@github.com\u003e",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "1dc8e1ef1df3412c9897dadea9756c99f2b3dd02",
      "old_mode": 33188,
      "old_path": "src/main/java/com/google/devtools/build/lib/bazel/BazelRepositoryModule.java",
      "new_id": "b86c9a884a3a4e24b9f6131ccecc48cf402f40e5",
      "new_mode": 33188,
      "new_path": "src/main/java/com/google/devtools/build/lib/bazel/BazelRepositoryModule.java"
    },
    {
      "type": "modify",
      "old_id": "b9cb637ad6d906a845b56d46788f89c7d8bfb9b5",
      "old_mode": 33188,
      "old_path": "src/main/java/com/google/devtools/build/lib/bazel/bzlmod/IndexRegistry.java",
      "new_id": "98bc2cd784609d496f183fe92f8f67ed5098a8aa",
      "new_mode": 33188,
      "new_path": "src/main/java/com/google/devtools/build/lib/bazel/bzlmod/IndexRegistry.java"
    },
    {
      "type": "modify",
      "old_id": "7d1c977074a4868fcfe17041fedf230f59b90b1f",
      "old_mode": 33188,
      "old_path": "src/main/java/com/google/devtools/build/lib/bazel/bzlmod/ModuleFileFunction.java",
      "new_id": "f1ec5b976dba60e6dd7c5f7fd0d198c7d34d22c7",
      "new_mode": 33188,
      "new_path": "src/main/java/com/google/devtools/build/lib/bazel/bzlmod/ModuleFileFunction.java"
    },
    {
      "type": "modify",
      "old_id": "0fc178244a09ff9d3d472fad43a0fdb178030f55",
      "old_mode": 33188,
      "old_path": "src/main/java/com/google/devtools/build/lib/bazel/bzlmod/Registry.java",
      "new_id": "32a55321efc240e76bbe10724d491c2306e97ec5",
      "new_mode": 33188,
      "new_path": "src/main/java/com/google/devtools/build/lib/bazel/bzlmod/Registry.java"
    },
    {
      "type": "modify",
      "old_id": "c15c847771327d3ea11d52b2c5ef9adb1a5f3e5b",
      "old_mode": 33188,
      "old_path": "src/main/java/com/google/devtools/build/lib/bazel/bzlmod/RegistryFactoryImpl.java",
      "new_id": "8ca7b5871467ecad3264c38cf5dc96e324e1aa62",
      "new_mode": 33188,
      "new_path": "src/main/java/com/google/devtools/build/lib/bazel/bzlmod/RegistryFactoryImpl.java"
    },
    {
      "type": "modify",
      "old_id": "88d7664ca13b367e98caa076b02254383fb53f25",
      "old_mode": 33188,
      "old_path": "src/main/java/com/google/devtools/build/lib/bazel/bzlmod/RepoSpecFunction.java",
      "new_id": "748481372f3d66974584cdc4f4e0798551122d27",
      "new_mode": 33188,
      "new_path": "src/main/java/com/google/devtools/build/lib/bazel/bzlmod/RepoSpecFunction.java"
    },
    {
      "type": "modify",
      "old_id": "57a2344f6657fdc43c42bb2cb5410c969c568674",
      "old_mode": 33188,
      "old_path": "src/main/java/com/google/devtools/build/lib/bazel/bzlmod/YankedVersionsFunction.java",
      "new_id": "8117dd12bf754fd56a006a54ff3fbc3af989e6a1",
      "new_mode": 33188,
      "new_path": "src/main/java/com/google/devtools/build/lib/bazel/bzlmod/YankedVersionsFunction.java"
    },
    {
      "type": "modify",
      "old_id": "067333494e99b2816f8dc880a40f0d7a454cb5b8",
      "old_mode": 33188,
      "old_path": "src/main/java/com/google/devtools/build/lib/skyframe/packages/BazelPackageLoader.java",
      "new_id": "b29736d1137658ce045260f207ee5cac866406cc",
      "new_mode": 33188,
      "new_path": "src/main/java/com/google/devtools/build/lib/skyframe/packages/BazelPackageLoader.java"
    },
    {
      "type": "modify",
      "old_id": "1f8ba8e32d4a83508b0dcfef1e28c4561c2cbca3",
      "old_mode": 33188,
      "old_path": "src/test/java/com/google/devtools/build/lib/bazel/bzlmod/FakeRegistry.java",
      "new_id": "3aa8e7c0eaa2b9736e97fe80985681422a68a0d9",
      "new_mode": 33188,
      "new_path": "src/test/java/com/google/devtools/build/lib/bazel/bzlmod/FakeRegistry.java"
    },
    {
      "type": "modify",
      "old_id": "1aac36dee9e7c19edc12b74291d3bdd5c62b72c8",
      "old_mode": 33188,
      "old_path": "src/test/java/com/google/devtools/build/lib/bazel/bzlmod/IndexRegistryTest.java",
      "new_id": "f2732b954cb836acc9efed8e38b5353ffd900c93",
      "new_mode": 33188,
      "new_path": "src/test/java/com/google/devtools/build/lib/bazel/bzlmod/IndexRegistryTest.java"
    }
  ]
}