tree f0b2249b3de2ac18ae63eae762cacfeef399b9f5
parent c046f9675d188fcd856119e8f1e9e035727659b1
author Keith Smiley <keithbsmiley@gmail.com> 1645539706 -0800
committer Copybara-Service <copybara-worker@google.com> 1645539812 -0800

Fix aggressive params file assumption

Most programs that accept params files use the `@file` syntax. For Apple
platform builds `@` can be the start of non-params file arguments as
well, such as `-rpath @executable_path/Frameworks`. There is a small
list of options where this is the case, so this new behavior no longer
assumes params files if args start with `@`, they also have to not start
with one of the 3 keywords used with this (from `man dyld` on macOS).
This should always hold since params files generated by bazel should
always start with `bazel-out`, if someone renames the symlinks to one of
the keywords, they're on their own.

Previously the workaround was to always make sure to pass the
`-Wl,-rpath,@executable_path` form of these arguments, but this makes
users not have to worry about this.

In a few other places we check this by checking if the file exists,
which is likely more accurate, but feels excessive and potentially
dangerous in this context.

Related: https://github.com/bazelbuild/bazel/pull/13148
Fixes: https://github.com/bazelbuild/bazel/issues/14316

Closes #14650.

PiperOrigin-RevId: 430195929