tree d4758e2fbb912fdc61609a75855b527ac5e228b0
parent 25bb5f009eb664de9d006345b27b1d1aa8b1d0e1
author Googler <arostovtsev@google.com> 1727891247 -0700
committer Copybara-Service <copybara-worker@google.com> 1727891347 -0700

Fix memory regression in RuleVisibility

Benchmarks show that https://github.com/bazelbuild/bazel/commit/cd82f68cfdf44aabaea1931ea9ff870ec7bb4af1 introduced a memory regression. Fix it by:

* memoizing the very frequently used ["//visibility:public"] and
  ["//visibility:private"] declared labels lists
* for filtering out private labels, using a list builder with a known
  expected size instead of relying on the streams api

I also experimented with feeding the simplified visibility label lists
back into the package builder's list interner - but decided against it
because benchmarks show it results in a slightly higher memory usage.

PiperOrigin-RevId: 681511741
Change-Id: I498e4adca976834d6b137b106f9d202c793bb54d