tree 817cc7c546e54e273870542858207fbe0204000c
parent dbcf260e0318ef553d606b0510832cfe8a5b14eb
author Googler <ilist@google.com> 1665075284 -0700
committer Copybara-Service <copybara-worker@google.com> 1665075371 -0700

Fix a NPE in compatible target skipping

Under a complex set of conditions a NPE is triggered. It was caused by IncompatibleTargetChecker constructing a RuleConfiguredTarget without adding a VisibilityProviderImpl to it. All other locations where RuleConfiguredTarget is constructed add the provider, namely RuleConfiguredTargetBuilder.

When the set of conditions is met, code path checking the visibility retrieves the provider without checking if it's available.

The data in VisibilityProvider is duplicated with the data already in RuleConfiguredTarget. Fix by removing the provider and retrieving the data directly.

Add the regression test with description how it happens.

PiperOrigin-RevId: 479339612
Change-Id: I8e29a9882de87d884f53e104ae14d6a126a8096b