tree 5453bb1236f0591d90b60a277cc4e9802fdf9e0e
parent f34458b65f6ac8605f29f8773e43c545578b1f91
author iirina <elenairina@google.com> 1559310261 -0700
committer Copybara-Service <copybara-worker@google.com> 1559310316 -0700

Fix jacoco-toolchain dependency.

Bazel 0.26 added the `jacocorunner` attribute on `java_toolchain`. Java targets now fail when using the new host java_toolchain because of a dependency cycle:

```
@bazel_tools//tools/jdk:JacocoCoverageRunner
@bazel_tools//tools/jdk:current_java_toolchain
@bazel_tools//tools/jdk:legacy_current_java_toolchain
@bazel_tools//tools/jdk:remote_toolchain
@remote_java_tools_linux//:toolchain
.-> @remote_java_tools_linux//:jacoco_coverage_runner (host)
|   @bazel_tools//tools/jdk:current_java_toolchain (host)
|   @bazel_tools//tools/jdk:legacy_current_java_toolchain (host)
|   @bazel_tools//tools/jdk:remote_toolchain (host)
|   @remote_java_tools_linux//:toolchain (host)
`-- @remote_java_tools_linux//:jacoco_coverage_runner (host)
```

The dependency is happening because `jacocorunner` in `java_toolchain` was declared as a `java_import` which depends on the host `java_toolchain`. The issue was not caught because we only run the java integration tests with `--java_toolchain` built at head. If we had run the tests also with `--host_java_toolchain` the issue would have been caught (see #8530).

This PR does the following:
* Makes `jacocorunner` attribute a `filegroup` instead of a `java_import` to avoid the dependency cycle.
* Converts the type of `jacocoRunner` in `JavaToolchain` from a `TransitiveInfoCollection` to `FilesToRunProvider` to be able to retrieve the executable jar from the `filegroup`.
* Adds testing with `--host_java_toolchain` of the java_tools built as head

This is a blocker for the new java_tools release (https://github.com/bazelbuild/java_tools/issues/8).

Closes #8529.

PiperOrigin-RevId: 250876908