)]}'
{
  "commit": "41ec5a28fb30a8d6c5c60194c4bb29528352cf78",
  "tree": "ca31bf8b615e195f882704d94be79e20e337466a",
  "parents": [
    "38c7c612c441619e87a30267ef861026dd672111"
  ],
  "author": {
    "name": "laszlocsomor",
    "email": "laszlocsomor@google.com",
    "time": "Wed Jan 08 06:57:32 2020 -0800"
  },
  "committer": {
    "name": "Copybara-Service",
    "email": "copybara-worker@google.com",
    "time": "Wed Jan 08 06:58:26 2020 -0800"
  },
  "message": "SkyframeBuildView: move action conflict checking\n\nBazel will now delay checking for action conflicts\nuntil it has collected \"good\" Aspects and CTs and\nhas created the PackageRoots, because doing so\nwill let us move the collection and creation logic\ninto a SkyFunction and so reduce code outside of\nSkyframe between Analysis and Execution, and\nthereby allow us to maybe merge the two phases\nsome time in the future.\n\nI believe the collection and creation logic does\nnot actually depend on the result of action\nconflict checking, making this change safe.\n\nI believe this because the collection logic does\nnot actually use the \u0027badActions\u0027 map, and while\nit looks up SkyValues from the EvaluationResult,\nthose are supposed to be immutable, so the\nconflict checker could not be storing anything in\nthem, therefore the collection logic cannot\npossibly be filtering CTs with bad actions.\n\nTherefore \"good\" in the variable names \"goodCts\"\nand \"goodAspects\" is misleading, and also the\ncomment that claimed the \"goodCts\" collection\nlogic was filtering out CTs with bad actions was\nwrong, so I renamed these variables and I removed\nthe comment.\n\nI also fixed a minor bug: the \u0027aspects\u0027 list\n(previously: \u0027goodAspects\u0027) was initialized with\nan expected size of \u0027ctKeys.size()\u0027, now it is\ninitialized with the \u0027aspectKeys.size()\u0027.\n\nPiperOrigin-RevId: 288687661\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "6d33809f1ef9aa872bfb89a8465206bc940b00f5",
      "old_mode": 33188,
      "old_path": "src/main/java/com/google/devtools/build/lib/skyframe/SkyframeBuildView.java",
      "new_id": "b87a2b16a6f05d102f40f59078ea68245c8bb6bd",
      "new_mode": 33188,
      "new_path": "src/main/java/com/google/devtools/build/lib/skyframe/SkyframeBuildView.java"
    }
  ]
}