blob: 80a98e0e58716379af573b22c1700261a990f1ac [file] [log] [blame]
// Copyright 2014 The Bazel Authors. All rights reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package com.google.devtools.build.lib.rules.cpp;
import com.google.common.annotations.VisibleForTesting;
import com.google.common.base.Preconditions;
import com.google.common.base.Throwables;
import com.google.common.collect.ImmutableCollection;
import com.google.common.collect.ImmutableList;
import com.google.common.collect.ImmutableMap;
import com.google.common.collect.ImmutableSet;
import com.google.common.collect.Iterables;
import com.google.common.collect.Sets;
import com.google.common.io.ByteStreams;
import com.google.common.util.concurrent.ListenableFuture;
import com.google.devtools.build.lib.actions.AbstractAction;
import com.google.devtools.build.lib.actions.ActionContinuationOrResult;
import com.google.devtools.build.lib.actions.ActionEnvironment;
import com.google.devtools.build.lib.actions.ActionExecutionContext;
import com.google.devtools.build.lib.actions.ActionExecutionException;
import com.google.devtools.build.lib.actions.ActionInput;
import com.google.devtools.build.lib.actions.ActionKeyContext;
import com.google.devtools.build.lib.actions.ActionOwner;
import com.google.devtools.build.lib.actions.ActionResult;
import com.google.devtools.build.lib.actions.Artifact;
import com.google.devtools.build.lib.actions.ArtifactResolver;
import com.google.devtools.build.lib.actions.CommandAction;
import com.google.devtools.build.lib.actions.CommandLine;
import com.google.devtools.build.lib.actions.CommandLineExpansionException;
import com.google.devtools.build.lib.actions.CommandLines.CommandLineAndParamFileInfo;
import com.google.devtools.build.lib.actions.CommandLines.ParamFileActionInput;
import com.google.devtools.build.lib.actions.EnvironmentalExecException;
import com.google.devtools.build.lib.actions.ExecException;
import com.google.devtools.build.lib.actions.ExecutionRequirements;
import com.google.devtools.build.lib.actions.ParameterFile.ParameterFileType;
import com.google.devtools.build.lib.actions.ResourceSet;
import com.google.devtools.build.lib.actions.SimpleSpawn;
import com.google.devtools.build.lib.actions.Spawn;
import com.google.devtools.build.lib.actions.SpawnContinuation;
import com.google.devtools.build.lib.actions.SpawnResult;
import com.google.devtools.build.lib.actions.SpawnStrategy;
import com.google.devtools.build.lib.actions.extra.CppCompileInfo;
import com.google.devtools.build.lib.actions.extra.EnvironmentVariable;
import com.google.devtools.build.lib.actions.extra.ExtraActionInfo;
import com.google.devtools.build.lib.analysis.skylark.Args;
import com.google.devtools.build.lib.cmdline.LabelConstants;
import com.google.devtools.build.lib.collect.CollectionUtils;
import com.google.devtools.build.lib.collect.compacthashset.CompactHashSet;
import com.google.devtools.build.lib.collect.nestedset.NestedSet;
import com.google.devtools.build.lib.collect.nestedset.NestedSetBuilder;
import com.google.devtools.build.lib.collect.nestedset.Order;
import com.google.devtools.build.lib.concurrent.ThreadSafety.ThreadCompatible;
import com.google.devtools.build.lib.packages.StarlarkSemanticsOptions;
import com.google.devtools.build.lib.profiler.AutoProfiler;
import com.google.devtools.build.lib.profiler.Profiler;
import com.google.devtools.build.lib.profiler.ProfilerTask;
import com.google.devtools.build.lib.profiler.SilentCloseable;
import com.google.devtools.build.lib.rules.cpp.CcCommon.CoptsFilter;
import com.google.devtools.build.lib.rules.cpp.CcCompilationContext.IncludeScanningHeaderDataHelper;
import com.google.devtools.build.lib.rules.cpp.CcToolchainFeatures.FeatureConfiguration;
import com.google.devtools.build.lib.rules.cpp.IncludeScanner.IncludeScanningHeaderData;
import com.google.devtools.build.lib.skyframe.ActionExecutionValue;
import com.google.devtools.build.lib.skylarkbuildapi.CommandLineArgsApi;
import com.google.devtools.build.lib.syntax.EvalException;
import com.google.devtools.build.lib.syntax.Sequence;
import com.google.devtools.build.lib.syntax.StarlarkList;
import com.google.devtools.build.lib.util.DependencySet;
import com.google.devtools.build.lib.util.Fingerprint;
import com.google.devtools.build.lib.util.ShellEscaper;
import com.google.devtools.build.lib.util.io.FileOutErr;
import com.google.devtools.build.lib.vfs.FileSystemUtils;
import com.google.devtools.build.lib.vfs.IORuntimeException;
import com.google.devtools.build.lib.vfs.Path;
import com.google.devtools.build.lib.vfs.PathFragment;
import com.google.devtools.build.lib.vfs.Root;
import com.google.devtools.build.skyframe.SkyFunction;
import com.google.devtools.build.skyframe.SkyKey;
import com.google.devtools.build.skyframe.SkyValue;
import java.io.IOException;
import java.io.InputStream;
import java.nio.charset.StandardCharsets;
import java.util.ArrayList;
import java.util.Collection;
import java.util.Collections;
import java.util.HashMap;
import java.util.HashSet;
import java.util.Iterator;
import java.util.LinkedHashMap;
import java.util.LinkedHashSet;
import java.util.List;
import java.util.Map;
import java.util.Set;
import java.util.UUID;
import java.util.concurrent.ExecutionException;
import java.util.concurrent.TimeUnit;
import java.util.logging.Logger;
import javax.annotation.Nullable;
/** Action that represents some kind of C++ compilation step. */
@ThreadCompatible
public class CppCompileAction extends AbstractAction implements IncludeScannable, CommandAction {
private static final Logger logger = Logger.getLogger(CppCompileAction.class.getName());
private static final PathFragment BUILD_PATH_FRAGMENT = PathFragment.create("BUILD");
private static final boolean VALIDATION_DEBUG_WARN = false;
protected final Artifact outputFile;
private final Artifact sourceFile;
private final CppConfiguration cppConfiguration;
private final NestedSet<Artifact> mandatoryInputs;
private final NestedSet<Artifact> inputsForInvalidation;
/**
* The set of input files that in addition to {@link CcCompilationContext#getDeclaredIncludeSrcs}
* need to be added to the set of input artifacts of the action if we don't use input discovery.
* They may be pruned after execution. See {@link #findUsedHeaders} for more details.
*/
private final NestedSet<Artifact> additionalPrunableHeaders;
@Nullable private final Artifact grepIncludes;
private final boolean shareable;
private final boolean shouldScanIncludes;
private final boolean shouldPruneModules;
private final boolean usePic;
private final boolean useHeaderModules;
private final boolean needsDotdInputPruning;
protected final boolean needsIncludeValidation;
private final IncludeProcessing includeProcessing;
private final CcCompilationContext ccCompilationContext;
private final ImmutableList<Artifact> builtinIncludeFiles;
// A list of files to include scan that are not source files, pcm files, or
// included via a command-line "-include file.h". Actions that use non C++ files as source
// files--such as Clif--may use this mechanism.
private final ImmutableList<Artifact> additionalIncludeScanningRoots;
@VisibleForTesting public final CompileCommandLine compileCommandLine;
/**
* The fingerprint of {@link #compileCommandLine}. This is computed lazily so that the command
* line is not unnecessarily flattened outside of action execution.
*/
byte[] commandLineKey;
private final ImmutableMap<String, String> executionInfo;
private final String actionName;
private final FeatureConfiguration featureConfiguration;
/**
* Identifier for the actual execution time behavior of the action.
*
* <p>Required because the behavior of this class can be modified by injecting code in the
* constructor or by inheritance, and we want to have different cache keys for those.
*/
private final UUID actionClassId;
private final ImmutableList<PathFragment> builtInIncludeDirectories;
/**
* Set when the action prepares for execution. Used to preserve state between preparation and
* execution.
*/
private NestedSet<Artifact> additionalInputs;
/**
* Used only during input discovery, when input discovery requires other actions to be executed
* first.
*/
private Collection<Artifact.DerivedArtifact> usedModules;
/**
* This field is set only for C++ module compiles (compiling .cppmap files into .pcm files). It
* stores the modules necessary for building this module as they will later also be required for
* building users of this module. Such users can get to this data through this action's {@link
* com.google.devtools.build.lib.skyframe.ActionExecutionValue}
*
* <p>This field is populated either based on the discovered headers in {@link #discoverInputs} or
* extracted from the action inputs when restoring it from the action cache.
*/
private NestedSet<Artifact> discoveredModules = null;
/** Used modules that are not transitively used through other topLevelModules. */
private NestedSet<Artifact> topLevelModules;
private CcToolchainVariables overwrittenVariables;
private ParamFileActionInput paramFileActionInput;
private PathFragment paramFilePath;
private final Iterable<Artifact> alternateIncludeScanningDataInputs;
/**
* Creates a new action to compile C/C++ source files.
*
* @param owner the owner of the action, usually the configured target that emitted it
* @param featureConfiguration TODO(bazel-team): Add parameter description.
* @param variables TODO(bazel-team): Add parameter description.
* @param sourceFile the source file that should be compiled. {@code mandatoryInputs} must contain
* this file
* @param shouldScanIncludes a boolean indicating whether scanning of {@code sourceFile} is to be
* performed looking for inclusions.
* @param usePic TODO(bazel-team): Add parameter description.
* @param mandatoryInputs any additional files that need to be present for the compilation to
* succeed, can be empty but not null, for example, extra sources for FDO.
* @param inputsForInvalidation are there only to invalidate this action when they change, but are
* not needed during actual execution.
* @param outputFile the object file that is written as result of the compilation, or the fake
* object for {@link FakeCppCompileAction}s
* @param dotdFile the .d file that is generated as a side-effect of compilation
* @param gcnoFile the coverage notes that are written in coverage mode, can be null
* @param dwoFile the .dwo output file where debug information is stored for Fission builds (null
* if Fission mode is disabled)
* @param ccCompilationContext the {@code CcCompilationContext}
* @param coptsFilter regular expression to remove options from {@code copts}
* @param additionalIncludeScanningRoots list of additional artifacts to include-scan
* @param actionClassId TODO(bazel-team): Add parameter description
* @param actionName a string giving the name of this action for the purpose of toolchain
* evaluation
* @param cppSemantics C++ compilation semantics
* @param builtInIncludeDirectories - list of toolchain-defined builtin include directories.
*/
CppCompileAction(
ActionOwner owner,
FeatureConfiguration featureConfiguration,
CcToolchainVariables variables,
Artifact sourceFile,
CppConfiguration cppConfiguration,
boolean shareable,
boolean shouldScanIncludes,
boolean shouldPruneModules,
boolean usePic,
boolean useHeaderModules,
NestedSet<Artifact> mandatoryInputs,
NestedSet<Artifact> inputsForInvalidation,
ImmutableList<Artifact> builtinIncludeFiles,
NestedSet<Artifact> additionalPrunableHeaders,
Artifact outputFile,
Artifact dotdFile,
@Nullable Artifact gcnoFile,
@Nullable Artifact dwoFile,
@Nullable Artifact ltoIndexingFile,
ActionEnvironment env,
CcCompilationContext ccCompilationContext,
CoptsFilter coptsFilter,
ImmutableList<Artifact> additionalIncludeScanningRoots,
UUID actionClassId,
ImmutableMap<String, String> executionInfo,
String actionName,
CppSemantics cppSemantics,
ImmutableList<PathFragment> builtInIncludeDirectories,
@Nullable Artifact grepIncludes) {
super(
owner,
NestedSetBuilder.fromNestedSet(mandatoryInputs)
.addTransitive(inputsForInvalidation)
.build(),
CollectionUtils.asSetWithoutNulls(outputFile, dotdFile, gcnoFile, dwoFile, ltoIndexingFile),
env);
Preconditions.checkArgument(!shouldPruneModules || shouldScanIncludes);
this.outputFile = Preconditions.checkNotNull(outputFile);
this.sourceFile = sourceFile;
this.shareable = shareable;
this.cppConfiguration = cppConfiguration;
// We do not need to include the middleman artifact since it is a generated artifact and will
// definitely exist prior to this action execution.
this.mandatoryInputs = mandatoryInputs;
this.inputsForInvalidation = inputsForInvalidation;
this.additionalPrunableHeaders = additionalPrunableHeaders;
this.shouldScanIncludes = shouldScanIncludes;
this.shouldPruneModules = shouldPruneModules;
this.usePic = usePic;
this.useHeaderModules = useHeaderModules;
this.ccCompilationContext = ccCompilationContext;
this.builtinIncludeFiles = builtinIncludeFiles;
this.additionalIncludeScanningRoots =
Preconditions.checkNotNull(additionalIncludeScanningRoots);
this.compileCommandLine =
buildCommandLine(
sourceFile, coptsFilter, actionName, dotdFile, featureConfiguration, variables);
this.executionInfo = executionInfo;
this.actionName = actionName;
this.featureConfiguration = featureConfiguration;
this.needsDotdInputPruning =
cppSemantics.needsDotdInputPruning() && !sourceFile.isFileType(CppFileTypes.CPP_MODULE);
this.needsIncludeValidation = cppSemantics.needsIncludeValidation();
this.includeProcessing = cppSemantics.getIncludeProcessing();
this.actionClassId = actionClassId;
this.builtInIncludeDirectories = builtInIncludeDirectories;
this.additionalInputs = null;
this.usedModules = null;
this.topLevelModules = null;
this.overwrittenVariables = null;
this.grepIncludes = grepIncludes;
if (featureConfiguration.isEnabled(CppRuleClasses.COMPIILER_PARAM_FILE)) {
paramFilePath =
outputFile
.getExecPath()
.getParentDirectory()
.getChild(outputFile.getFilename() + ".params");
}
this.alternateIncludeScanningDataInputs = cppSemantics.getAlternateIncludeScanningDataInputs();
}
static CompileCommandLine buildCommandLine(
Artifact sourceFile,
CoptsFilter coptsFilter,
String actionName,
Artifact dotdFile,
FeatureConfiguration featureConfiguration,
CcToolchainVariables variables) {
return CompileCommandLine.builder(sourceFile, coptsFilter, actionName, dotdFile)
.setFeatureConfiguration(featureConfiguration)
.setVariables(variables)
.build();
}
/**
* Whether we should do "include scanning". Note that this does *not* mean whether we should parse
* the .d files to determine which include files were used during compilation. Instead, this means
* whether we should a) run the pre-execution include scanner (see {@code IncludeScanningContext})
* if one exists and b) whether the action inputs should be modified to match the results of that
* pre-execution scanning and (if enabled) again after execution to match the results of the .d
* file parsing.
*
* <p>This does *not* have anything to do with "hdrs_check".
*/
public boolean shouldScanIncludes() {
return shouldScanIncludes;
}
private boolean shouldScanDotdFiles() {
return !useHeaderModules || !shouldPruneModules;
}
public boolean useInMemoryDotdFiles() {
return cppConfiguration.getInmemoryDotdFiles();
}
@Override
public List<PathFragment> getBuiltInIncludeDirectories() {
return builtInIncludeDirectories;
}
@Nullable
@Override
public List<Artifact> getBuiltInIncludeFiles() {
return builtinIncludeFiles;
}
@Override
public NestedSet<Artifact> getMandatoryInputs() {
return mandatoryInputs;
}
@Override
public ImmutableSet<Artifact> getMandatoryOutputs() {
// Never prune orphaned modules files. To cut down critical paths, CppCompileActions do not
// add modules files as inputs. Instead they rely on input discovery to recognize the needed
// ones. However, orphan detection runs before input discovery and thus module files would be
// discarded as orphans.
// This is strictly better than marking all transitive modules as inputs, which would also
// effectively disable orphan detection for .pcm files.
if (outputFile.isFileType(CppFileTypes.CPP_MODULE)) {
return ImmutableSet.of(outputFile);
}
return super.getMandatoryOutputs();
}
/**
* Returns the list of additional inputs found by dependency discovery, during action preparation.
* {@link #discoverInputs(ActionExecutionContext)} must be called before this method is called on
* each action execution.
*/
public NestedSet<Artifact> getAdditionalInputs() {
return Preconditions.checkNotNull(additionalInputs);
}
/** Clears the discovered {@link #additionalInputs}. */
public void clearAdditionalInputs() {
additionalInputs = null;
}
@Override
public boolean discoversInputs() {
return shouldScanIncludes || needsDotdInputPruning;
}
@Override
@VisibleForTesting // productionVisibility = Visibility.PRIVATE
public NestedSet<Artifact> getPossibleInputsForTesting() {
return NestedSetBuilder.fromNestedSet(getInputs())
.addTransitive(ccCompilationContext.getDeclaredIncludeSrcs())
.addTransitive(additionalPrunableHeaders)
.build();
}
/**
* Returns the results of include scanning or, when that is null, all prunable headers.
*
* <p>This is necessary because the inputs that can be pruned by .d file parsing must be returned
* from {@link #discoverInputs(ActionExecutionContext)} and they cannot be in {@link
* #mandatoryInputs}. Thus, even with include scanning turned off, we pretend that we "discover"
* these headers.
*/
private NestedSet<Artifact> findUsedHeaders(
ActionExecutionContext actionExecutionContext, IncludeScanningHeaderData headerData)
throws ActionExecutionException, InterruptedException {
try {
try {
ListenableFuture<List<Artifact>> future =
actionExecutionContext
.getContext(CppIncludeScanningContext.class)
.findAdditionalInputs(this, actionExecutionContext, includeProcessing, headerData);
if (future == null) {
return NestedSetBuilder.fromNestedSet(ccCompilationContext.getDeclaredIncludeSrcs())
.addTransitive(additionalPrunableHeaders)
.build();
}
return NestedSetBuilder.wrap(Order.STABLE_ORDER, future.get());
} catch (ExecutionException e) {
Throwables.throwIfInstanceOf(e.getCause(), ExecException.class);
Throwables.throwIfInstanceOf(e.getCause(), InterruptedException.class);
if (e.getCause() instanceof IORuntimeException) {
throw new EnvironmentalExecException(
((IORuntimeException) e.getCause()).getCauseIOException());
}
if (e.getCause() instanceof IOException) {
throw new EnvironmentalExecException((IOException) e.getCause());
}
Throwables.throwIfUnchecked(e.getCause());
throw new IllegalStateException(e.getCause());
}
} catch (ExecException e) {
throw e.toActionExecutionException(
"Include scanning of rule '" + getOwner().getLabel() + "'",
actionExecutionContext.getVerboseFailures(),
this);
}
}
/**
* Filters discovered headers according to declared rule inputs. This fundamentally mirrors the
* behavior of {@link #validateInclusions} and just removes inputs that would be considered
* invalid from {@code headers}. That way, the compiler does not get access to them (assuming a
* sand-boxed environment) and can diagnose the missing headers.
*/
private NestedSet<Artifact> filterDiscoveredHeaders(
ActionExecutionContext actionExecutionContext,
NestedSet<Artifact> headers,
List<CcCompilationContext.HeaderInfo> headerInfo) {
Set<Artifact> undeclaredHeaders = Sets.newHashSet(headers.toList());
// Remove all declared headers and find out which modules were used while at it.
CcCompilationContext.HeadersAndModules headersAndModules =
ccCompilationContext.computeDeclaredHeadersAndUsedModules(
usePic, undeclaredHeaders, headerInfo);
usedModules = ImmutableList.copyOf(headersAndModules.modules);
undeclaredHeaders.removeAll(headersAndModules.headers);
// Note that this (compared to validateInclusions) does not take mandatoryInputs into account.
// The reason is that these by definition get added to the action input and thus are available
// anyway. Not having to look at them here saves us from requiring and ArtifactExpander, which
// actionExecutionContext doesn't have at this point. This only works as long as mandatory
// inputs do not contain headers that are built into a module.
for (Artifact source : getIncludeScannerSources()) {
undeclaredHeaders.remove(source);
}
for (Artifact header : additionalPrunableHeaders.toList()) {
undeclaredHeaders.remove(header);
}
if (undeclaredHeaders.isEmpty()) {
return headers;
}
Iterable<PathFragment> ignoreDirs =
cppConfiguration.isStrictSystemIncludes()
? getBuiltInIncludeDirectories()
: getValidationIgnoredDirs();
Set<Artifact> missing = Sets.newHashSet();
// Lazily initialize, so that compiles that properly declare all their files profit.
Set<PathFragment> declaredIncludeDirs = null;
for (Artifact header : undeclaredHeaders) {
if (FileSystemUtils.startsWithAny(header.getExecPath(), ignoreDirs)) {
continue;
}
if (declaredIncludeDirs == null) {
declaredIncludeDirs = ccCompilationContext.getDeclaredIncludeDirs().toSet();
}
if (!isDeclaredIn(cppConfiguration, actionExecutionContext, header, declaredIncludeDirs)) {
missing.add(header);
}
}
if (missing.isEmpty()) {
return headers;
}
return NestedSetBuilder.wrap(
Order.STABLE_ORDER,
Iterables.filter(headers.toList(), header -> !missing.contains(header)));
}
/**
* This method returns null when a required SkyValue is missing and a Skyframe restart is
* required.
*/
// Note: this function will be deleted in the migration cl.
@Nullable
private static IncludeScanningHeaderData.Builder createIncludeScanningHeaderData(
SkyFunction.Environment env,
List<CcCompilationContext.HeaderInfo> headerInfos,
Iterable<Artifact> inputs)
throws InterruptedException {
Map<PathFragment, Artifact> pathToLegalOutputArtifact = new HashMap<>();
ArrayList<Artifact> treeArtifacts = new ArrayList<>();
// Not using range-based for loops here and below as the additional overhead of the
// ImmutableList iterators has shown up in profiles.
for (CcCompilationContext.HeaderInfo headerInfo : headerInfos) {
for (Artifact a : headerInfo.modularHeaders) {
IncludeScanningHeaderDataHelper.handleArtifact(a, pathToLegalOutputArtifact, treeArtifacts);
}
for (Artifact a : headerInfo.textualHeaders) {
IncludeScanningHeaderDataHelper.handleArtifact(a, pathToLegalOutputArtifact, treeArtifacts);
}
}
for (Artifact a : inputs) {
IncludeScanningHeaderDataHelper.handleArtifact(a, pathToLegalOutputArtifact, treeArtifacts);
}
if (!IncludeScanningHeaderDataHelper.handleTreeArtifacts(
env, pathToLegalOutputArtifact, treeArtifacts)) {
return null;
}
return new IncludeScanningHeaderData.Builder(
Collections.unmodifiableMap(pathToLegalOutputArtifact),
Collections.unmodifiableSet(CompactHashSet.create()));
}
/**
* This method returns null when a required SkyValue is missing and a Skyframe restart is
* required.
*/
@Nullable
public IncludeScanningHeaderData.Builder createIncludeScanningHeaderData(
SkyFunction.Environment env,
boolean usePic,
boolean useHeaderModules,
List<CcCompilationContext.HeaderInfo> headerInfo)
throws InterruptedException {
if (alternateIncludeScanningDataInputs != null) {
return createIncludeScanningHeaderData(env, headerInfo, alternateIncludeScanningDataInputs);
} else {
return ccCompilationContext.createIncludeScanningHeaderData(
env, usePic, useHeaderModules, headerInfo);
}
}
/**
* This method returns null when a required SkyValue is missing and a Skyframe restart is
* required.
*/
@Nullable
@Override
public NestedSet<Artifact> discoverInputs(ActionExecutionContext actionExecutionContext)
throws ActionExecutionException, InterruptedException {
Preconditions.checkArgument(!sourceFile.isFileType(CppFileTypes.CPP_MODULE));
if (additionalInputs == null) {
List<String> options;
try {
options = getCompilerOptions();
} catch (CommandLineExpansionException e) {
throw new ActionExecutionException(
"failed to generate compile command for rule '"
+ getOwner().getLabel()
+ ": "
+ e.getMessage(),
this,
/* catastrophe= */ false);
}
commandLineKey = computeCommandLineKey(options);
List<PathFragment> systemIncludeDirs = getSystemIncludeDirs(options);
List<CcCompilationContext.HeaderInfo> headerInfo =
ccCompilationContext.getTransitiveHeaderInfos();
IncludeScanningHeaderData.Builder includeScanningHeaderData =
createIncludeScanningHeaderData(
actionExecutionContext.getEnvironmentForDiscoveringInputs(),
usePic,
useHeaderModules,
headerInfo);
if (includeScanningHeaderData == null) {
return null;
}
additionalInputs =
findUsedHeaders(
actionExecutionContext,
includeScanningHeaderData
.setSystemIncludeDirs(systemIncludeDirs)
.setCmdlineIncludes(getCmdlineIncludes(options))
.build());
if (needsIncludeValidation) {
verifyActionIncludePaths(
systemIncludeDirs,
actionExecutionContext
.getOptions()
.getOptions(StarlarkSemanticsOptions.class)
.experimentalSiblingRepositoryLayout);
}
if (!shouldScanIncludes) {
return additionalInputs;
}
if (!shouldScanDotdFiles()) {
// If we aren't looking at .d files later, remove undeclared inputs now.
additionalInputs =
filterDiscoveredHeaders(actionExecutionContext, additionalInputs, headerInfo);
}
}
if (usedModules == null) {
// There are two paths in which this can be reached:
// 1. This is not a modular compilation or one without include scanning. In either case, we
// never compute used modules.
// 2. This function has completed on a previous execution, adding all used modules to
// additionalInputs and resetting usedModules to null below.
// In either case, there is nothing more to do here.
return additionalInputs;
}
Map<Artifact, NestedSet<? extends Artifact>> transitivelyUsedModules =
computeTransitivelyUsedModules(
actionExecutionContext.getEnvironmentForDiscoveringInputs(), usedModules);
if (transitivelyUsedModules == null) {
return null;
}
// Compute top-level modules, i.e. used modules that aren't also dependencies of other
// used modules. Combining the NestedSets of transitive deps of the top-level modules also
// gives us an effective way to compute and store discoveredModules.
Set<Artifact> topLevel = new LinkedHashSet<>(usedModules);
try (AutoProfiler ignored =
AutoProfiler.logged("nested set expansion", logger, TimeUnit.SECONDS.toMillis(5))) {
for (NestedSet<? extends Artifact> transitive : transitivelyUsedModules.values()) {
// It is better to iterate over each nested set here instead of creating a joint one and
// iterating over it, as this makes use of NestedSet's memoization (each of them has likely
// been iterated over before). Don't use Set.removeAll() here as that iterates over the
// smaller set (topLevel, which would support efficient lookup) and looks up in the larger
// one (transitive, which is a linear scan).
// We get a collection view of the NestedSet in a way that can throw an InterruptedException
// because a NestedSet may contain a future.
for (Artifact module : transitive.toListInterruptibly()) {
topLevel.remove(module);
}
}
}
NestedSetBuilder<Artifact> topLevelModulesBuilder = NestedSetBuilder.stableOrder();
NestedSetBuilder<Artifact> discoveredModulesBuilder = NestedSetBuilder.stableOrder();
for (Artifact module : topLevel) {
topLevelModulesBuilder.add(module);
discoveredModulesBuilder.addTransitive(transitivelyUsedModules.get(module));
}
topLevelModules = topLevelModulesBuilder.build();
discoveredModulesBuilder.addTransitive(topLevelModules);
NestedSet<Artifact> discoveredModules = discoveredModulesBuilder.buildInterruptibly();
additionalInputs =
NestedSetBuilder.fromNestedSet(additionalInputs).addTransitive(discoveredModules).build();
if (outputFile.isFileType(CppFileTypes.CPP_MODULE)) {
this.discoveredModules = discoveredModules;
}
usedModules = null;
return additionalInputs;
}
@Override
public Artifact getPrimaryInput() {
return getSourceFile();
}
@Override
public Artifact getPrimaryOutput() {
return getOutputFile();
}
/** Returns the path of the c/cc source for gcc. */
public final Artifact getSourceFile() {
return compileCommandLine.getSourceFile();
}
/**
* Returns the path where gcc should put its result.
*/
public Artifact getOutputFile() {
return outputFile;
}
@Override
@Nullable
public Artifact getGrepIncludes() {
return grepIncludes;
}
/**
* Set by {@link #discoverInputs}. Returns a subset of {@link #getAdditionalInputs()} or null, if
* this is not a compile action producing a C++ module.
*/
@Override
@Nullable
public NestedSet<Artifact> getDiscoveredModules() {
return discoveredModules;
}
/** Returns the path where the compiler should put the discovered dependency information. */
public Artifact getDotdFile() {
return compileCommandLine.getDotdFile();
}
@VisibleForTesting
public CcCompilationContext getCcCompilationContext() {
return ccCompilationContext;
}
@Override
public List<PathFragment> getQuoteIncludeDirs() {
ImmutableList.Builder<PathFragment> result = ImmutableList.builder();
result.addAll(ccCompilationContext.getQuoteIncludeDirs());
ImmutableList<String> copts = compileCommandLine.getCopts();
for (int i = 0; i < copts.size(); i++) {
String opt = copts.get(i);
if (opt.startsWith("-iquote")) {
if (opt.length() > 7) {
result.add(PathFragment.create(opt.substring(7).trim()));
} else if (i + 1 < copts.size()) {
i++;
result.add(PathFragment.create(copts.get(i)));
} else {
System.err.println("WARNING: dangling -iquote flag in options for " + prettyPrint());
}
}
}
return result.build();
}
@Override
public List<PathFragment> getIncludeDirs() {
ImmutableList.Builder<PathFragment> result = ImmutableList.builder();
result.addAll(ccCompilationContext.getIncludeDirs());
for (String opt : compileCommandLine.getCopts()) {
if (opt.startsWith("-I") && opt.length() > 2) {
// We insist on the combined form "-Idir".
result.add(PathFragment.create(opt.substring(2)));
}
}
return result.build();
}
@Override
public ImmutableList<PathFragment> getFrameworkIncludeDirs() {
return ccCompilationContext.getFrameworkIncludeDirs();
}
@VisibleForTesting
List<PathFragment> getSystemIncludeDirs() throws CommandLineExpansionException {
return getSystemIncludeDirs(getCompilerOptions());
}
private List<PathFragment> getSystemIncludeDirs(List<String> compilerOptions) {
// TODO(bazel-team): parsing the command line flags here couples us to gcc-style compiler
// command lines; use a different way to specify system includes (for example through a
// system_includes attribute in cc_toolchain); note that that would disallow users from
// specifying system include paths via the copts attribute.
// Currently, this works together with the include_paths features because getCommandLine() will
// get the system include paths from the {@code CcCompilationContext} instead.
ImmutableList.Builder<PathFragment> result = ImmutableList.builder();
for (int i = 0; i < compilerOptions.size(); i++) {
String opt = compilerOptions.get(i);
if (opt.startsWith("-isystem")) {
if (opt.length() > 8) {
result.add(PathFragment.create(opt.substring(8).trim()));
} else if (i + 1 < compilerOptions.size()) {
i++;
result.add(PathFragment.create(compilerOptions.get(i)));
} else {
System.err.println("WARNING: dangling -isystem flag in options for " + prettyPrint());
}
}
}
return result.build();
}
private List<String> getCmdlineIncludes(List<String> args) {
ImmutableList.Builder<String> cmdlineIncludes = ImmutableList.builder();
for (Iterator<String> argi = args.iterator(); argi.hasNext();) {
String arg = argi.next();
if (arg.equals("-include") && argi.hasNext()) {
cmdlineIncludes.add(argi.next());
}
}
return cmdlineIncludes.build();
}
@Override
public Artifact getMainIncludeScannerSource() {
return getSourceFile().isFileType(CppFileTypes.CPP_MODULE_MAP)
? Iterables.getFirst(ccCompilationContext.getHeaderModuleSrcs(), null)
: getSourceFile();
}
@Override
public Collection<Artifact> getIncludeScannerSources() {
if (getSourceFile().isFileType(CppFileTypes.CPP_MODULE_MAP)) {
// If this is an action that compiles the header module itself, the source we build is the
// module map, and we need to include-scan all headers that are referenced in the module map.
return ccCompilationContext.getHeaderModuleSrcs();
}
ImmutableList.Builder<Artifact> builder = ImmutableList.builder();
builder.add(getSourceFile());
builder.addAll(additionalIncludeScanningRoots);
return builder.build();
}
/**
* Returns the list of "-D" arguments that should be used by this gcc
* invocation. Only used for testing.
*/
@VisibleForTesting
public ImmutableCollection<String> getDefines() {
return ccCompilationContext.getDefines().toList();
}
@Override
@VisibleForTesting
public ImmutableMap<String, String> getIncompleteEnvironmentForTesting()
throws ActionExecutionException {
try {
return getEnvironment(ImmutableMap.of());
} catch (CommandLineExpansionException e) {
throw new ActionExecutionException(
"failed to generate compile environment variables for rule '"
+ getOwner().getLabel()
+ ": "
+ e.getMessage(),
this,
/* catastrophe= */ false);
}
}
public ImmutableMap<String, String> getEnvironment(Map<String, String> clientEnv)
throws CommandLineExpansionException {
Map<String, String> environment = new LinkedHashMap<>(env.size());
env.resolve(environment, clientEnv);
if (!getExecutionInfo().containsKey(ExecutionRequirements.REQUIRES_DARWIN)) {
// Linux: this prevents gcc/clang from writing the unpredictable (and often irrelevant) value
// of getcwd() into the debug info. Not applicable to Darwin or Windows, which have no /proc.
environment.put("PWD", "/proc/self/cwd");
}
environment.putAll(compileCommandLine.getEnvironment());
return ImmutableMap.copyOf(environment);
}
@Override
public List<String> getArguments() throws CommandLineExpansionException {
return compileCommandLine.getArguments(paramFilePath, overwrittenVariables);
}
@Override
public Sequence<CommandLineArgsApi> getStarlarkArgs() throws EvalException {
ImmutableSet<Artifact> directoryInputs =
getInputs().toList().stream()
.filter(artifact -> artifact.isDirectory())
.collect(ImmutableSet.toImmutableSet());
CommandLine commandLine = compileCommandLine.getFilteredFeatureConfigurationCommandLine(this);
CommandLineAndParamFileInfo commandLineAndParamFileInfo =
new CommandLineAndParamFileInfo(commandLine, /* paramFileInfo= */ null);
Args args = Args.forRegisteredAction(commandLineAndParamFileInfo, directoryInputs);
return StarlarkList.immutableCopyOf(ImmutableList.of(args));
}
public ParamFileActionInput getParamFileActionInput() {
return paramFileActionInput;
}
@Override
public ExtraActionInfo.Builder getExtraActionInfo(ActionKeyContext actionKeyContext)
throws CommandLineExpansionException {
CppCompileInfo.Builder info = CppCompileInfo.newBuilder();
info.setTool(compileCommandLine.getToolPath());
// For actual extra actions, the shadowed action is fully executed and overwrittenVariables get
// computed. However, this function is also used for print_action and there, the action is
// retrieved from the cache, the modules are reconstructed via updateInputs and
// overwrittenVariables don't get computed.
List<String> options =
compileCommandLine.getCompilerOptions(
overwrittenVariables != null
? overwrittenVariables
: getOverwrittenVariables(getInputs()));
for (String option : options) {
info.addCompilerOption(option);
}
info.setOutputFile(outputFile.getExecPathString());
info.setSourceFile(getSourceFile().getExecPathString());
if (inputsDiscovered()) {
info.addAllSourcesAndHeaders(Artifact.toExecPaths(getInputs().toList()));
} else {
info.addSourcesAndHeaders(getSourceFile().getExecPathString());
info.addAllSourcesAndHeaders(
Artifact.toExecPaths(ccCompilationContext.getDeclaredIncludeSrcs().toList()));
}
// TODO(ulfjack): Extra actions currently ignore the client environment.
for (Map.Entry<String, String> envVariable :
getEnvironment(/* clientEnv= */ ImmutableMap.of()).entrySet()) {
info.addVariable(
EnvironmentVariable.newBuilder()
.setName(envVariable.getKey())
.setValue(envVariable.getValue())
.build());
}
try {
return super.getExtraActionInfo(actionKeyContext)
.setExtension(CppCompileInfo.cppCompileInfo, info.build());
} catch (CommandLineExpansionException e) {
throw new AssertionError("CppCompileAction command line expansion cannot fail.");
}
}
/** Returns the compiler options. */
@VisibleForTesting
public List<String> getCompilerOptions() throws CommandLineExpansionException {
return compileCommandLine.getCompilerOptions(/* overwrittenVariables= */ null);
}
@Override
public ImmutableMap<String, String> getExecutionInfo() {
return executionInfo;
}
/**
* Enforce that the includes actually visited during the compile were properly declared in the
* rules.
*
* <p>The technique is to walk through all of the reported includes that gcc emits into the .d
* file, and verify that they came from acceptable relative include directories. This is done in
* two steps:
*
* <p>First, each included file is stripped of any include path prefix from {@code
* quoteIncludeDirs} to produce an effective relative include dir+name.
*
* <p>Second, the remaining directory is looked up in {@code declaredIncludeDirs}, a list of
* acceptable dirs. This list contains a set of dir fragments that have been calculated by the
* configured target to be allowable for inclusion by this source. If no match is found, an error
* is reported and an exception is thrown.
*
* @throws ActionExecutionException iff there was an undeclared dependency
*/
@VisibleForTesting
public void validateInclusions(
ActionExecutionContext actionExecutionContext, NestedSet<Artifact> inputsForValidation)
throws ActionExecutionException {
IncludeProblems errors = new IncludeProblems();
Set<Artifact> allowedIncludes = new HashSet<>();
for (Artifact input :
Iterables.concat(
mandatoryInputs.toList(),
ccCompilationContext.getDeclaredIncludeSrcs().toList(),
additionalPrunableHeaders.toList())) {
if (input.isMiddlemanArtifact() || input.isTreeArtifact()) {
actionExecutionContext.getArtifactExpander().expand(input, allowedIncludes);
}
allowedIncludes.add(input);
}
Iterable<PathFragment> ignoreDirs =
cppConfiguration.isStrictSystemIncludes()
? getBuiltInIncludeDirectories()
: getValidationIgnoredDirs();
// Copy the nested sets to hash sets for fast contains checking, but do so lazily.
// Avoid immutable sets here to limit memory churn.
Set<PathFragment> declaredIncludeDirs = null;
for (Artifact input : inputsForValidation.toList()) {
// Only declared modules are added to an action and so they are always valid.
if (input.isFileType(CppFileTypes.CPP_MODULE)) {
continue;
}
// TODO(b/145253507): Exclude objc module maps from check, due to bad interaction with
// local_objc_modules feature.
if (input.isFileType(CppFileTypes.OBJC_MODULE_MAP)) {
continue;
}
if (allowedIncludes.contains(input)) {
continue;
}
// Ignore headers from built-in include directories.
if (FileSystemUtils.startsWithAny(input.getExecPath(), ignoreDirs)) {
continue;
}
if (declaredIncludeDirs == null) {
declaredIncludeDirs =
Sets.newHashSet(ccCompilationContext.getDeclaredIncludeDirs().toList());
}
if (!isDeclaredIn(cppConfiguration, actionExecutionContext, input, declaredIncludeDirs)) {
errors.add(input.getExecPath().toString());
}
}
if (VALIDATION_DEBUG_WARN) {
synchronized (System.err) {
if (errors.hasProblems()) {
if (errors.hasProblems()) {
System.err.println("ERROR: Include(s) were not in declared srcs:");
} else {
System.err.println("INFO: Include(s) were OK for '" + getSourceFile()
+ "', declared srcs:");
}
for (Artifact a : ccCompilationContext.getDeclaredIncludeSrcs().toList()) {
System.err.println(" '" + a.toDetailString() + "'");
}
System.err.println(" or under declared dirs:");
for (PathFragment f :
Sets.newTreeSet(ccCompilationContext.getDeclaredIncludeDirs().toList())) {
System.err.println(" '" + f + "'");
}
System.err.println(" with prefixes:");
for (PathFragment dirpath : ccCompilationContext.getQuoteIncludeDirs()) {
System.err.println(" '" + dirpath + "'");
}
}
}
}
errors.assertProblemFree(this, getSourceFile());
}
Iterable<PathFragment> getValidationIgnoredDirs() {
List<PathFragment> cxxSystemIncludeDirs = getBuiltInIncludeDirectories();
return Iterables.concat(cxxSystemIncludeDirs, ccCompilationContext.getSystemIncludeDirs());
}
@VisibleForTesting
void verifyActionIncludePaths(
List<PathFragment> systemIncludeDirs, boolean siblingRepositoryLayout)
throws ActionExecutionException {
ImmutableSet<PathFragment> ignoredDirs = ImmutableSet.copyOf(getValidationIgnoredDirs());
// We currently do not check the output of:
// - getBuiltinIncludeDirs(): while in practice this doesn't happen, bazel can be configured
// to use an absolute system root, in which case the builtin include dirs might be absolute.
Iterable<PathFragment> includePathsToVerify =
Iterables.concat(getIncludeDirs(), getQuoteIncludeDirs(), systemIncludeDirs);
for (PathFragment includePath : includePathsToVerify) {
// includePathsToVerify contains all paths that are added as -isystem directive on the command
// line, most of which are added for include directives in the CcCompilationContext and are
// thus also in ignoredDirs. The hash lookup prevents this from becoming O(N^2) for these.
if (ignoredDirs.contains(includePath)
|| FileSystemUtils.startsWithAny(includePath, ignoredDirs)) {
continue;
}
// Two conditions:
// 1. Paths cannot be absolute (e.g. multiple uplevels to /etc/passwd)
// 2. For relative paths, one starting ../ is okay for getting to a sibling repository.
PathFragment prefix =
siblingRepositoryLayout
? LabelConstants.EXPERIMENTAL_EXTERNAL_PATH_PREFIX
: LabelConstants.EXTERNAL_PATH_PREFIX;
if (includePath.startsWith(prefix)) {
includePath = includePath.relativeTo(prefix);
}
if (includePath.isAbsolute() || includePath.containsUplevelReferences()) {
throw new ActionExecutionException(
String.format(
"The include path '%s' references a path outside of the execution root.",
includePath),
this,
false);
}
}
}
/**
* Returns true if an included artifact is declared in a set of allowed include directories. The
* simple case is that the artifact's parent directory is contained in the set, or is empty.
*
* <p>This check also supports a wildcard suffix of '**' for the cases where the calculations are
* inexact.
*
* <p>It also handles unseen non-nested-package subdirs by walking up the path looking for
* matches.
*/
private static boolean isDeclaredIn(
CppConfiguration cppConfiguration,
ActionExecutionContext actionExecutionContext,
Artifact input,
Set<PathFragment> declaredIncludeDirs) {
// If it's a derived artifact, then it MUST be listed in "srcs" as checked above.
// We define derived here as being not source and not under the include link tree.
if (!input.isSourceArtifact()
&& !input.getRoot().getExecPath().getBaseName().equals("include")) {
return false;
}
// Need to do dir/package matching: first try a quick exact lookup.
PathFragment includeDir = input.getRootRelativePath().getParentDirectory();
if (!cppConfiguration.validateTopLevelHeaderInclusions() && includeDir.isEmpty()) {
return true; // Legacy behavior nobody understands anymore.
}
if (declaredIncludeDirs.contains(includeDir)) {
return true; // OK: quick exact match.
}
// Not found in the quick lookup: try the wildcards.
for (PathFragment declared : declaredIncludeDirs) {
if (declared.getBaseName().equals("**")) {
if (includeDir.startsWith(declared.getParentDirectory())) {
return true; // OK: under a wildcard dir.
}
}
}
// Still not found: see if it is in a subdir of a declared package.
Root root = actionExecutionContext.getRoot(input);
Path dir = actionExecutionContext.getInputPath(input).getParentDirectory();
if (dir.equals(root.asPath())) {
return false; // Bad: at the top, give up.
}
// As we walk up along parent paths, we'll need to check whether Bazel build files exist, which
// would mean that the file is in a sub-package and not a subdir of a declared include
// directory. Do so lazily to avoid stats when this file doesn't lie beneath any declared
// include directory.
List<Path> packagesToCheckForBuildFiles = new ArrayList<>();
while (true) {
packagesToCheckForBuildFiles.add(dir);
dir = dir.getParentDirectory();
if (dir.equals(root.asPath())) {
return false; // Bad: at the top, give up.
}
if (declaredIncludeDirs.contains(root.relativize(dir))) {
for (Path dirOrPackage : packagesToCheckForBuildFiles) {
if (dirOrPackage.getRelative(BUILD_PATH_FRAGMENT).exists()) {
return false; // Bad: this is a sub-package, not a subdir of a declared package.
}
}
return true; // OK: found under a declared dir.
}
}
}
/**
* Recalculates this action's live input collection, including sources, middlemen.
*
* <p>Can only be called if {@link #discoversInputs}, and must be called after execution in that
* case.
*/
@VisibleForTesting // productionVisibility = Visibility.PRIVATE
@ThreadCompatible
final void updateActionInputs(NestedSet<Artifact> discoveredInputs) {
Preconditions.checkState(
discoversInputs(), "Can't call if not discovering inputs: %s %s", discoveredInputs, this);
try (SilentCloseable c = Profiler.instance().profile(ProfilerTask.ACTION_UPDATE, describe())) {
NestedSetBuilder<Artifact> inputsBuilder =
NestedSetBuilder.<Artifact>stableOrder()
.addTransitive(mandatoryInputs)
.addTransitive(inputsForInvalidation);
if (discoveredInputs != null) {
inputsBuilder.addTransitive(discoveredInputs);
}
super.updateInputs(inputsBuilder.build());
}
}
/** Sets module file flags based on the action's inputs. */
protected void setModuleFileFlags() {
if (useHeaderModules) {
// If modules pruning is used, modules will be supplied via topLevelModules, otherwise they
// are regular inputs.
if (shouldPruneModules) {
Preconditions.checkNotNull(this.topLevelModules);
overwrittenVariables = getOverwrittenVariables(topLevelModules);
} else {
overwrittenVariables = getOverwrittenVariables(getInputs());
}
}
}
/**
* Extracts all module (.pcm) files from potentialModules and returns a Variables object where
* their exec paths are added to the value "module_files".
*/
private static CcToolchainVariables getOverwrittenVariables(
NestedSet<Artifact> potentialModules) {
ImmutableList.Builder<String> usedModulePaths = ImmutableList.builder();
for (Artifact input : potentialModules.toList()) {
if (input.isFileType(CppFileTypes.CPP_MODULE)) {
usedModulePaths.add(input.getExecPathString());
}
}
CcToolchainVariables.Builder variableBuilder = CcToolchainVariables.builder();
variableBuilder.addStringSequenceVariable("module_files", usedModulePaths.build());
return variableBuilder.build();
}
public CcToolchainVariables getOverwrittenVariables() {
return overwrittenVariables;
}
@Override
public NestedSet<Artifact> getAllowedDerivedInputs() {
return NestedSetBuilder.fromNestedSet(mandatoryInputs)
.addTransitive(additionalPrunableHeaders)
.addTransitive(inputsForInvalidation)
.addTransitive(getDeclaredIncludeSrcs())
.addTransitive(ccCompilationContext.getTransitiveModules(usePic))
.add(getSourceFile())
.build();
}
/**
* Called by {@link com.google.devtools.build.lib.actions.ActionCacheChecker}
*
* <p>If this is compiling a module, restores the value of {@link #discoveredModules}, which is
* used to create the {@link com.google.devtools.build.lib.skyframe.ActionExecutionValue} after an
* action cache hit.
*/
@Override
public synchronized void updateInputs(NestedSet<Artifact> inputs) {
super.updateInputs(inputs);
if (outputFile.isFileType(CppFileTypes.CPP_MODULE)) {
discoveredModules =
NestedSetBuilder.wrap(
Order.STABLE_ORDER,
Iterables.filter(
inputs.toList(), input -> input.isFileType(CppFileTypes.CPP_MODULE)));
}
}
@Override
protected String getRawProgressMessage() {
return "Compiling " + getSourceFile().prettyPrint();
}
/**
* Return the directories in which to look for headers (pertains to headers not specifically
* listed in {@code declaredIncludeSrcs}).
*/
public NestedSet<PathFragment> getDeclaredIncludeDirs() {
return ccCompilationContext.getDeclaredIncludeDirs();
}
/** Return explicitly listed header files. */
@Override
public NestedSet<Artifact> getDeclaredIncludeSrcs() {
return ccCompilationContext.getDeclaredIncludeSrcs();
}
/**
* Estimate resource consumption when this action is executed locally.
*/
public ResourceSet estimateResourceConsumptionLocal() {
return AbstractAction.DEFAULT_RESOURCE_SET;
}
@Override
public boolean isShareable() {
return shareable;
}
/** For actions that discover inputs, the key must include input names. */
@Override
public void computeKey(ActionKeyContext actionKeyContext, Fingerprint fp)
throws CommandLineExpansionException {
computeKey(
actionKeyContext,
fp,
actionClassId,
env,
compileCommandLine.getEnvironment(),
executionInfo,
getCommandLineKey(),
ccCompilationContext.getDeclaredIncludeSrcs(),
getMandatoryInputs(),
additionalPrunableHeaders,
ccCompilationContext.getDeclaredIncludeDirs(),
builtInIncludeDirectories,
inputsForInvalidation,
cppConfiguration.validateTopLevelHeaderInclusions());
}
// Separated into a helper method so that it can be called from CppCompileActionTemplate.
static void computeKey(
ActionKeyContext actionKeyContext,
Fingerprint fp,
UUID actionClassId,
ActionEnvironment env,
Map<String, String> environmentVariables,
Map<String, String> executionInfo,
byte[] commandLineKey,
NestedSet<Artifact> declaredIncludeSrcs,
NestedSet<Artifact> mandatoryInputs,
NestedSet<Artifact> prunableHeaders,
NestedSet<PathFragment> declaredIncludeDirs,
List<PathFragment> builtInIncludeDirectories,
NestedSet<Artifact> inputsForInvalidation,
boolean validateTopLevelHeaderInclusions) {
fp.addUUID(actionClassId);
env.addTo(fp);
fp.addStringMap(environmentVariables);
fp.addStringMap(executionInfo);
fp.addBytes(commandLineKey);
fp.addBoolean(validateTopLevelHeaderInclusions);
actionKeyContext.addNestedSetToFingerprint(fp, declaredIncludeSrcs);
fp.addInt(0); // mark the boundary between input types
actionKeyContext.addNestedSetToFingerprint(fp, mandatoryInputs);
fp.addInt(0);
actionKeyContext.addNestedSetToFingerprint(fp, prunableHeaders);
/*
* getArguments() above captures all changes which affect the compilation command and hence the
* contents of the object file. But we need to also make sure that we re-execute the action if
* any of the fields that affect whether {@link #validateInclusions} will report an error or
* warning have changed, otherwise we might miss some errors.
*/
actionKeyContext.addNestedSetToFingerprint(fp, declaredIncludeDirs);
fp.addPaths(builtInIncludeDirectories);
// This is needed for CppLinkstampCompile.
fp.addInt(0);
actionKeyContext.addNestedSetToFingerprint(fp, inputsForInvalidation);
}
private byte[] getCommandLineKey() throws CommandLineExpansionException {
if (commandLineKey == null) {
// For the argv part of the cache key, ignore all compiler flags that explicitly denote module
// file (.pcm) inputs. Depending on input discovery, some of the unused ones are removed from
// the command line. However, these actually don't have an influence on the compile itself and
// so ignoring them for the cache key calculation does not affect correctness. The compile
// itself is fully determined by the input source files and module maps.
// A better long-term solution would be to make the compiler to find them automatically and
// never hand in the .pcm files explicitly on the command line in the first place.
commandLineKey = computeCommandLineKey(getCompilerOptions());
}
return commandLineKey;
}
static byte[] computeCommandLineKey(List<String> compilerOptions) {
Fingerprint fp = new Fingerprint();
fp.addStrings(compilerOptions);
return fp.digestAndReset();
}
@Override
public ActionContinuationOrResult beginExecution(ActionExecutionContext actionExecutionContext)
throws ActionExecutionException, InterruptedException {
setModuleFileFlags();
if (featureConfiguration.isEnabled(CppRuleClasses.COMPIILER_PARAM_FILE)) {
try {
paramFileActionInput =
new ParamFileActionInput(
paramFilePath,
compileCommandLine.getCompilerOptions(overwrittenVariables),
// TODO(b/132888308): Support MSVC, which has its own method of escaping strings.
ParameterFileType.GCC_QUOTED,
StandardCharsets.ISO_8859_1);
} catch (CommandLineExpansionException e) {
throw new ActionExecutionException(
"failed to generate compile command for rule '"
+ getOwner().getLabel()
+ ": "
+ e.getMessage(),
this,
/* catastrophe= */ false);
}
}
if (!shouldScanDotdFiles()) {
updateActionInputs(additionalInputs);
}
ActionExecutionContext spawnContext;
ShowIncludesFilter showIncludesFilterForStdout;
ShowIncludesFilter showIncludesFilterForStderr;
if (featureConfiguration.isEnabled(CppRuleClasses.PARSE_SHOWINCLUDES)) {
showIncludesFilterForStdout = new ShowIncludesFilter(getSourceFile().getFilename());
showIncludesFilterForStderr = new ShowIncludesFilter(getSourceFile().getFilename());
FileOutErr originalOutErr = actionExecutionContext.getFileOutErr();
FileOutErr tempOutErr = originalOutErr.childOutErr();
spawnContext = actionExecutionContext.withFileOutErr(tempOutErr);
} else {
spawnContext = actionExecutionContext;
showIncludesFilterForStdout = null;
showIncludesFilterForStderr = null;
}
Spawn spawn;
try {
spawn = createSpawn(actionExecutionContext.getClientEnv());
} finally {
clearAdditionalInputs();
}
SpawnContinuation spawnContinuation =
actionExecutionContext.getContext(SpawnStrategy.class).beginExecution(spawn, spawnContext);
return new CppCompileActionContinuation(
actionExecutionContext,
spawnContext,
showIncludesFilterForStdout,
showIncludesFilterForStderr,
spawnContinuation);
}
protected byte[] getDotDContents(SpawnResult spawnResult) throws EnvironmentalExecException {
if (getDotdFile() != null) {
InputStream in = spawnResult.getInMemoryOutput(getDotdFile());
if (in != null) {
try {
return ByteStreams.toByteArray(in);
} catch (IOException e) {
throw new EnvironmentalExecException("Reading in-memory .d file failed", e);
}
}
}
return null;
}
protected Spawn createSpawn(Map<String, String> clientEnv) throws ActionExecutionException {
// Intentionally not adding {@link CppCompileAction#inputsForInvalidation}, those are not needed
// for execution.
NestedSetBuilder<ActionInput> inputsBuilder =
NestedSetBuilder.<ActionInput>stableOrder()
.addTransitive(getMandatoryInputs())
.addTransitive(getAdditionalInputs());
if (getParamFileActionInput() != null) {
inputsBuilder.add(getParamFileActionInput());
}
NestedSet<ActionInput> inputs = inputsBuilder.build();
ImmutableMap<String, String> executionInfo = getExecutionInfo();
if (getDotdFile() != null && useInMemoryDotdFiles()) {
/*
* CppCompileAction does dotd file scanning locally inside the Bazel process and thus
* requires the dotd file contents to be available locally. In remote execution, we
* generally don't want to stage all remote outputs on the local file system and thus
* we need to tell the remote strategy (if any) to at least make the .d file available
* in-memory. We can do that via
* {@link ExecutionRequirements.REMOTE_EXECUTION_INLINE_OUTPUTS}.
*/
executionInfo =
ImmutableMap.<String, String>builderWithExpectedSize(executionInfo.size() + 1)
.putAll(executionInfo)
.put(
ExecutionRequirements.REMOTE_EXECUTION_INLINE_OUTPUTS,
getDotdFile().getExecPathString())
.build();
}
try {
return new SimpleSpawn(
this,
ImmutableList.copyOf(getArguments()),
getEnvironment(clientEnv),
executionInfo,
inputs,
getOutputs(),
estimateResourceConsumptionLocal());
} catch (CommandLineExpansionException e) {
throw new ActionExecutionException(
"failed to generate compile command for rule '"
+ getOwner().getLabel()
+ ": "
+ e.getMessage(),
this,
/* catastrophe= */ false);
}
}
@VisibleForTesting
public NestedSet<Artifact> discoverInputsFromShowIncludesFilters(
Path execRoot,
ArtifactResolver artifactResolver,
ShowIncludesFilter showIncludesFilterForStdout,
ShowIncludesFilter showIncludesFilterForStderr,
boolean siblingRepositoryLayout)
throws ActionExecutionException {
if (!needsDotdInputPruning) {
return NestedSetBuilder.emptySet(Order.STABLE_ORDER);
}
ImmutableList.Builder<Path> dependencies = new ImmutableList.Builder<>();
dependencies.addAll(showIncludesFilterForStdout.getDependencies(execRoot));
dependencies.addAll(showIncludesFilterForStderr.getDependencies(execRoot));
HeaderDiscovery.Builder discoveryBuilder =
new HeaderDiscovery.Builder()
.setAction(this)
.setSourceFile(getSourceFile())
.setDependencies(dependencies.build())
.setPermittedSystemIncludePrefixes(getPermittedSystemIncludePrefixes(execRoot))
.setAllowedDerivedInputs(getAllowedDerivedInputs());
if (needsIncludeValidation) {
discoveryBuilder.shouldValidateInclusions();
}
return discoveryBuilder
.build()
.discoverInputsFromDependencies(execRoot, artifactResolver, siblingRepositoryLayout);
}
@VisibleForTesting
public NestedSet<Artifact> discoverInputsFromDotdFiles(
ActionExecutionContext actionExecutionContext,
Path execRoot,
ArtifactResolver artifactResolver,
byte[] dotDContents,
boolean siblingRepositoryLayout)
throws ActionExecutionException {
if (!needsDotdInputPruning || getDotdFile() == null) {
return NestedSetBuilder.emptySet(Order.STABLE_ORDER);
}
HeaderDiscovery.Builder discoveryBuilder =
new HeaderDiscovery.Builder()
.setAction(this)
.setSourceFile(getSourceFile())
.setDependencies(
processDepset(actionExecutionContext, execRoot, dotDContents).getDependencies())
.setPermittedSystemIncludePrefixes(getPermittedSystemIncludePrefixes(execRoot))
.setAllowedDerivedInputs(getAllowedDerivedInputs());
if (needsIncludeValidation) {
discoveryBuilder.shouldValidateInclusions();
}
return discoveryBuilder
.build()
.discoverInputsFromDependencies(execRoot, artifactResolver, siblingRepositoryLayout);
}
public DependencySet processDepset(
ActionExecutionContext actionExecutionContext, Path execRoot, byte[] dotDContents)
throws ActionExecutionException {
try {
DependencySet depSet = new DependencySet(execRoot);
if (dotDContents != null && cppConfiguration.getInmemoryDotdFiles()) {
return depSet.process(dotDContents);
}
return depSet.read(actionExecutionContext.getInputPath(getDotdFile()));
} catch (IOException e) {
// Some kind of IO or parse exception--wrap & rethrow it to stop the build.
throw new ActionExecutionException(
"error while parsing .d file: " + e.getMessage(), e, this, false);
}
}
public List<Path> getPermittedSystemIncludePrefixes(Path execRoot) {
List<Path> systemIncludePrefixes = new ArrayList<>();
for (PathFragment includePath : getBuiltInIncludeDirectories()) {
if (includePath.isAbsolute()) {
systemIncludePrefixes.add(execRoot.getFileSystem().getPath(includePath));
}
}
return systemIncludePrefixes;
}
/**
* Gcc only creates ".gcno" files if the compilation unit is non-empty. To ensure that the set of
* outputs for a CppCompileAction remains consistent and doesn't vary dynamically depending on the
* _contents_ of the input files, we create empty ".gcno" files if gcc didn't create them.
*/
private void ensureCoverageNotesFilesExist(ActionExecutionContext actionExecutionContext)
throws ActionExecutionException {
for (Artifact output : getOutputs()) {
if (output.isFileType(CppFileTypes.COVERAGE_NOTES)) { // ".gcno"
Path outputPath = actionExecutionContext.getInputPath(output);
if (outputPath.exists()) {
continue;
}
try {
FileSystemUtils.createEmptyFile(outputPath);
} catch (IOException e) {
throw new ActionExecutionException(
"Error creating file '" + outputPath + "': " + e.getMessage(), e, this, false);
}
}
}
}
/**
* When compiling with modules, the C++ compile action only has the {@code .pcm} files on its
* inputs, which is not enough for extra actions that parse header files. Thus, re-run include
* scanning and add headers to the inputs of the extra action, too.
*
* <p>This method returns null when a required SkyValue is missing and a Skyframe restart is
* required.
*/
@Nullable
@Override
public NestedSet<Artifact> getInputFilesForExtraAction(
ActionExecutionContext actionExecutionContext)
throws ActionExecutionException, InterruptedException {
try {
IncludeScanningHeaderData.Builder includeScanningHeaderData =
createIncludeScanningHeaderData(
actionExecutionContext.getEnvironmentForDiscoveringInputs(),
usePic,
useHeaderModules,
ccCompilationContext.getTransitiveHeaderInfos());
if (includeScanningHeaderData == null) {
return null;
}
NestedSet<Artifact> discoveredInputs =
findUsedHeaders(
actionExecutionContext,
includeScanningHeaderData
.setSystemIncludeDirs(getSystemIncludeDirs())
.setCmdlineIncludes(getCmdlineIncludes(getCompilerOptions()))
.build());
return discoveredInputs;
} catch (CommandLineExpansionException e) {
throw new ActionExecutionException(
"failed to generate compile environment variables for rule '"
+ getOwner().getLabel()
+ ": "
+ e.getMessage(),
this,
/* catastrophe= */ false);
}
}
static String actionNameToMnemonic(String actionName) {
switch (actionName) {
case CppActionNames.OBJC_COMPILE:
case CppActionNames.OBJCPP_COMPILE:
return "ObjcCompile";
case CppActionNames.LINKSTAMP_COMPILE:
// When compiling shared native deps, e.g. when two java_binary rules have the same set of
// native dependencies, the CppCompileAction for link stamp data is shared also. This means
// that out of two CppCompileAction instances, only one is actually executed, which means
// that if extra actions are attached to both, one of the extra actions will find a
// CppCompileAction for which discoverInputs() hasn't been called and thus trigger an
// assertion. As a band-aid, change the mnemonic of said actions so that one can attach
// extra actions to regular CppCompileActions without tickling this bug.
return "CppLinkstampCompile";
default:
return "CppCompile";
}
}
@Override
public String getMnemonic() {
return actionNameToMnemonic(actionName);
}
@Override
public String describeKey() {
StringBuilder message = new StringBuilder();
message.append(getProgressMessage());
message.append('\n');
// Outputting one argument per line makes it easier to diff the results.
// The first element in getArguments() is actually the command to execute.
String legend = " Command: ";
try {
for (String argument : ShellEscaper.escapeAll(getArguments())) {
message.append(legend);
message.append(argument);
message.append('\n');
legend = " Argument: ";
}
} catch (CommandLineExpansionException e) {
message.append(" Could not expand command line: ");
message.append(e);
message.append('\n');
}
for (PathFragment path : ccCompilationContext.getDeclaredIncludeDirs().toList()) {
message.append(" Declared include directory: ");
message.append(ShellEscaper.escapeString(path.getPathString()));
message.append('\n');
}
for (Artifact src : getDeclaredIncludeSrcs().toList()) {
message.append(" Declared include source: ");
message.append(ShellEscaper.escapeString(src.getExecPathString()));
message.append('\n');
}
return message.toString();
}
@Override
public boolean hasLooseHeaders() {
return hasLooseHeaders(ccCompilationContext, featureConfiguration);
}
// Separated into a helper method so that it can be called from CppCompileActionTemplate.
static boolean hasLooseHeaders(
CcCompilationContext ccCompilationContext, FeatureConfiguration featureConfiguration) {
// Layering check is stricter than hdrs_check = strict, so when it's enabled, there can't be
// loose headers.
return ccCompilationContext
.getHeadersCheckingMode()
.equals(CppConfiguration.HeadersCheckingMode.LOOSE)
&& !(featureConfiguration.isEnabled(CppRuleClasses.LAYERING_CHECK)
&& featureConfiguration.isEnabled(CppRuleClasses.PARSE_HEADERS));
}
public CompileCommandLine getCompileCommandLine() {
return compileCommandLine;
}
/**
* For the given {@code usedModules}, looks up modules discovered by their generating actions.
*
* <p>The returned value only contains a map from elements of {@code usedModules} to the {@link
* #discoveredModules} required to use them. If dependent actions have not been executed yet (and
* thus {@link #discoveredModules} aren't known yet, returns null.
*/
@Nullable
private static Map<Artifact, NestedSet<? extends Artifact>> computeTransitivelyUsedModules(
SkyFunction.Environment env, Collection<Artifact.DerivedArtifact> usedModules)
throws InterruptedException {
Map<SkyKey, SkyValue> actionExecutionValues =
env.getValues(
Iterables.transform(usedModules, Artifact.DerivedArtifact::getGeneratingActionKey));
if (env.valuesMissing()) {
return null;
}
ImmutableMap.Builder<Artifact, NestedSet<? extends Artifact>> transitivelyUsedModules =
ImmutableMap.builderWithExpectedSize(usedModules.size());
for (Artifact.DerivedArtifact module : usedModules) {
Preconditions.checkState(
module.isFileType(CppFileTypes.CPP_MODULE), "Non-module? %s", module);
ActionExecutionValue value =
Preconditions.checkNotNull(
(ActionExecutionValue) actionExecutionValues.get(module.getGeneratingActionKey()),
module);
transitivelyUsedModules.put(module, value.getDiscoveredModules());
}
return transitivelyUsedModules.build();
}
private final class CppCompileActionContinuation extends ActionContinuationOrResult {
private final ActionExecutionContext actionExecutionContext;
private final ActionExecutionContext spawnExecutionContext;
private final ShowIncludesFilter showIncludesFilterForStdout;
private final ShowIncludesFilter showIncludesFilterForStderr;
private final SpawnContinuation spawnContinuation;
public CppCompileActionContinuation(
ActionExecutionContext actionExecutionContext,
ActionExecutionContext spawnExecutionContext,
ShowIncludesFilter showIncludesFilterForStdout,
ShowIncludesFilter showIncludesFilterForStderr,
SpawnContinuation spawnContinuation) {
this.actionExecutionContext = actionExecutionContext;
this.spawnExecutionContext = spawnExecutionContext;
this.showIncludesFilterForStdout = showIncludesFilterForStdout;
this.showIncludesFilterForStderr = showIncludesFilterForStderr;
this.spawnContinuation = spawnContinuation;
}
@Override
public ListenableFuture<?> getFuture() {
return spawnContinuation.getFuture();
}
@Override
public ActionContinuationOrResult execute()
throws ActionExecutionException, InterruptedException {
List<SpawnResult> spawnResults;
byte[] dotDContents;
try {
SpawnContinuation nextContinuation = spawnContinuation.execute();
if (!nextContinuation.isDone()) {
return new CppCompileActionContinuation(
actionExecutionContext,
spawnExecutionContext,
showIncludesFilterForStdout,
showIncludesFilterForStderr,
nextContinuation);
}
spawnResults = nextContinuation.get();
// SpawnActionContext guarantees that the first list entry exists and corresponds to the
// executed spawn.
dotDContents = getDotDContents(spawnResults.get(0));
} catch (ExecException e) {
copyTempOutErrToActionOutErr();
throw e.toActionExecutionException(
"C++ compilation of rule '" + getOwner().getLabel() + "'",
actionExecutionContext.getVerboseFailures(),
CppCompileAction.this);
} catch (InterruptedException e) {
copyTempOutErrToActionOutErr();
throw e;
}
copyTempOutErrToActionOutErr();
ensureCoverageNotesFilesExist(actionExecutionContext);
if (!shouldScanDotdFiles()) {
return ActionContinuationOrResult.of(ActionResult.create(spawnResults));
}
// This is the .d file scanning part.
CppIncludeExtractionContext scanningContext =
actionExecutionContext.getContext(CppIncludeExtractionContext.class);
Path execRoot = actionExecutionContext.getExecRoot();
boolean siblingRepositoryLayout =
actionExecutionContext
.getOptions()
.getOptions(StarlarkSemanticsOptions.class)
.experimentalSiblingRepositoryLayout;
NestedSet<Artifact> discoveredInputs;
if (featureConfiguration.isEnabled(CppRuleClasses.PARSE_SHOWINCLUDES)) {
discoveredInputs =
discoverInputsFromShowIncludesFilters(
execRoot,
scanningContext.getArtifactResolver(),
showIncludesFilterForStdout,
showIncludesFilterForStderr,
siblingRepositoryLayout);
} else {
discoveredInputs =
discoverInputsFromDotdFiles(
actionExecutionContext,
execRoot,
scanningContext.getArtifactResolver(),
dotDContents,
siblingRepositoryLayout);
}
dotDContents = null; // Garbage collect in-memory .d contents.
if (discoversInputs()) {
// Post-execute "include scanning", which modifies the action inputs to match what the
// compile action actually used by incorporating the results of .d file parsing.
updateActionInputs(discoveredInputs);
} else {
Preconditions.checkState(
discoveredInputs.isEmpty(),
"Discovered inputs without discovering inputs? %s %s",
discoveredInputs,
this);
}
// hdrs_check: This cannot be switched off for C++ build actions,
// because doing so would allow for incorrect builds.
// HeadersCheckingMode.NONE should only be used for ObjC build actions.
if (needsIncludeValidation) {
validateInclusions(actionExecutionContext, discoveredInputs);
}
return ActionContinuationOrResult.of(ActionResult.create(spawnResults));
}
private void copyTempOutErrToActionOutErr() throws ActionExecutionException {
// If parse_showincludes feature is enabled, instead of parsing dotD file we parse the
// output of cl.exe caused by /showIncludes option.
if (featureConfiguration.isEnabled(CppRuleClasses.PARSE_SHOWINCLUDES)) {
try {
FileOutErr tempOutErr = spawnExecutionContext.getFileOutErr();
FileOutErr outErr = actionExecutionContext.getFileOutErr();
tempOutErr.close();
if (tempOutErr.hasRecordedStdout()) {
try (InputStream in = tempOutErr.getOutputPath().getInputStream()) {
ByteStreams.copy(
in,
showIncludesFilterForStdout.getFilteredOutputStream(outErr.getOutputStream()));
}
}
if (tempOutErr.hasRecordedStderr()) {
try (InputStream in = tempOutErr.getErrorPath().getInputStream()) {
ByteStreams.copy(
in, showIncludesFilterForStderr.getFilteredOutputStream(outErr.getErrorStream()));
}
}
} catch (IOException e) {
throw new EnvironmentalExecException(e)
.toActionExecutionException(
getRawProgressMessage(),
actionExecutionContext.getVerboseFailures(),
CppCompileAction.this);
}
}
}
}
}