)]}'
{
  "commit": "47bf59e645ed95748f19f6367c58ed35ba150100",
  "tree": "df8796e7e420235ee9685d9ee79d0259e6867ab2",
  "parents": [
    "4c6f90ad85b50a5085d25d08fb6d14b873e857ac"
  ],
  "author": {
    "name": "adonovan",
    "email": "adonovan@google.com",
    "time": "Mon Jan 13 14:46:59 2020 -0800"
  },
  "committer": {
    "name": "Copybara-Service",
    "email": "copybara-worker@google.com",
    "time": "Mon Jan 13 14:47:45 2020 -0800"
  },
  "message": "bazel syntax: remove Location parameters\n\nRemove Location parameter from SkylarkIndexable.getIndex\n(and thread parameter from SkylarkQueryable).\nAlso, make SkylarkIndexable and SkylarkQueryable\nconsistently take a StarlarkSemantics.\n\nEval: don\u0027t pass Locations down into evaluation;\nobtain them only after an error, on the way up.\n(This is a prerequisite for compilation, and for\nfiner-grained syntax locations. This CL addresses only\nthe easy cases.)\n\nAlso:\n- Dict.get2: avoid duplicate hash lookup in success case.\n- EvalUtils.index: pass mutability and semantics, not thread\n- remove unnecessary parameters to binary operators.\n- improvements to error messages\nPiperOrigin-RevId: 289523719\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "c226c3a3f04939b7d0408c68cc262b70df161237",
      "old_mode": 33188,
      "old_path": "src/main/java/com/google/devtools/build/lib/analysis/OutputGroupInfo.java",
      "new_id": "a8c31f7de0e19999603a0973159d161193c99dc0",
      "new_mode": 33188,
      "new_path": "src/main/java/com/google/devtools/build/lib/analysis/OutputGroupInfo.java"
    },
    {
      "type": "modify",
      "old_id": "cf78c07f71aff3ea1cfc1358d44a0adbca67f679",
      "old_mode": 33188,
      "old_path": "src/main/java/com/google/devtools/build/lib/analysis/ResolvedToolchainContext.java",
      "new_id": "bf397b525ba2568bc975e6b1054f62db0b0062e5",
      "new_mode": 33188,
      "new_path": "src/main/java/com/google/devtools/build/lib/analysis/ResolvedToolchainContext.java"
    },
    {
      "type": "modify",
      "old_id": "d92dd03af20967489b512c0cfd8549e199c85a4d",
      "old_mode": 33188,
      "old_path": "src/main/java/com/google/devtools/build/lib/analysis/configuredtargets/AbstractConfiguredTarget.java",
      "new_id": "c1f9177603689a0dc3353e656e9f5593c8a40550",
      "new_mode": 33188,
      "new_path": "src/main/java/com/google/devtools/build/lib/analysis/configuredtargets/AbstractConfiguredTarget.java"
    },
    {
      "type": "modify",
      "old_id": "4e40cd56fd8ed11c93f7d747f8da9cd8a6632022",
      "old_mode": 33188,
      "old_path": "src/main/java/com/google/devtools/build/lib/analysis/platform/ConstraintCollection.java",
      "new_id": "bcc1c7523b4116022d41d64cb5ce9c5475accd1f",
      "new_mode": 33188,
      "new_path": "src/main/java/com/google/devtools/build/lib/analysis/platform/ConstraintCollection.java"
    },
    {
      "type": "modify",
      "old_id": "43996de9a30e5585d76a2dfb9e1c6da8cfa33eac",
      "old_mode": 33188,
      "old_path": "src/main/java/com/google/devtools/build/lib/rules/AliasConfiguredTarget.java",
      "new_id": "bfced9ad5a157c97fd85e20a3aca1999b295098d",
      "new_mode": 33188,
      "new_path": "src/main/java/com/google/devtools/build/lib/rules/AliasConfiguredTarget.java"
    },
    {
      "type": "modify",
      "old_id": "b8db285f39d5c76adf6ae9e5506a5952fda62499",
      "old_mode": 33188,
      "old_path": "src/main/java/com/google/devtools/build/lib/syntax/Dict.java",
      "new_id": "42e341e59fe608d047804d963af717a49b321aa0",
      "new_mode": 33188,
      "new_path": "src/main/java/com/google/devtools/build/lib/syntax/Dict.java"
    },
    {
      "type": "modify",
      "old_id": "8b8900d46fb076f3f79440540686b6d4e8103b02",
      "old_mode": 33188,
      "old_path": "src/main/java/com/google/devtools/build/lib/syntax/Eval.java",
      "new_id": "fbe4ebb0da87582c1c3f0e6c0436f912595d784c",
      "new_mode": 33188,
      "new_path": "src/main/java/com/google/devtools/build/lib/syntax/Eval.java"
    },
    {
      "type": "modify",
      "old_id": "825110ed98dbe67db98e1990af0df355f85f3c9c",
      "old_mode": 33188,
      "old_path": "src/main/java/com/google/devtools/build/lib/syntax/EvalUtils.java",
      "new_id": "4137cb6c22c982170c97e81b6af98779ef7f3d90",
      "new_mode": 33188,
      "new_path": "src/main/java/com/google/devtools/build/lib/syntax/EvalUtils.java"
    },
    {
      "type": "modify",
      "old_id": "1b08d7a3272b3dbf14d5bd87b5b8cb72d30fd11d",
      "old_mode": 33188,
      "old_path": "src/main/java/com/google/devtools/build/lib/syntax/Sequence.java",
      "new_id": "d743ca0df2eef78c7d3ed6a9337c68a9b625cded",
      "new_mode": 33188,
      "new_path": "src/main/java/com/google/devtools/build/lib/syntax/Sequence.java"
    },
    {
      "type": "modify",
      "old_id": "8f6753494947bf2c11ccf876fad25d33b6576ec3",
      "old_mode": 33188,
      "old_path": "src/main/java/com/google/devtools/build/lib/syntax/SkylarkIndexable.java",
      "new_id": "c27ad7e6e9ee88d685898d47997b187c38a7c349",
      "new_mode": 33188,
      "new_path": "src/main/java/com/google/devtools/build/lib/syntax/SkylarkIndexable.java"
    },
    {
      "type": "modify",
      "old_id": "66d0bba686bc7344f1a18c40fa39a0e22ed5333f",
      "old_mode": 33188,
      "old_path": "src/main/java/com/google/devtools/build/lib/syntax/SkylarkQueryable.java",
      "new_id": "638a3f0409396e3b7c90712ab0cfec3d1f780f47",
      "new_mode": 33188,
      "new_path": "src/main/java/com/google/devtools/build/lib/syntax/SkylarkQueryable.java"
    },
    {
      "type": "modify",
      "old_id": "73d33665da5096b2835bf189ffb8c5b0892f7d63",
      "old_mode": 33188,
      "old_path": "src/main/java/com/google/devtools/build/lib/syntax/StarlarkList.java",
      "new_id": "83428d56474995a41e5c74a271ab92b3ac0a78af",
      "new_mode": 33188,
      "new_path": "src/main/java/com/google/devtools/build/lib/syntax/StarlarkList.java"
    },
    {
      "type": "modify",
      "old_id": "933956aad65a9bf28fbdabcd2f2111d585600d3e",
      "old_mode": 33188,
      "old_path": "src/test/java/com/google/devtools/build/lib/skyframe/SingleToolchainResolutionFunctionTest.java",
      "new_id": "ee39c29dae8cd5eb7f621449052936741a7bd2eb",
      "new_mode": 33188,
      "new_path": "src/test/java/com/google/devtools/build/lib/skyframe/SingleToolchainResolutionFunctionTest.java"
    },
    {
      "type": "modify",
      "old_id": "34d8df9389e5a05a3944117efd9ae85b3430972e",
      "old_mode": 33188,
      "old_path": "src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleImplementationFunctionsTest.java",
      "new_id": "3033f7ee33e955e9f49e4e0ed8b35e14ad58e180",
      "new_mode": 33188,
      "new_path": "src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleImplementationFunctionsTest.java"
    },
    {
      "type": "modify",
      "old_id": "a5233db3ef494752dc8cbcd12559f66ea363a795",
      "old_mode": 33188,
      "old_path": "src/test/java/com/google/devtools/build/lib/syntax/EvaluationTest.java",
      "new_id": "236aea04e927d0a4566738734e01c1b20438b535",
      "new_mode": 33188,
      "new_path": "src/test/java/com/google/devtools/build/lib/syntax/EvaluationTest.java"
    },
    {
      "type": "modify",
      "old_id": "176f82ed83e006b0cd56dc173a0b1e8931fa3be4",
      "old_mode": 33188,
      "old_path": "src/test/java/com/google/devtools/build/lib/syntax/MethodLibraryTest.java",
      "new_id": "39b226e5939b2b1958c4dc9416344e2e9b0dec3a",
      "new_mode": 33188,
      "new_path": "src/test/java/com/google/devtools/build/lib/syntax/MethodLibraryTest.java"
    },
    {
      "type": "modify",
      "old_id": "10f840815395f8f53728370b90e6a3461301c4d2",
      "old_mode": 33188,
      "old_path": "src/test/java/com/google/devtools/build/lib/syntax/SkylarkEvaluationTest.java",
      "new_id": "6beb2fd2613a022a9b0a9a0176081c8561b7aeca",
      "new_mode": 33188,
      "new_path": "src/test/java/com/google/devtools/build/lib/syntax/SkylarkEvaluationTest.java"
    },
    {
      "type": "modify",
      "old_id": "db95ec28cf9312709321fdea681a44f18ccfe69e",
      "old_mode": 33188,
      "old_path": "src/test/java/com/google/devtools/build/lib/syntax/StarlarkFileTest.java",
      "new_id": "4c2a9914e674e0483b44755cf2304130f978b016",
      "new_mode": 33188,
      "new_path": "src/test/java/com/google/devtools/build/lib/syntax/StarlarkFileTest.java"
    },
    {
      "type": "modify",
      "old_id": "f2f73f07fa0e7dde01539211698eb7f35b856a9c",
      "old_mode": 33188,
      "old_path": "src/test/starlark/testdata/dict.sky",
      "new_id": "8195d9771f511f3a99f6880fd326747741b90e6e",
      "new_mode": 33188,
      "new_path": "src/test/starlark/testdata/dict.sky"
    },
    {
      "type": "modify",
      "old_id": "d4710cffc5b2defa7857c172b9aef0f01ba79747",
      "old_mode": 33188,
      "old_path": "src/test/starlark/testdata/int.sky",
      "new_id": "ca3cc675bff4eda6336c60d7efc1b62f1fbb6a21",
      "new_mode": 33188,
      "new_path": "src/test/starlark/testdata/int.sky"
    }
  ]
}