tree 7d98f1660b7453c8731fd5af742f38b854f0045a
parent 376cd472bbf7d81c7feb79563e7894cc3d74151a
author Brentley Jones <github@brentleyjones.com> 1647877688 -0500
committer GitHub <noreply@github.com> 1647877688 +0100
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsBcBAABCAAQBQJiOJ44CRBK7hj4Ov3rIwAAzpkIAHaAffZSBK2ZmMFTTfJXIFXi
 /821LdqU3ZVAX9vp79FLKm3VUWM2ame2CHFYu87qbb4+NrJWT3tHfixln/SG75ht
 f98sSqfn47sgCJT1DQAolPkhzFn+FPbr8d2jhx7zz95gy7TlykFhS9B/j+eeiMNc
 oSSqbo4x0cJR2Qrj+N5e94W8ZvX+BwcCrNBZqoUXZfFqPq3qOb2cJSOtrVYvT7i9
 Q2iqjqxiz+l1PIMFL1F2/3vYEe3ifgPoCbhXi30u0d+x6DMKVITq1oKMLGgOPqGG
 seVw2XA3TZ/YKl3EKhgm5DJqlH+j8v7rBGBw9v1h2RgaKBt/FexlFqjZF6rm8t8=
 =AuV4
 -----END PGP SIGNATURE-----
 

osx_cc_wrapper: Only expand existing response files (#15090)

Closes #13044
Applies the changes suggested in https://github.com/bazelbuild/bazel/pull/13044#issuecomment-783539568

Not all arguments starting with `@` represent response files, e.g. `-install_name @rpath/...` or `-Xlinker -rpath -Xlinker @loader_path/...` do not refer to response files and attempting to read them as such will fail the build.

Users don't always have control over these arguments, meaning transforming them to `-Wl,-install_name,@rpath/...` or `-Wl,-rpath,@loader_path/...` is not always an option. E.g. as described in https://github.com/bazelbuild/bazel/pull/13044#issuecomment-779380394 where these flags are emitted by the Haskell compiler GHC (see https://github.com/bazelbuild/bazel/pull/13044#issuecomment-782228172 for their reasoning).

With this change `osx_cc_wrapper` will only interpret arguments starting with `@` as response files if the corresponding file exists and is readable. This is analogous to the behavior defined in `wrapped_clang.cc`. See https://github.com/bazelbuild/bazel/pull/13044#issuecomment-783539568 for discussion.

Closes #13148.

PiperOrigin-RevId: 436207868
(cherry picked from commit efb2b80953983dce499d453a9f55a74ffaf8c42d)

Co-authored-by: Andreas Herrmann <andreash87@gmx.ch>