| commit | 4ec695ca279440e9e76a93e8c2f2333755115532 | [log] [tgz] |
|---|---|---|
| author | nharmata <nharmata@google.com> | Tue Feb 19 08:30:22 2019 -0800 |
| committer | Copybara-Service <copybara-worker@google.com> | Tue Feb 19 08:32:16 2019 -0800 |
| tree | 2a356de045da9ff17563c223b4bb1d7857a653f3 | |
| parent | ff93b19e496513dd78be4b6bcee0f0105cc17d2b [diff] |
Fix long-standing corner case with infinite symlink expansion detection. See the added unit tests for more details. The approach is to have FileFunction consider the entire logical chain of paths encountered during realpath resolution, not just the physical symlink chain. In order to implement this, we have FileValue instances embed the full logical chain of paths encountered during their own real path resolution. This leads to a natural recursive algorithm. In addition to the new code being less buggy, I hope it's also either to reason about since the algorithm is more natural. The added code comments should help as well. Another cool thing is that the error message printed to the user on infinite symlink expansion is much more useful since it shows them the full chain of paths. While there is a theoretical memory concern (consider a path like 'a/b/c/d/e/f/g' where 'a' is a symlink to 'a1/b/c/d/e/f/g', 'b' is a symlink to 'b1/c/d/e/f/g', etc), in practice there's no noticeable memory increase for many use cases. RELNOTES: None PiperOrigin-RevId: 234606705
{Fast, Correct} - Choose two
Build and test software of any size, quickly and reliably.
Speed up your builds and tests: Bazel only rebuilds what is necessary. With advanced local and distributed caching, optimized dependency analysis and parallel execution, you get fast and incremental builds.
One tool, multiple languages: Build and test Java, C++, Android, iOS, Go, and a wide variety of other language platforms. Bazel runs on Windows, macOS, and Linux.
Scalable: Bazel helps you scale your organization, codebase, and continuous integration solution. It handles codebases of any size, in multiple repositories or a huge monorepo.
Extensible to your needs: Easily add support for new languages and platforms with Bazel's familiar extension language. Share and re-use language rules written by the growing Bazel community.
Follow our tutorials:
See CONTRIBUTING.md
Bazel is released in ‘Beta’. See the product roadmap to learn about the path toward a stable 1.0 release.