commit 5116e92a1e8dca834b3086d2e94f2cd1ed6d1415
author Richard Levasseur <rlevasseur@google.com> Fri Aug 19 16:28:31 2022 -0700
committer Copybara-Service <copybara-worker@google.com> Fri Aug 19 16:29:34 2022 -0700
tree cfe6b3ef62a8b8ef1e70260da92a6a03fb267052
parent fbfab6626533b06fd00396969513dea1a7705f18

Make ParameterFileWriteAction describe its action key

This aids debugging action conflicts.

PiperOrigin-RevId: 468808092
Change-Id: I736302ddf4fe87127dbdddcaa43a4c0b8fb1904b

src/main/java/com/google/devtools/build/lib/analysis/actions/ParameterFileWriteAction.java

diff --git a/src/main/java/com/google/devtools/build/lib/analysis/actions/ParameterFileWriteAction.java b/src/main/java/com/google/devtools/build/lib/analysis/actions/ParameterFileWriteAction.java
index 8f970fb..e462e88 100644
--- a/src/main/java/com/google/devtools/build/lib/analysis/actions/ParameterFileWriteAction.java
+++ b/src/main/java/com/google/devtools/build/lib/analysis/actions/ParameterFileWriteAction.java
@@ -20,6 +20,7 @@
 import com.google.common.base.Preconditions;
 import com.google.common.base.Strings;
 import com.google.common.collect.Iterables;
+import com.google.common.io.BaseEncoding;
 import com.google.devtools.build.lib.actions.ActionExecutionContext;
 import com.google.devtools.build.lib.actions.ActionKeyContext;
 import com.google.devtools.build.lib.actions.ActionOwner;
@@ -183,4 +184,35 @@
     fp.addString(type.toString());
     commandLine.addToFingerprint(actionKeyContext, artifactExpander, fp);
   }
+
+  @Override
+  public String describeKey() {
+    StringBuilder message = new StringBuilder();
+    message.append("GUID: ");
+    message.append(GUID);
+    message.append("\nExecutable: ");
+    message.append(makeExecutable);
+    message.append("\nParam File Type: ");
+    message.append(type);
+    message.append("\nContent digest (approximate): ");
+    try {
+      // The full contents can be huge, which makes the final error message
+      // incomprehensible. Instead, just give a digest, which makes it easy to
+      // tell if two contents are equal or not.
+      var fp = new Fingerprint();
+      commandLine.addToFingerprint(new ActionKeyContext(), null, fp);
+      message.append(BaseEncoding.base16().lowerCase().encode(fp.digestAndReset()));
+      message.append(
+          "\n"
+              + "NOTE: Content digest reflects approximate, analysis-time data; it does not account"
+              + " for data available during execution (e.g. tree artifact expansions)");
+    } catch (InterruptedException ex) {
+      Thread.currentThread().interrupt();
+      message.append("Interrupted while expanding command line");
+    } catch (CommandLineExpansionException e) {
+      message.append("Could not expand contents: ");
+      message.append(e);
+    }
+    return message.toString();
+  }
 }