tree 3a7430455a204857f02da245b4e6b7869e231b8a
parent 7b3804a33cbaec4b653599680749fe3e5b51ec36
author ulfjack <ulfjack@google.com> 1558447720 -0700
committer Copybara-Service <copybara-worker@google.com> 1558447778 -0700

Query: Avoid copying the package targets

Change TargetPatternResolver.getTargetsInPackage and the
TargetPatternPreloader to return Collections, rather than
ResolvedTargets instances.

No implementation currently sets the error bit, and no caller requires
it, and the set of filtered targets is always empty.

Make sure that getTargetsMatchingPatternImpl uses a Set to avoid
quadratic runtime. While this may cancel out the improvements from this
change, I have some follow-up changes which use the result and don't
require a Set implementation. I missed this regression because I was
testing it with the additional changes, not independently.

PiperOrigin-RevId: 249243165