tree 53d6460dd79bbc9d8df421a639afffeff31bb00c
parent 04be3f816aa36c5b80a519daa572659e69945fa9
author nharmata <nharmata@google.com> 1573159360 -0800
committer Copybara-Service <copybara-worker@google.com> 1573159422 -0800

Don't intern the intermediate String used for starlark String -> bazel Label conversions.

This String is parsed and split during the Label conversion process, so interning this String (the *original* one) is useless and we're just needlessly paying the CPU and memory cost of the Interner. Note that Label already does its own interning of the "name" part (for "//a:b", the name will be "b"); that _is_ theoretically useful.

Also don't bother calling STRING.convert since it's just useless method overhead. Label#convert already does an instanceof check.

RELNOTES: None
PiperOrigin-RevId: 279145542