tree 48ca751c375cae863d34c276d1439d0580b0af0b
parent 4227c4ecbf96b34d3377155a6655dda399e793d7
author laszlocsomor <laszlocsomor@google.com> 1581599561 -0800
committer Copybara-Service <copybara-worker@google.com> 1581599676 -0800

Code cleanup: Bazel mock language support classes

In this change:

- Delete dead code
  (BazelMockCcSupport.setupBasePackage).

- Remove member object and anonymous nested class
  (BazelMockCcSupport.CC_LABEL_NAME_FILTER) and
  replace with static method. This yields simpler
  code, it avoids storing an object unnecessarily,
  and avoids that object having a reference to the
  outer object (which in general could hinder
  GC'ing the outer object if someone held a
  reference to the nested object). Note, it's not
  like we *need* these improvements, but they are
  useful, even if their benefit is marginal.

- Mark classes final, so they are easier to reason
  about (no need to check for subclasses and
  potentially overridden methods).

RELNOTES: none
PiperOrigin-RevId: 294891140