)]}'
{
  "commit": "67f22fa432475f6c4fe5ea566b8fcc03b9a5f01a",
  "tree": "85c5b99d497511739001ae06dc3a7ff26c5fbd18",
  "parents": [
    "24e1cc93fe5bb0186ddc6ba64a8cc4cc7236902c"
  ],
  "author": {
    "name": "Googler",
    "email": "wyv@google.com",
    "time": "Mon Jun 13 11:26:45 2022 -0700"
  },
  "committer": {
    "name": "Copybara-Service",
    "email": "copybara-worker@google.com",
    "time": "Mon Jun 13 11:28:02 2022 -0700"
  },
  "message": "LabelConverter cleanup\n\n- LabelConverter doesn\u0027t actually need a base Label; it just needs a base package. Changed the constructor to take a PackageIdentifier.\n- Nobody ever actually reuses a \"convertedLabelsInPackage\" map; such a map is only ever created once per Package.Builder, or per LabelConverter instance. We can simply construct a LabelConverter in Package.Builder and just get rid of this cache map as an input parameter.\n- This also means that convertedLabelsInPackage can be removed from BazelStarlarkContext.\n- Fixed LabelConverter tests and documentation accordingly.\n- As a next step, we should actually change the \"context\" parameter of `Type.convert(Object x, Object what, Object context)` to *always* be a LabelConverter, perhaps even non-nullable. Using a base Label as the conversion context is insufficient because it doesn\u0027t contain the repo mapping.\n\nWork towards https://github.com/bazelbuild/bazel/issues/15658.\n\nPiperOrigin-RevId: 454658146\nChange-Id: I9219da9eec785d76a040e72f6901df466ae19799\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "49e9e3657c05af4311409bdb0966accb9230b355",
      "old_mode": 33188,
      "old_path": "src/main/java/com/google/devtools/build/lib/analysis/ConfiguredRuleClassProvider.java",
      "new_id": "b3ff10d8883096b43e05097b61b8c23d2cd8044a",
      "new_mode": 33188,
      "new_path": "src/main/java/com/google/devtools/build/lib/analysis/ConfiguredRuleClassProvider.java"
    },
    {
      "type": "modify",
      "old_id": "ec41d700f97c69d89ffa1bdfb38b2cbe508825e4",
      "old_mode": 33188,
      "old_path": "src/main/java/com/google/devtools/build/lib/analysis/RuleContext.java",
      "new_id": "95927c7e25b41114792d977fb1e6b30de7b60220",
      "new_mode": 33188,
      "new_path": "src/main/java/com/google/devtools/build/lib/analysis/RuleContext.java"
    },
    {
      "type": "modify",
      "old_id": "f45a4936a7bd6470dc4bf58b4a6458e5c83f411c",
      "old_mode": 33188,
      "old_path": "src/main/java/com/google/devtools/build/lib/analysis/config/StarlarkDefinedConfigTransition.java",
      "new_id": "6d564d51f1b12cd647f2f610e4d5cb3d4ffdf9e6",
      "new_mode": 33188,
      "new_path": "src/main/java/com/google/devtools/build/lib/analysis/config/StarlarkDefinedConfigTransition.java"
    },
    {
      "type": "modify",
      "old_id": "5ddcc30bba79cf12a2c472e2fb9abc1968974c0a",
      "old_mode": 33188,
      "old_path": "src/main/java/com/google/devtools/build/lib/analysis/starlark/StarlarkAttrModule.java",
      "new_id": "e859fd26f065842b3e0846af797f69ff70e03bc0",
      "new_mode": 33188,
      "new_path": "src/main/java/com/google/devtools/build/lib/analysis/starlark/StarlarkAttrModule.java"
    },
    {
      "type": "modify",
      "old_id": "7fff123ce371cfe99877b5f723a8432d683c794e",
      "old_mode": 33188,
      "old_path": "src/main/java/com/google/devtools/build/lib/analysis/starlark/StarlarkRuleClassFunctions.java",
      "new_id": "b21ed4cc3e710fc73c7c4f341f66cbc61cac8313",
      "new_mode": 33188,
      "new_path": "src/main/java/com/google/devtools/build/lib/analysis/starlark/StarlarkRuleClassFunctions.java"
    },
    {
      "type": "modify",
      "old_id": "1e6a355b22bea8a0b26bf4fd611cf95f67f72bbe",
      "old_mode": 33188,
      "old_path": "src/main/java/com/google/devtools/build/lib/analysis/starlark/StarlarkToolchainContext.java",
      "new_id": "cbfd00952f720c41d22aedacfddb367b80e5d778",
      "new_mode": 33188,
      "new_path": "src/main/java/com/google/devtools/build/lib/analysis/starlark/StarlarkToolchainContext.java"
    },
    {
      "type": "modify",
      "old_id": "f2f80ade6db30d301f8aefe9c230fe15f4ac6eb3",
      "old_mode": 33188,
      "old_path": "src/main/java/com/google/devtools/build/lib/bazel/bzlmod/BazelModuleResolutionFunction.java",
      "new_id": "4d88cb1c60f22cf0e88fcba730ec52ade2b652d7",
      "new_mode": 33188,
      "new_path": "src/main/java/com/google/devtools/build/lib/bazel/bzlmod/BazelModuleResolutionFunction.java"
    },
    {
      "type": "modify",
      "old_id": "cd3c9dc1362553318be8db35cb0c0d2ccfdeb81e",
      "old_mode": 33188,
      "old_path": "src/main/java/com/google/devtools/build/lib/bazel/bzlmod/StarlarkBazelModule.java",
      "new_id": "da0f70def85bed80d76201abd1dd28ebffba695b",
      "new_mode": 33188,
      "new_path": "src/main/java/com/google/devtools/build/lib/bazel/bzlmod/StarlarkBazelModule.java"
    },
    {
      "type": "modify",
      "old_id": "9b85c552c118e5bcf8c55bcab8d22b66f468f753",
      "old_mode": 33188,
      "old_path": "src/main/java/com/google/devtools/build/lib/bazel/repository/starlark/StarlarkRepositoryFunction.java",
      "new_id": "eb1bb302170d1fddfc3d5a300cc529696a02ee9e",
      "new_mode": 33188,
      "new_path": "src/main/java/com/google/devtools/build/lib/bazel/repository/starlark/StarlarkRepositoryFunction.java"
    },
    {
      "type": "modify",
      "old_id": "947ebeb7cd102ae378131d92a4c7181fee13e4ae",
      "old_mode": 33188,
      "old_path": "src/main/java/com/google/devtools/build/lib/packages/BazelStarlarkContext.java",
      "new_id": "ad5f277a24fd8a035f211f17793dbc54a7165454",
      "new_mode": 33188,
      "new_path": "src/main/java/com/google/devtools/build/lib/packages/BazelStarlarkContext.java"
    },
    {
      "type": "modify",
      "old_id": "2e03f404080d05461ba3a1c7f8a5fc65b3f71d7f",
      "old_mode": 33188,
      "old_path": "src/main/java/com/google/devtools/build/lib/packages/BuildType.java",
      "new_id": "de1632d18569668b674151df29ed1d5014b4ace7",
      "new_mode": 33188,
      "new_path": "src/main/java/com/google/devtools/build/lib/packages/BuildType.java"
    },
    {
      "type": "modify",
      "old_id": "eaca82d7210bf704af5202b4b7a5a3c1f7d646ed",
      "old_mode": 33188,
      "old_path": "src/main/java/com/google/devtools/build/lib/packages/LabelConverter.java",
      "new_id": "cf3b7d72ecc3282b3da1205e734335358163cbaf",
      "new_mode": 33188,
      "new_path": "src/main/java/com/google/devtools/build/lib/packages/LabelConverter.java"
    },
    {
      "type": "modify",
      "old_id": "aca053d7406a9c0438af4a44d691cff1678b3e94",
      "old_mode": 33188,
      "old_path": "src/main/java/com/google/devtools/build/lib/packages/Package.java",
      "new_id": "2e24b12e6b86a214aa86098fce49e659fb3ad289",
      "new_mode": 33188,
      "new_path": "src/main/java/com/google/devtools/build/lib/packages/Package.java"
    },
    {
      "type": "modify",
      "old_id": "98ff211aa5a4406e6bdec2de86f33f00dd5a6ac4",
      "old_mode": 33188,
      "old_path": "src/main/java/com/google/devtools/build/lib/packages/PackageFactory.java",
      "new_id": "e9eaeb2d5d90c634769b2940230066a0bcf3d47b",
      "new_mode": 33188,
      "new_path": "src/main/java/com/google/devtools/build/lib/packages/PackageFactory.java"
    },
    {
      "type": "modify",
      "old_id": "4b38b157fd169d28e8457ec42b09802d6891dc59",
      "old_mode": 33188,
      "old_path": "src/main/java/com/google/devtools/build/lib/packages/RuleClass.java",
      "new_id": "359ec57f3f62fafacdc3185240171ee4821711ff",
      "new_mode": 33188,
      "new_path": "src/main/java/com/google/devtools/build/lib/packages/RuleClass.java"
    },
    {
      "type": "modify",
      "old_id": "aa015c52033406fad89b168172206b3cd0fa1cd0",
      "old_mode": 33188,
      "old_path": "src/main/java/com/google/devtools/build/lib/packages/WorkspaceFactory.java",
      "new_id": "3b69ca01e9bb0afe04e83b58567da2ba3f0e9afe",
      "new_mode": 33188,
      "new_path": "src/main/java/com/google/devtools/build/lib/packages/WorkspaceFactory.java"
    },
    {
      "type": "modify",
      "old_id": "1379784dac29b8fd40feed6af4ab4b7dc46078c5",
      "old_mode": 33188,
      "old_path": "src/main/java/com/google/devtools/build/lib/rules/config/ConfigStarlarkCommon.java",
      "new_id": "59e28c98021cc728e1ab1e31619cf1d1dd0ccedb",
      "new_mode": 33188,
      "new_path": "src/main/java/com/google/devtools/build/lib/rules/config/ConfigStarlarkCommon.java"
    },
    {
      "type": "modify",
      "old_id": "1e0e64f96569919d3a892cf39ae2ba410ae04543",
      "old_mode": 33188,
      "old_path": "src/test/java/com/google/devtools/build/lib/bazel/bzlmod/TypeCheckedTagTest.java",
      "new_id": "f6eec3267f87d813249c5ab2d2146a47b7cd012f",
      "new_mode": 33188,
      "new_path": "src/test/java/com/google/devtools/build/lib/bazel/bzlmod/TypeCheckedTagTest.java"
    },
    {
      "type": "modify",
      "old_id": "0cd0c1df4156adaa30e5f39cea820c803a59a6ce",
      "old_mode": 33188,
      "old_path": "src/test/java/com/google/devtools/build/lib/packages/BuildTypeTest.java",
      "new_id": "51679bc2c92391a443c86413a46cfc3d1645f847",
      "new_mode": 33188,
      "new_path": "src/test/java/com/google/devtools/build/lib/packages/BuildTypeTest.java"
    },
    {
      "type": "modify",
      "old_id": "576663ecdf383fb6645a88ef38fedd1838b8ba5b",
      "old_mode": 33188,
      "old_path": "src/test/java/com/google/devtools/build/lib/packages/LabelConverterTest.java",
      "new_id": "95d9d506eb17403a088f56b8ecc4879c1abe8070",
      "new_mode": 33188,
      "new_path": "src/test/java/com/google/devtools/build/lib/packages/LabelConverterTest.java"
    },
    {
      "type": "modify",
      "old_id": "ee8487b20569db9b6c77f6ea32fb5f0822ad87f1",
      "old_mode": 33188,
      "old_path": "src/test/java/com/google/devtools/build/lib/packages/OutputFileTest.java",
      "new_id": "88dcae1c67a0051911a9cf912f18569ef96e8bd7",
      "new_mode": 33188,
      "new_path": "src/test/java/com/google/devtools/build/lib/packages/OutputFileTest.java"
    },
    {
      "type": "modify",
      "old_id": "98a7923755264bfebf2ad70c161160583f0879a4",
      "old_mode": 33188,
      "old_path": "src/test/java/com/google/devtools/build/lib/starlark/util/BazelEvaluationTestCase.java",
      "new_id": "81a5e6d5b98b91219cf313fc41f569bb5e4cc905",
      "new_mode": 33188,
      "new_path": "src/test/java/com/google/devtools/build/lib/starlark/util/BazelEvaluationTestCase.java"
    }
  ]
}