tree 85c5b99d497511739001ae06dc3a7ff26c5fbd18
parent 24e1cc93fe5bb0186ddc6ba64a8cc4cc7236902c
author Googler <wyv@google.com> 1655144805 -0700
committer Copybara-Service <copybara-worker@google.com> 1655144882 -0700

LabelConverter cleanup

- LabelConverter doesn't actually need a base Label; it just needs a base package. Changed the constructor to take a PackageIdentifier.
- Nobody ever actually reuses a "convertedLabelsInPackage" map; such a map is only ever created once per Package.Builder, or per LabelConverter instance. We can simply construct a LabelConverter in Package.Builder and just get rid of this cache map as an input parameter.
- This also means that convertedLabelsInPackage can be removed from BazelStarlarkContext.
- Fixed LabelConverter tests and documentation accordingly.
- As a next step, we should actually change the "context" parameter of `Type.convert(Object x, Object what, Object context)` to *always* be a LabelConverter, perhaps even non-nullable. Using a base Label as the conversion context is insufficient because it doesn't contain the repo mapping.

Work towards https://github.com/bazelbuild/bazel/issues/15658.

PiperOrigin-RevId: 454658146
Change-Id: I9219da9eec785d76a040e72f6901df466ae19799