)]}'
{
  "commit": "7154be04665e2d957b2b38b624f50ff3d006fced",
  "tree": "bea81bcf3bf55f0bd6b81a175955ee6858d19ab8",
  "parents": [
    "034b09e810de42baac8e1a431eab6acd91b2c8a1"
  ],
  "author": {
    "name": "brandjon",
    "email": "brandjon@google.com",
    "time": "Fri May 22 09:47:32 2020 -0700"
  },
  "committer": {
    "name": "Copybara-Service",
    "email": "copybara-worker@google.com",
    "time": "Fri May 22 09:48:43 2020 -0700"
  },
  "message": "Rationalize StarlarkImportLookupValue.Key\n\nThis is refactoring work toward adding a new kind of .bzl loading context, for Bazel-internal .bzl files.\n\nWork toward #11437.\n\nStarlarkImportLookupValue:\n- Split off bzl keys into subclasses depending on whether we\u0027re at package-loading time or workspace-eval time. This is more readable and avoids unused fields. This will grow a third subclass when we add support for @builtins .bzl loading. The isWorkspace bool becomes an instanceof check.\n- Rename factory methods accordingly so it\u0027s always clear what we\u0027re retrieving.\n- Add helper method to construct a key for loading another .bzl within the same evaluation context (i.e. package vs workspace).\n\nStarlarkImportLookupFunction:\n- Collapse the params for internal functions by passing the key instead of its fields.\n- Rearrange workspaceChunk cases in getRepositoryMapping to better align with package vs workspace dichotomy.\n\nRELNOTES: None\nPiperOrigin-RevId: 312838319\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "862494cace9ac8144e752b71cd09d825cc493554",
      "old_mode": 33188,
      "old_path": "src/main/java/com/google/devtools/build/lib/skyframe/AspectFunction.java",
      "new_id": "28b7ecba5aa32563e3d862f785bfe6b38a854235",
      "new_mode": 33188,
      "new_path": "src/main/java/com/google/devtools/build/lib/skyframe/AspectFunction.java"
    },
    {
      "type": "modify",
      "old_id": "9e8be9b822a04e414b1f5d5ea6fd91ac3465bc7a",
      "old_mode": 33188,
      "old_path": "src/main/java/com/google/devtools/build/lib/skyframe/PackageFunction.java",
      "new_id": "cca5d993cbe1a42292bac1e70786c7f47e613bb9",
      "new_mode": 33188,
      "new_path": "src/main/java/com/google/devtools/build/lib/skyframe/PackageFunction.java"
    },
    {
      "type": "modify",
      "old_id": "4034d12f05d7704144fd1ef78a9e3c376967bc5a",
      "old_mode": 33188,
      "old_path": "src/main/java/com/google/devtools/build/lib/skyframe/StarlarkBuiltinsFunction.java",
      "new_id": "56bca6269c84e66c2b1886de7e7c84244d723414",
      "new_mode": 33188,
      "new_path": "src/main/java/com/google/devtools/build/lib/skyframe/StarlarkBuiltinsFunction.java"
    },
    {
      "type": "modify",
      "old_id": "b9be7e8e722f74a73c42cfa540eb0a0ee104dc48",
      "old_mode": 33188,
      "old_path": "src/main/java/com/google/devtools/build/lib/skyframe/StarlarkImportLookupFunction.java",
      "new_id": "cb926299451b06f4ca3a4780cbc67b49c7c4e84f",
      "new_mode": 33188,
      "new_path": "src/main/java/com/google/devtools/build/lib/skyframe/StarlarkImportLookupFunction.java"
    },
    {
      "type": "modify",
      "old_id": "c0d0e39844ab9558b2e5950ba44b1848a60de47c",
      "old_mode": 33188,
      "old_path": "src/main/java/com/google/devtools/build/lib/skyframe/StarlarkImportLookupValue.java",
      "new_id": "498ec5c3f77994b6efd3f73c556c37e8421722cb",
      "new_mode": 33188,
      "new_path": "src/main/java/com/google/devtools/build/lib/skyframe/StarlarkImportLookupValue.java"
    },
    {
      "type": "modify",
      "old_id": "a882137a70680d447eb96dd8b3116d215b7d17cc",
      "old_mode": 33188,
      "old_path": "src/main/java/com/google/devtools/build/lib/skyframe/StarlarkModuleCycleReporter.java",
      "new_id": "83c773d685b30d2e9986ba4fed7d159cc19f2843",
      "new_mode": 33188,
      "new_path": "src/main/java/com/google/devtools/build/lib/skyframe/StarlarkModuleCycleReporter.java"
    },
    {
      "type": "modify",
      "old_id": "b0171521689e26707d1560428ac88f91d6eba52f",
      "old_mode": 33188,
      "old_path": "src/test/java/com/google/devtools/build/lib/skyframe/CachedStarlarkImportLookupValueAndDepsTest.java",
      "new_id": "8de02104fdf191b139c385e521296bc642489c93",
      "new_mode": 33188,
      "new_path": "src/test/java/com/google/devtools/build/lib/skyframe/CachedStarlarkImportLookupValueAndDepsTest.java"
    },
    {
      "type": "modify",
      "old_id": "131878efcf3aba3849a0d1c86157a469d4c7154e",
      "old_mode": 33188,
      "old_path": "src/test/java/com/google/devtools/build/lib/skyframe/StarlarkImportLookupFunctionTest.java",
      "new_id": "e7a4639e8469bde16d4c69e6a31f48ac84b29ea4",
      "new_mode": 33188,
      "new_path": "src/test/java/com/google/devtools/build/lib/skyframe/StarlarkImportLookupFunctionTest.java"
    },
    {
      "type": "modify",
      "old_id": "8f0842070b306902e760b72eb137c512f1b125cd",
      "old_mode": 33188,
      "old_path": "src/test/java/com/google/devtools/build/lib/skyframe/StarlarkImportLookupKeyCodecTest.java",
      "new_id": "7b016f644694011aef765897359d6ca75dde2ef2",
      "new_mode": 33188,
      "new_path": "src/test/java/com/google/devtools/build/lib/skyframe/StarlarkImportLookupKeyCodecTest.java"
    }
  ]
}
