tree bea81bcf3bf55f0bd6b81a175955ee6858d19ab8
parent 034b09e810de42baac8e1a431eab6acd91b2c8a1
author brandjon <brandjon@google.com> 1590166052 -0700
committer Copybara-Service <copybara-worker@google.com> 1590166123 -0700

Rationalize StarlarkImportLookupValue.Key

This is refactoring work toward adding a new kind of .bzl loading context, for Bazel-internal .bzl files.

Work toward #11437.

StarlarkImportLookupValue:
- Split off bzl keys into subclasses depending on whether we're at package-loading time or workspace-eval time. This is more readable and avoids unused fields. This will grow a third subclass when we add support for @builtins .bzl loading. The isWorkspace bool becomes an instanceof check.
- Rename factory methods accordingly so it's always clear what we're retrieving.
- Add helper method to construct a key for loading another .bzl within the same evaluation context (i.e. package vs workspace).

StarlarkImportLookupFunction:
- Collapse the params for internal functions by passing the key instead of its fields.
- Rearrange workspaceChunk cases in getRepositoryMapping to better align with package vs workspace dichotomy.

RELNOTES: None
PiperOrigin-RevId: 312838319