tree 8f5c96880a83b1e44fd06de193f29366f76900a3
parent a5e40a5f3f69d9992f144a4b51b110f503759840
author Benjamin Peterson <bp@benjamin.pe> 1563841450 -0700
committer Copybara-Service <copybara-worker@google.com> 1563841512 -0700

Always report when a package is done to the PackageProgressReceiver.

Previously, if a package was so broken that a even an errored PackageValue couldn't be created for it, it would hang around in the UI ("currently loading //some/broken/package") for the entire analysis-loading phase. This behavior was because PackageProgressReceiver didn't receive a done notification from PackageFunction in extreme error cases. The fix is to call PackageProgressReceiver.doneReadPackage even when exceptions happen during loading.

While we're here, save a level of indentation in PackageFunction.loadPackage() by moving the cache checking logic to the single caller.

Closes #8209.

PiperOrigin-RevId: 259439995