)]}'
{
  "commit": "74ca288c0711deec4c308759e4db9d0aedcfe4bd",
  "tree": "2b8fee8633c02aaf0ffc0042a9292922e26e9c23",
  "parents": [
    "cfb5b41d27d3d28e7bd9d5be1ad68ff69f5aa725"
  ],
  "author": {
    "name": "Kevin Gessner",
    "email": "kgessner@etsy.com",
    "time": "Wed Nov 04 23:58:52 2020 -0800"
  },
  "committer": {
    "name": "Copybara-Service",
    "email": "copybara-worker@google.com",
    "time": "Wed Nov 04 23:59:56 2020 -0800"
  },
  "message": "ensure the gRPC LoggingInterceptor does not throw exceptions where they cannot be handled\n\nThis fixes a hang that I\u0027ve struggled with for ages: when using `--build_event_json_file` to write a BEP file, enabling `--experimental_remote_grpc_log` causes the build to hang indefinitely after completion with a message of \"Waiting for build events upload: JsonFormatFileTransport\".\n\nThe default `--build_event_json_file_path_conversion` ends up doing an RPC call when closing the BEP file. Unfortunately, this call happens after the gRPC log file has already been closed. That exception in the LoggingInterceptor is uncatchable -- it [causes the RPC call to hang indefinitely](https://github.com/grpc/grpc-java/pull/6107). Therefore, Bazel needs to handle and consume the exception so `onClose` always succeeds.\n\nCloses #12416.\n\nPiperOrigin-RevId: 340796218\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "8cb4b04f90cbeb6b40be0af2d5e004183e030e7d",
      "old_mode": 33188,
      "old_path": "src/main/java/com/google/devtools/build/lib/remote/logging/BUILD",
      "new_id": "46a9b5f5caaabedff2b36f66fda09d88812199bb",
      "new_mode": 33188,
      "new_path": "src/main/java/com/google/devtools/build/lib/remote/logging/BUILD"
    },
    {
      "type": "modify",
      "old_id": "ee4771fe99e7f0ffa7fe604f59d780e2510868f6",
      "old_mode": 33188,
      "old_path": "src/main/java/com/google/devtools/build/lib/remote/logging/LoggingInterceptor.java",
      "new_id": "c6738942b2d783fabe71f2850d1ae22d8f62fdbb",
      "new_mode": 33188,
      "new_path": "src/main/java/com/google/devtools/build/lib/remote/logging/LoggingInterceptor.java"
    }
  ]
}
