tree 5543247e4c6486401fb426ee4d87aa02adb1d7f6
parent f41c252f7ed2c2590c87477f849a7e836a3867a2
author Laszlo Csomor <laszlocsomor@google.com> 1477495898 +0000
committer Laszlo Csomor <laszlocsomor@google.com> 1477560373 +0000

"bazel clean": prevent creation of command.log

Open files cannot be deleted on Windows, thus
`bazel clean --expunge` fails when it attemps to
delete the `command.log` that stdout/stderr is
tee'd into, and so does BlazeCommandDispatcher
when it attemps to delete the `command.log` just
before dispatching to the command implementation
(not just `clean` but any command).

This change:
- closes `command.log` before we attempt to
  delete it
- marks CleanCommand (through the Command
  annotation) as one that should not write to the
  command.log, thus we don't create a new instance
  of the file

This change allows `bazel clean --expunge` to
delete everything in the output base, with the
exception of `jvm.log`. Unfortunately that file is
opened by the C++ bazel client process, so we have
to close it there prior to sending the clean to
the bazel server.

See https://github.com/bazelbuild/bazel/issues/1586

--
MOS_MIGRATED_REVID=137278553