)]}' { "commit": "858039031b3fcfb58ab589e06b1e6db493a9e740", "tree": "aaeca8f6ec66f8ec0c782098b1e9451ad2fc216e", "parents": [ "f0ccbe78507f6ca54343622f1794396fc1e66b95" ], "author": { "name": "adonovan", "email": "adonovan@google.com", "time": "Thu Apr 16 14:46:57 2020 -0700" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Apr 16 14:48:51 2020 -0700" }, "message": "bazel syntax: rationalize the type check operators\n\nThis change introduces {Dict,Sequence}.{,noneable}Cast.\nThese four conversion operators cast an arbitrary value\nto a Sequence\u003cT\u003e or Dict\u003cK,V\u003e, replacing these 9 previous functions:\n- Dict.{castSkylarkDictOrNoneToDict,getContents}\n- Sequence.{castList,castSkylarkListOrNoneToList,getContents}\n- SkylarkType.{cast,cast\u0027,checkType,castMap}\n\nThe functions don\u0027t allocate an unmodifiable wrapper,\nas Dict and List are already unmodifiable through the java.util\ninterfaces, so this is just wasteful allocation and indirection.\nAlso, there is no a priori allocation of Formattable error messages.\n\nA number of messes (e.g. unsound casts) were cleaned up throughout.\n\nThe new operators do not accept a Location, and report error\nusing Starlark.errorf. (This whole CL started as a subtask of a\nsubtask to eliminate the Location parameter of EvalException,\nand this sub-sub-task is an experiment to see whether removing\nLocation parameters that don\u0027t correspond to program counter\nlocations is a UI regression. SRCTU.createTarget is the only\nplace where this appears to be a problem. For now I\u0027ve added a\nsmall kludge, but in a follow-up I will change it to report\nevents, not throw exceptions, so that it can report multiple\nerrors at arbitrary locations.\n\nDepset might benefit from a similar {noneable,}Cast treatment,\nbut this too is left for a follow-up.\n\nThis is a breaking API change for copybara.\n\nRELNOTES: N/A\nPiperOrigin-RevId: 306925434\n", "tree_diff": [ { "type": "modify", "old_id": "3b6c73b26a0d5ef261260ef2df08cbea7f3f926e", "old_mode": 33188, "old_path": "src/main/java/com/google/devtools/build/lib/analysis/OutputGroupInfo.java", "new_id": "d61e56f17c945b7ec627cb86d2225da075cc4946", "new_mode": 33188, "new_path": "src/main/java/com/google/devtools/build/lib/analysis/OutputGroupInfo.java" }, { "type": "modify", "old_id": "647d910f5c13c56093e122061cfeb0ec3c5c8ec8", "old_mode": 33188, "old_path": "src/main/java/com/google/devtools/build/lib/analysis/TemplateVariableInfo.java", "new_id": "f93c1abf14fd16ec5f0b44575161731feeee5511", "new_mode": 33188, "new_path": "src/main/java/com/google/devtools/build/lib/analysis/TemplateVariableInfo.java" }, { "type": "modify", "old_id": "c7e0fec608eccb92e2c9fa530ae7bea8d2ef930c", "old_mode": 33188, "old_path": "src/main/java/com/google/devtools/build/lib/analysis/config/StarlarkDefinedConfigTransition.java", "new_id": "478520ed88c80e8be418a774c9b3a16bd23272a8", "new_mode": 33188, "new_path": "src/main/java/com/google/devtools/build/lib/analysis/config/StarlarkDefinedConfigTransition.java" }, { "type": "modify", "old_id": "034d41bb8a17050884866c1d01cd1fbe727421a9", "old_mode": 33188, "old_path": "src/main/java/com/google/devtools/build/lib/analysis/platform/PlatformInfo.java", "new_id": "c08454234c020d013d086d4a5652d368435ea82c", "new_mode": 33188, "new_path": "src/main/java/com/google/devtools/build/lib/analysis/platform/PlatformInfo.java" }, { "type": "modify", "old_id": "3b1d5dbefb40688fd8e03ec37fedd0b822375f35", "old_mode": 33188, "old_path": "src/main/java/com/google/devtools/build/lib/analysis/skylark/SkylarkActionFactory.java", "new_id": "cd1d711c7c5980fbee66cf9f537e43d0dcb2f7ad", "new_mode": 33188, "new_path": "src/main/java/com/google/devtools/build/lib/analysis/skylark/SkylarkActionFactory.java" }, { "type": "modify", "old_id": "38609a3844812c57d5e97249169f88393a5f3798", "old_mode": 33188, "old_path": "src/main/java/com/google/devtools/build/lib/analysis/skylark/SkylarkAttr.java", "new_id": "bae0993f96470b04e7c8d6a013d250048e768a47", "new_mode": 33188, "new_path": "src/main/java/com/google/devtools/build/lib/analysis/skylark/SkylarkAttr.java" }, { "type": "modify", "old_id": "bde937acd11d1a2e4c65acabb82e2c2ded69e544", "old_mode": 33188, "old_path": "src/main/java/com/google/devtools/build/lib/analysis/skylark/SkylarkRuleClassFunctions.java", "new_id": "d42fce74bc83ebeda1109becc845769bb4a79215", "new_mode": 33188, "new_path": "src/main/java/com/google/devtools/build/lib/analysis/skylark/SkylarkRuleClassFunctions.java" }, { "type": "modify", "old_id": "eba116164581b01e39aba672bcca2031f14f17a2", "old_mode": 33188, "old_path": "src/main/java/com/google/devtools/build/lib/analysis/skylark/SkylarkRuleConfiguredTargetUtil.java", "new_id": "0462f788784e33e62a9fdcd9338e4e001bb391c8", "new_mode": 33188, "new_path": "src/main/java/com/google/devtools/build/lib/analysis/skylark/SkylarkRuleConfiguredTargetUtil.java" }, { "type": "modify", "old_id": "0d0510740bb54558dea16ff554f6918a66708ff5", "old_mode": 33188, "old_path": "src/main/java/com/google/devtools/build/lib/analysis/skylark/SkylarkRuleContext.java", "new_id": "33e45fc9c0bfed019cc13eb8463eaa26f75a1eab", "new_mode": 33188, "new_path": "src/main/java/com/google/devtools/build/lib/analysis/skylark/SkylarkRuleContext.java" }, { "type": "modify", "old_id": "ecd1252091fb907cb33eb6257101321527e11a66", "old_mode": 33188, "old_path": "src/main/java/com/google/devtools/build/lib/analysis/test/CoverageCommon.java", "new_id": "d42cfabfddd2b6e89f898c01a39f21b550b9cbd9", "new_mode": 33188, "new_path": "src/main/java/com/google/devtools/build/lib/analysis/test/CoverageCommon.java" }, { "type": "modify", "old_id": "076248508260b71e50de69ef85d5bcf7346662d3", "old_mode": 33188, "old_path": "src/main/java/com/google/devtools/build/lib/bazel/repository/skylark/SkylarkRepositoryContext.java", "new_id": "705e09ea5c26d1b4566eb8dfa43ab080e606b088", "new_mode": 33188, "new_path": "src/main/java/com/google/devtools/build/lib/bazel/repository/skylark/SkylarkRepositoryContext.java" }, { "type": "modify", "old_id": "d76ac936eb4aafb44aeb5e682f9b96c9b7bcce11", "old_mode": 33188, "old_path": "src/main/java/com/google/devtools/build/lib/bazel/repository/skylark/SkylarkRepositoryModule.java", "new_id": "ee33c554e7b685950308ee021e60e9ed7ec40c0e", "new_mode": 33188, "new_path": "src/main/java/com/google/devtools/build/lib/bazel/repository/skylark/SkylarkRepositoryModule.java" }, { "type": "modify", "old_id": "ea93db386a7a23277898db693de941a7eb091cb5", "old_mode": 33188, "old_path": "src/main/java/com/google/devtools/build/lib/bazel/rules/cpp/BazelCcModule.java", "new_id": "94b3962bef1e3ced2a87f652a881222b623ca2dd", "new_mode": 33188, "new_path": "src/main/java/com/google/devtools/build/lib/bazel/rules/cpp/BazelCcModule.java" }, { "type": "modify", "old_id": "c8dd28a293a7893b72903e210f5effed4dcbaee7", "old_mode": 33188, "old_path": "src/main/java/com/google/devtools/build/lib/packages/ImplicitOutputsFunction.java", "new_id": "a1d6576799b564dcda9996fa72a35236a85d3ace", "new_mode": 33188, "new_path": "src/main/java/com/google/devtools/build/lib/packages/ImplicitOutputsFunction.java" }, { "type": "modify", "old_id": "762c0ee368cf95081a921bf746ac425be6d1b1aa", "old_mode": 33188, "old_path": "src/main/java/com/google/devtools/build/lib/packages/StructImpl.java", "new_id": "26bd781039cfc9e55b184d286a33780049f653f7", "new_mode": 33188, "new_path": "src/main/java/com/google/devtools/build/lib/packages/StructImpl.java" }, { "type": "modify", "old_id": "302c856f5412aac51a645981d9ed3f25f384c013", "old_mode": 33188, "old_path": "src/main/java/com/google/devtools/build/lib/packages/TargetUtils.java", "new_id": "7bc58b0040baad5b4e4bece44534c71839e8b273", "new_mode": 33188, "new_path": "src/main/java/com/google/devtools/build/lib/packages/TargetUtils.java" }, { "type": "modify", "old_id": "412ea2d7ec70ad1403f83205b925cfaa38107c5d", "old_mode": 33188, "old_path": "src/main/java/com/google/devtools/build/lib/packages/WorkspaceFactoryHelper.java", "new_id": "4c51fb4f9dca0392a24a83873b1389a7e0317eec", "new_mode": 33188, "new_path": "src/main/java/com/google/devtools/build/lib/packages/WorkspaceFactoryHelper.java" }, { "type": "modify", "old_id": "9a5ae1c83d3acb686c0c53f07e9657f20ede269b", "old_mode": 33188, "old_path": "src/main/java/com/google/devtools/build/lib/packages/WorkspaceGlobals.java", "new_id": "d363b9416f93aca53d0e1ee7c8f4a32728ba036a", "new_mode": 33188, "new_path": "src/main/java/com/google/devtools/build/lib/packages/WorkspaceGlobals.java" }, { "type": "modify", "old_id": "937f9b4e34865392f0558767b0f65cfe3664cf93", "old_mode": 33188, "old_path": "src/main/java/com/google/devtools/build/lib/rules/android/AndroidFeatureFlagSetProvider.java", "new_id": "69a8f2596ff1c6844c55ea1a16974b7b15e021a2", "new_mode": 33188, "new_path": "src/main/java/com/google/devtools/build/lib/rules/android/AndroidFeatureFlagSetProvider.java" }, { "type": "modify", "old_id": "343a9fc5223ea2d9f0d12c8cf6019b3edf088abf", "old_mode": 33188, "old_path": "src/main/java/com/google/devtools/build/lib/rules/android/AndroidIdeInfoProvider.java", "new_id": "d9eeb4ebbdf246a2e1246fcc912708eeeb193be0", "new_mode": 33188, "new_path": "src/main/java/com/google/devtools/build/lib/rules/android/AndroidIdeInfoProvider.java" }, { "type": "modify", "old_id": "355a0282e32efe95fa741319d332469a47b141db", "old_mode": 33188, "old_path": "src/main/java/com/google/devtools/build/lib/rules/android/AndroidProguardInfo.java", "new_id": "49af24d42765a346c2538c57340e2feda2598068", "new_mode": 33188, "new_path": "src/main/java/com/google/devtools/build/lib/rules/android/AndroidProguardInfo.java" }, { "type": "modify", "old_id": "f226df13e7eb00115992160a327ee022df6742de", "old_mode": 33188, "old_path": "src/main/java/com/google/devtools/build/lib/rules/android/AndroidSkylarkData.java", "new_id": "ef7403609c9aad788503f494303a94bc63c88828", "new_mode": 33188, "new_path": "src/main/java/com/google/devtools/build/lib/rules/android/AndroidSkylarkData.java" }, { "type": "modify", "old_id": "c28bb4cec7cee5bccf23209964ac341a61f3df09", "old_mode": 33188, "old_path": "src/main/java/com/google/devtools/build/lib/rules/android/databinding/DataBindingV2Provider.java", "new_id": "f5a0ca25983a889516de21b68c6a55711bc1984f", "new_mode": 33188, "new_path": "src/main/java/com/google/devtools/build/lib/rules/android/databinding/DataBindingV2Provider.java" }, { "type": "modify", "old_id": "f90d502dc6e339e9bad004c87dd4b4bcbf216b8b", "old_mode": 33188, "old_path": "src/main/java/com/google/devtools/build/lib/rules/android/databinding/UsesDataBindingProvider.java", "new_id": "c54c9a3d164e3b8825fb506234661593d178c228", "new_mode": 33188, "new_path": "src/main/java/com/google/devtools/build/lib/rules/android/databinding/UsesDataBindingProvider.java" }, { "type": "modify", "old_id": "2b0d099a6bac577388d6681d8cb84cf08c0c1df1", "old_mode": 33188, "old_path": "src/main/java/com/google/devtools/build/lib/rules/config/ConfigGlobalLibrary.java", "new_id": "30b9926a8f8cd57e40d9ac60a99fc665b0d47350", "new_mode": 33188, "new_path": "src/main/java/com/google/devtools/build/lib/rules/config/ConfigGlobalLibrary.java" }, { "type": "modify", "old_id": "6bf2eed7dcf1a809f9cb2562a9800e5a09365a51", "old_mode": 33188, "old_path": "src/main/java/com/google/devtools/build/lib/rules/cpp/CcBinary.java", "new_id": "86816139fe7bf30c38755fa1c07d00050aaf128f", "new_mode": 33188, "new_path": "src/main/java/com/google/devtools/build/lib/rules/cpp/CcBinary.java" }, { "type": "modify", "old_id": "1fb4edebb7f771dd6d4d0a7a708950eccbdefe41", "old_mode": 33188, "old_path": "src/main/java/com/google/devtools/build/lib/rules/cpp/CcModule.java", "new_id": "e0de3d0841b870a3ab8d95e240c691d50dfbca8c", "new_mode": 33188, "new_path": "src/main/java/com/google/devtools/build/lib/rules/cpp/CcModule.java" }, { "type": "modify", "old_id": "7b78c723190990e20c239ba3fff4cecd98ac9915", "old_mode": 33188, "old_path": "src/main/java/com/google/devtools/build/lib/rules/java/BootClassPathInfo.java", "new_id": "c2e6cf943f14be2ec660ba1a9d913109f22cf0b0", "new_mode": 33188, "new_path": "src/main/java/com/google/devtools/build/lib/rules/java/BootClassPathInfo.java" }, { "type": "modify", "old_id": "64bfdd98708eaf1ac9f90f4cda617288ac8f860f", "old_mode": 33188, "old_path": "src/main/java/com/google/devtools/build/lib/rules/java/JavaSkylarkCommon.java", "new_id": "e12a4fa1850b71e31b179f38487bea000413f450", "new_mode": 33188, "new_path": "src/main/java/com/google/devtools/build/lib/rules/java/JavaSkylarkCommon.java" }, { "type": "modify", "old_id": "5b6c4617a7056fd7e44560ec44c6a1183f50e9de", "old_mode": 33188, "old_path": "src/main/java/com/google/devtools/build/lib/rules/java/MessageBundleInfo.java", "new_id": "8bfe28e125517145db8085d15a19c0211147af0d", "new_mode": 33188, "new_path": "src/main/java/com/google/devtools/build/lib/rules/java/MessageBundleInfo.java" }, { "type": "modify", "old_id": "8f6827cd14b73fd9b2edcb943226a71daa2d764b", "old_mode": 33188, "old_path": "src/main/java/com/google/devtools/build/lib/rules/objc/AppleSkylarkCommon.java", "new_id": "4c18e8a6287c65729e941804c3f65a381b7e0863", "new_mode": 33188, "new_path": "src/main/java/com/google/devtools/build/lib/rules/objc/AppleSkylarkCommon.java" }, { "type": "modify", "old_id": "d363eeb547b83b31a7927972708b93144bd546a4", "old_mode": 33188, "old_path": "src/main/java/com/google/devtools/build/lib/rules/python/PyProviderUtils.java", "new_id": "50995e04a66ec2176675bb4b1a456f3756a7478d", "new_mode": 33188, "new_path": "src/main/java/com/google/devtools/build/lib/rules/python/PyProviderUtils.java" }, { "type": "modify", "old_id": "245a27452a517354a873110b00be696619d399d5", "old_mode": 33188, "old_path": "src/main/java/com/google/devtools/build/lib/rules/python/PyStructUtils.java", "new_id": "bf67b967a55e238290174cb2b410b599ca1077a3", "new_mode": 33188, "new_path": "src/main/java/com/google/devtools/build/lib/rules/python/PyStructUtils.java" }, { "type": "modify", "old_id": "bc8bc28c801fe4f25acc6bd2da8aac6699838321", "old_mode": 33188, "old_path": "src/main/java/com/google/devtools/build/lib/rules/test/SkylarkTestingModule.java", "new_id": "f2b97032b69469bfc69ccf5af2f38c6f8336e1e4", "new_mode": 33188, "new_path": "src/main/java/com/google/devtools/build/lib/rules/test/SkylarkTestingModule.java" }, { "type": "modify", "old_id": "56cf240efb6c9deb456ce2d64c722dab14c986f5", "old_mode": 33188, "old_path": "src/main/java/com/google/devtools/build/lib/skyframe/SkylarkAspectFactory.java", "new_id": "79aec7bec4e5f9cc4bede9f0062810b57a52972c", "new_mode": 33188, "new_path": "src/main/java/com/google/devtools/build/lib/skyframe/SkylarkAspectFactory.java" }, { "type": "modify", "old_id": "85c86bbb7cd963c93e05a22850c636677f1a0f88", "old_mode": 33188, "old_path": "src/main/java/com/google/devtools/build/lib/syntax/Dict.java", "new_id": "3c70d4e5957c77820b793b20ad24b177394f1a0e", "new_mode": 33188, "new_path": "src/main/java/com/google/devtools/build/lib/syntax/Dict.java" }, { "type": "modify", "old_id": "2dc79e78193a2f13fe4da14fd623bd9f124a381a", "old_mode": 33188, "old_path": "src/main/java/com/google/devtools/build/lib/syntax/MethodLibrary.java", "new_id": "6ff884058f05c096f4680de4f8fc3966a6b8f1b5", "new_mode": 33188, "new_path": "src/main/java/com/google/devtools/build/lib/syntax/MethodLibrary.java" }, { "type": "modify", "old_id": "ccaf69a1fffa9a374cad1e44547da104b2c2b7d0", "old_mode": 33188, "old_path": "src/main/java/com/google/devtools/build/lib/syntax/Printer.java", "new_id": "838a58862f959d2a82e374de9094dda98486fda6", "new_mode": 33188, "new_path": "src/main/java/com/google/devtools/build/lib/syntax/Printer.java" }, { "type": "modify", "old_id": "d743ca0df2eef78c7d3ed6a9337c68a9b625cded", "old_mode": 33188, "old_path": "src/main/java/com/google/devtools/build/lib/syntax/Sequence.java", "new_id": "726a3ba6b0c8bb4af996ce27d755ee0070373c03", "new_mode": 33188, "new_path": "src/main/java/com/google/devtools/build/lib/syntax/Sequence.java" }, { "type": "modify", "old_id": "d3e4d83611817af6d244cda001ac5e7e05439dac", "old_mode": 33188, "old_path": "src/main/java/com/google/devtools/build/lib/syntax/SkylarkType.java", "new_id": "141ba5277882c49c3cac55674e4942474ea6111e", "new_mode": 33188, "new_path": "src/main/java/com/google/devtools/build/lib/syntax/SkylarkType.java" }, { "type": "modify", "old_id": "9dd13afe3863eb4f86dcd39447ef84ff4dc3fb5d", "old_mode": 33188, "old_path": "src/main/java/com/google/devtools/build/lib/syntax/StringModule.java", "new_id": "cf7ac6ccd24eb24ef7d933a941ae3c3f7102ec5e", "new_mode": 33188, "new_path": "src/main/java/com/google/devtools/build/lib/syntax/StringModule.java" }, { "type": "modify", "old_id": "36b7d4dc14e3757bf87f6402c4d078cf6c47c749", "old_mode": 33188, "old_path": "src/main/java/com/google/devtools/build/skydoc/fakebuildapi/FakeSkylarkRuleFunctionsApi.java", "new_id": "ecf1f40e1e64a807edd09e869419317033cb5c45", "new_mode": 33188, "new_path": "src/main/java/com/google/devtools/build/skydoc/fakebuildapi/FakeSkylarkRuleFunctionsApi.java" }, { "type": "modify", "old_id": "9749c265e272dd3e73565bb870faaeca047abea0", "old_mode": 33188, "old_path": "src/main/java/com/google/devtools/build/skydoc/fakebuildapi/repository/FakeRepositoryModule.java", "new_id": "07e900f51a1d78a60d08c966bffc98805a6a3b33", "new_mode": 33188, "new_path": "src/main/java/com/google/devtools/build/skydoc/fakebuildapi/repository/FakeRepositoryModule.java" }, { "type": "modify", "old_id": "ad60dede1b8f34c26f694fec6cdde6704655ecaa", "old_mode": 33188, "old_path": "src/test/java/com/google/devtools/build/lib/packages/WorkspaceFactoryTest.java", "new_id": "7d1e67634a9b201a93dbefb4e7990c984b8f0390", "new_mode": 33188, "new_path": "src/test/java/com/google/devtools/build/lib/packages/WorkspaceFactoryTest.java" }, { "type": "modify", "old_id": "43efec1c3e7c3e8c2dfd4e44d1ff8af0b57b7673", "old_mode": 33188, "old_path": "src/test/java/com/google/devtools/build/lib/rules/cpp/SkylarkCcCommonTest.java", "new_id": "58464d6c448f786c1dfd553c1e4f415855c61d27", "new_mode": 33188, "new_path": "src/test/java/com/google/devtools/build/lib/rules/cpp/SkylarkCcCommonTest.java" }, { "type": "modify", "old_id": "2fe94e347b577065a4655a43b715b091b4761992", "old_mode": 33188, "old_path": "src/test/java/com/google/devtools/build/lib/rules/python/PyStructUtilsTest.java", "new_id": "b77aadfa06607d2042f311667b7f42277d9645de", "new_mode": 33188, "new_path": "src/test/java/com/google/devtools/build/lib/rules/python/PyStructUtilsTest.java" }, { "type": "modify", "old_id": "11ef9a4f2348d37deebb1e356ba1e17dec5f5141", "old_mode": 33188, "old_path": "src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleClassFunctionsTest.java", "new_id": "8a59f5951ef3899450f7ca7e48374b12ae0aa7e7", "new_mode": 33188, "new_path": "src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleClassFunctionsTest.java" }, { "type": "modify", "old_id": "65637e4392e617c4b3ceb89af6125c7e7f237eb2", "old_mode": 33188, "old_path": "src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleImplementationFunctionsTest.java", "new_id": "77bdd6d81385b14c8581554e04e63107e8feb5a9", "new_mode": 33188, "new_path": "src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleImplementationFunctionsTest.java" }, { "type": "modify", "old_id": "f1592cad4efe3cfb25e8a2521c28456e34e87bf4", "old_mode": 33188, "old_path": "src/test/java/com/google/devtools/build/lib/syntax/DepsetTest.java", "new_id": "431cbee5f8318da104320fe78057a0745c73972d", "new_mode": 33188, "new_path": "src/test/java/com/google/devtools/build/lib/syntax/DepsetTest.java" }, { "type": "modify", "old_id": "428a7b1bc05e83339d5bee38dbbd49b3c132f76a", "old_mode": 33188, "old_path": "src/test/java/com/google/devtools/build/lib/syntax/MethodLibraryTest.java", "new_id": "78aeeaca2902685738c1f02809dc27fbf1e776f9", "new_mode": 33188, "new_path": "src/test/java/com/google/devtools/build/lib/syntax/MethodLibraryTest.java" }, { "type": "modify", "old_id": "fd909edac19ea27889d201bbd48133d23d981f5a", "old_mode": 33188, "old_path": "src/test/starlark/testdata/string_misc.sky", "new_id": "4ba76e3c0465a79721f780cdb86aaa782514187c", "new_mode": 33188, "new_path": "src/test/starlark/testdata/string_misc.sky" } ] }