tree 8b233ca4bfd6c7a88acc8831744e9c1163321fb7
parent 83563589c33d247d42faa8f8dc7eb2e884c9b353
author Googler <noreply@google.com> 1623759912 -0700
committer Copybara-Service <copybara-worker@google.com> 1623759975 -0700

Ignore InstrumentedFilesInfo from base rule when also returned by aspect

Currently, aspects should not return InstrumentedFilesInfo, since that may be returned by any rule target. Doing so introduces an inadvertent brittle assumption that the rule targets visited by an aspect do not provide InstrumentedFilesInfo.

For example, if foo_library and foo_proto_library share an implementation so that foo_proto_library (which traverses proto_library targets) carelessly returns InstrumentedFilesInfo, this doesn't currently influence coverage behavior. But it will break as soon as proto_library starts returning InstrumentedFilesInfo.

This brittleness will come into play when the default behavior for coverage is changed from "forward nothing" to "forward from all non-tool dependencies" (currently conditioned on the flag --experimental_forward_instrumented_files_info_by_default).

Instead, ignore the InstrumentedFilesInfo from the base rule target if it's returned by an aspect.

RELNOTES: None.
PiperOrigin-RevId: 379467851