tree c0798053b3e9e919529d31b0947485b4f7678785
parent 77497410a23bd212e8c3b4e48903d805e7d9097f
author adonovan <adonovan@google.com> 1596850524 -0700
committer Copybara-Service <copybara-worker@google.com> 1596850598 -0700

starlark: remove EvalException(Location) -- easy cases

This change removes the Location argument to new EvalException() if:
- location is null or BUILTIN;
- location is rule.getLocation(), if the code is only reached while
  doing rule analysis, as analysis failures always report the rule
  location.
- the exception is never thrown out of a Starlark call; that is,
  it is only used locally in Java code.

Trickier cases are left for a follow-up.

Also, use Starlark.errorf to construct error messages.

PiperOrigin-RevId: 325546962