)]}'
{
  "commit": "8b228f81d9f8e55707c499eb2edb19e2896440e8",
  "tree": "753a734fda59dbf69366f34c646b6ecbfe932ac3",
  "parents": [
    "5dd4b22541d6233c7f30794e06ff35864dc77c49"
  ],
  "author": {
    "name": "Googler",
    "email": "noreply@google.com",
    "time": "Fri Nov 08 11:15:04 2019 -0800"
  },
  "committer": {
    "name": "Copybara-Service",
    "email": "copybara-worker@google.com",
    "time": "Fri Nov 08 11:16:06 2019 -0800"
  },
  "message": "bazel syntax: delete Mutability parameter from SkylarkDict methods\n\nIn all cases, the correct mutability to use is this.mutability,\nand (AFAICT) all callers redundantly pass that value.\n\nThis change leaves in place for now the Location parameter in methods\nsuch as put, which serves two purposes:\n\n1) to decorate the EvalException thrown by a failed mutability check.\n\n   This is unnecessary because an EvalException with no location\n   is caught and rethrown in BuiltinFunction.call and MethodDescriptor.call,\n   so it would be fine to use a null Location here and indeed almost\n   everywhere else throughout lib.syntax and indeed Blaze.\n\n1) to select the mutability-checking variant of the method,\n   (which throws EvalException) instead of the standard Map.put method,\n   which throws an unchecked UnsupportedOperationException.\n\n   If a failed mutability check instead threw an unchecked exception,\n   we could unify around the simpler standard Map methods.\n   (One might object that \"unchecked is bad\", but to date the existing\n   \u0027throw UnsupportedOperationException\u0027 statements do not appear\n   to have been a problem.)\n\nI thus propose to delete the Location parameters in a follow-up.\n\nPiperOrigin-RevId: 279352345\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "161af39058f6dc7cce32f4ae623290775c90d4ed",
      "old_mode": 33188,
      "old_path": "src/main/java/com/google/devtools/build/lib/analysis/skylark/FunctionTransitionUtil.java",
      "new_id": "942a213d87e1214cf6db3223451963e118670ba7",
      "new_mode": 33188,
      "new_path": "src/main/java/com/google/devtools/build/lib/analysis/skylark/FunctionTransitionUtil.java"
    },
    {
      "type": "modify",
      "old_id": "99d1d73779f548c65f683388435826eeba6078c0",
      "old_mode": 33188,
      "old_path": "src/main/java/com/google/devtools/build/lib/packages/SkylarkNativeModule.java",
      "new_id": "2ca372a89825735434c857bc96783d92671dd66e",
      "new_mode": 33188,
      "new_path": "src/main/java/com/google/devtools/build/lib/packages/SkylarkNativeModule.java"
    },
    {
      "type": "modify",
      "old_id": "0346d45f6727ec8412d1cb29973c11443bd0b399",
      "old_mode": 33188,
      "old_path": "src/main/java/com/google/devtools/build/lib/syntax/BaseFunction.java",
      "new_id": "9b6db90edeeed36d7ea2284f67e902b70e553016",
      "new_mode": 33188,
      "new_path": "src/main/java/com/google/devtools/build/lib/syntax/BaseFunction.java"
    },
    {
      "type": "modify",
      "old_id": "2d6a78465e883910f17cd0f3fe9980c41bbd9a5c",
      "old_mode": 33188,
      "old_path": "src/main/java/com/google/devtools/build/lib/syntax/Eval.java",
      "new_id": "86198141a814c5c40019e20b6cc9723e0af333e4",
      "new_mode": 33188,
      "new_path": "src/main/java/com/google/devtools/build/lib/syntax/Eval.java"
    },
    {
      "type": "modify",
      "old_id": "2f53d0012256b0400c0332f08ef18baae3b3f95a",
      "old_mode": 33188,
      "old_path": "src/main/java/com/google/devtools/build/lib/syntax/EvalUtils.java",
      "new_id": "dd65b5122544772c6905140b44b17d5353fba6ce",
      "new_mode": 33188,
      "new_path": "src/main/java/com/google/devtools/build/lib/syntax/EvalUtils.java"
    },
    {
      "type": "modify",
      "old_id": "2847b5e2595849b7efdf1de7105629b6a37ce122",
      "old_mode": 33188,
      "old_path": "src/main/java/com/google/devtools/build/lib/syntax/SkylarkDict.java",
      "new_id": "37be0dae7094f3317708fe7b4a5bd38e2da24a76",
      "new_mode": 33188,
      "new_path": "src/main/java/com/google/devtools/build/lib/syntax/SkylarkDict.java"
    }
  ]
}