)]}'
{
  "commit": "8c3b3fba3f68833bd97d3df2db9c48f0539efc3b",
  "tree": "f8e32a4554d0386209301e3cbcb1820cb088b3ce",
  "parents": [
    "aff189a7c514a0171a53a2dcdd37c93ecaa672ad"
  ],
  "author": {
    "name": "adgar",
    "email": "adgar@google.com",
    "time": "Mon Jun 03 13:35:28 2019 -0700"
  },
  "committer": {
    "name": "Copybara-Service",
    "email": "copybara-worker@google.com",
    "time": "Mon Jun 03 13:36:27 2019 -0700"
  },
  "message": "Failures early in package loading will now fail all --keep_going builds.\n\nWhen loading all packages under a directory (//foo/...) we use RecursivePkgFunction,\nwhich in --keep_going mode was silently ignoring any NoSuchPackageExceptions thrown\nby PackageFunction. Critically, any exceptions thrown by loading a Starlark .bzl file\nwere being ignored during loading.\n\nRecursivePkgFunction now transitively collects presence of errors into the\nRecursivePkgValue so callers (EnvironmentBackedRecursivePackageProvider)\ncan observe and record that errors happened during loading.\n\nFixes #7674.\n\nRELNOTES:\nNone.\nPiperOrigin-RevId: 251298005\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "8e10e715a6ebddb94e7c2dae5df0aef62145074a",
      "old_mode": 33188,
      "old_path": "src/main/java/com/google/devtools/build/lib/skyframe/EnvironmentBackedRecursivePackageProvider.java",
      "new_id": "d0c5f6277b280851f1219ea1a9a9653e282b49f4",
      "new_mode": 33188,
      "new_path": "src/main/java/com/google/devtools/build/lib/skyframe/EnvironmentBackedRecursivePackageProvider.java"
    },
    {
      "type": "modify",
      "old_id": "2de3bce9cb93e418a9e0c442914f30cd3ddc72bf",
      "old_mode": 33188,
      "old_path": "src/main/java/com/google/devtools/build/lib/skyframe/RecursivePkgFunction.java",
      "new_id": "9476606cf104fdf0c5b3e428c1f5c7e3a61a1dd4",
      "new_mode": 33188,
      "new_path": "src/main/java/com/google/devtools/build/lib/skyframe/RecursivePkgFunction.java"
    },
    {
      "type": "modify",
      "old_id": "d864c024d334adc5f4eec2bd86eab7efe45ecfc2",
      "old_mode": 33188,
      "old_path": "src/main/java/com/google/devtools/build/lib/skyframe/RecursivePkgValue.java",
      "new_id": "0fd722f6b1d89fe390b83784910dab485ff5ecc7",
      "new_mode": 33188,
      "new_path": "src/main/java/com/google/devtools/build/lib/skyframe/RecursivePkgValue.java"
    },
    {
      "type": "modify",
      "old_id": "ad872a660aec42dd9c50644b98cbdddd59176c62",
      "old_mode": 33188,
      "old_path": "src/test/java/com/google/devtools/build/lib/pkgcache/LoadingPhaseRunnerTest.java",
      "new_id": "307426bfed9026c43e4e8a46a19388014716a0b0",
      "new_mode": 33188,
      "new_path": "src/test/java/com/google/devtools/build/lib/pkgcache/LoadingPhaseRunnerTest.java"
    }
  ]
}
