| commit | 8fe2c1e55f4797ce9599e348cd45698700269b2c | [log] [tgz] |
|---|---|---|
| author | adonovan <adonovan@google.com> | Mon Mar 30 12:51:52 2020 -0700 |
| committer | Copybara-Service <copybara-worker@google.com> | Mon Mar 30 12:53:19 2020 -0700 |
| tree | d2da2a8211ff19d9647b3fe25dce65620343eb43 | |
| parent | 9051faa313f29b8ad8ded68b48b3f7af13108d77 [diff] |
bazel packages: delete testCreatePackageIsolatedFromOuterErrors This test, from CL 6198296 in 2008, ensured that an error injected before the return of PackageFactory.parseBuildFile would not cause PackageFactoryApparatus.createPackage to fail with an exception. Although enthusiastically approved at the time by someone with the same login name as me, this is not a style of test we want to encourage, as it drills holes into lib.packages to support artificial scenarios. It also requires a lot of support code. Tests should be expressed in terms of stable interfaces. Also: - inline and delete PackageFactory.parseBuildFile. Enable option.recordScope in tests. - delete ParsingTracker and ErrorReporter (part of above test, but artificially distanced from it by the awful Test/TestBase split). - delete getEnvironmentExtensions() abstract method (always empty) and parameter of PackageFactoryApparatus - delete assertOutputFileForRule method (dead code) - delete getPathPrefix() (always empty) RELNOTES: N/A PiperOrigin-RevId: 303802864
{Fast, Correct} - Choose two
Build and test software of any size, quickly and reliably.
Speed up your builds and tests: Bazel rebuilds only what is necessary. With advanced local and distributed caching, optimized dependency analysis and parallel execution, you get fast and incremental builds.
One tool, multiple languages: Build and test Java, C++, Android, iOS, Go, and a wide variety of other language platforms. Bazel runs on Windows, macOS, and Linux.
Scalable: Bazel helps you scale your organization, codebase, and continuous integration solution. It handles codebases of any size, in multiple repositories or a huge monorepo.
Extensible to your needs: Easily add support for new languages and platforms with Bazel's familiar extension language. Share and re-use language rules written by the growing Bazel community.
Follow our tutorials:
See CONTRIBUTING.md
