tree 70588a8d0bba72586e95c7b673a3a08c888ddfb7
parent f2526718763b1632c80e214f91e6bbdbd2d64127
author adonovan <adonovan@google.com> 1593451596 -0700
committer Copybara-Service <copybara-worker@google.com> 1593451664 -0700

bazel packages: prep for AttributeContainer optimization

Details:
- RuleFactory:
  - don't plumb AttributeContainer through create{RuleUnchecked,AndAddRule}.
  - avoid overloading of createAndAddRule.
  - inline and simplify setRuleAttributeValue
    (only one of two callers wants 'visibility' logic)
  - inline and simplify getAttributeNoncomputedDefaultValue
    (check both name and type like we do for licenses)
- AttributeContainer:
  - inline setAttributeValueByName into sole use (for $implicit_test).
  - add TODO comments.
  - make isAttributeValueExplicitlySpecified private
PiperOrigin-RevId: 318841494