)]}'
{
  "commit": "94015e35cbf1985ef83712a9f15ef4bf62abf3ff",
  "tree": "9e2a420be53b5901c73e9b89c8656777c46321ae",
  "parents": [
    "3262af87d3cbd282ded716f1ba7339e1a10d131e"
  ],
  "author": {
    "name": "nharmata",
    "email": "nharmata@google.com",
    "time": "Wed Apr 22 16:17:52 2020 -0700"
  },
  "committer": {
    "name": "Copybara-Service",
    "email": "copybara-worker@google.com",
    "time": "Wed Apr 22 16:19:03 2020 -0700"
  },
  "message": "Have SkyQuery tolerate the situation where a done node has a transitive rdep from a not-done node.\n\nThis situation can easily arise when `query` and `build` are interspersed. SkyQuery wasn\u0027t designed with this use-case in mind [1], but some Bazel users are doing this (see https://github.com/bazelbuild/bazel/issues/8582), so we can at least tolerate it. See added code comments and test for details.\n\nThis bug was diagnosed jointly by janakr@ and nharmata@ in https://github.com/bazelbuild/bazel/issues/8582#issuecomment-615021266 and https://github.com/bazelbuild/bazel/issues/8582#issuecomment-615026057.\n\n[1] It was originally planned to be query-only. In fact, the more general issue here points to an inefficiency in the interspersed usage case. I explained in the code comment and added a TODO.\n\nFixes #8582\n\nRELNOTES: None\nPiperOrigin-RevId: 307925028\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "78b5e6d336a7c448f5ea1910dd955a332901262e",
      "old_mode": 33188,
      "old_path": "src/main/java/com/google/devtools/build/skyframe/DelegatingWalkableGraph.java",
      "new_id": "56ec78f60ff68c878fddc2fee36d8bb94e093669",
      "new_mode": 33188,
      "new_path": "src/main/java/com/google/devtools/build/skyframe/DelegatingWalkableGraph.java"
    },
    {
      "type": "modify",
      "old_id": "e4a4c92f925bb3327fbfb5d6d17c8dafd82e40fe",
      "old_mode": 33261,
      "old_path": "src/test/shell/integration/bazel_query_test.sh",
      "new_id": "1228bd2e3c3b63bab48f97dabe9d278ae71fe926",
      "new_mode": 33261,
      "new_path": "src/test/shell/integration/bazel_query_test.sh"
    }
  ]
}
