tree 2ee4f07539bf037eeb652f6dbfac650f98b3e33a
parent 2069aada6cb5efda6de4b574606529d0462824ec
author Googler <noreply@google.com> 1590611152 -0700
committer Copybara-Service <copybara-worker@google.com> 1590611228 -0700

Avoid unnecessary insertion of tree file artifacts to artifactData.

Tree file artifacts that are not template expansion outputs are already stored as part of their parent artifact in treeArtifactData, so they do not need to also be stored in artifactData. This is accomplished by having callers insert metadata into the store instead of doing it in constructFileArtifactValue and maybeStoreAdditionalData.

Additionally, constructFileArtifactValue and maybeStoreAdditionalData are merged into a single method since they are always called in succession, and the latter's name doesn't make much sense after https://github.com/bazelbuild/bazel/commit/c35878a258d3c8a5305389aadd17ac0049defa15 removed additionalOutputData. Outdated comments are cleaned up.

FilesystemValueChecker made some assumptions about tree files appearing in both maps except in the remote case, so had to change the logic there a bit.

RELNOTES: None.
PiperOrigin-RevId: 313452251