commit 9ec7232bb753e6e65743c448973cd971c919ce04
author jmmv <jmmv@google.com> Tue May 19 08:14:08 2020 -0700
committer Copybara-Service <copybara-worker@google.com> Tue May 19 08:15:14 2020 -0700
tree d47678585481cb5d5be513ee27ff950e887251b1
parent 5f083b8f5a073a3427d575aa54eac5b779226708

Reenable fsevents tests.

I've fixed a bunch of additional problems in fsevents (incorrect
handling of directory notifications and spurious empty paths) and the
tests (inaccurate change detection) during the last few days.

I do not know if the original flakiness we observed in CI was caused
by any of these, but I just cannot get the tests to flake in the same
way by hand -- not even in one of the CI machines... so let's give
them another try.

Fixes #10776 (or so I hope).

RELNOTES: None.
PiperOrigin-RevId: 312282170

src/test/java/com/google/devtools/build/lib/skyframe/MacOSXFsEventsDiffAwarenessTest.java

diff --git a/src/test/java/com/google/devtools/build/lib/skyframe/MacOSXFsEventsDiffAwarenessTest.java b/src/test/java/com/google/devtools/build/lib/skyframe/MacOSXFsEventsDiffAwarenessTest.java
index b154fd2..74fcfff 100644
--- a/src/test/java/com/google/devtools/build/lib/skyframe/MacOSXFsEventsDiffAwarenessTest.java
+++ b/src/test/java/com/google/devtools/build/lib/skyframe/MacOSXFsEventsDiffAwarenessTest.java
@@ -45,7 +45,6 @@
 import java.util.logging.Logger;
 import org.junit.After;
 import org.junit.Before;
-import org.junit.Ignore;
 import org.junit.Test;
 import org.junit.runner.RunWith;
 import org.junit.runners.JUnit4;
@@ -163,7 +162,6 @@
   }
 
   @Test
-  @Ignore("Test is flaky; see https://github.com/bazelbuild/bazel/issues/10776")
   public void testSimple() throws Exception {
     View view1 = underTest.getCurrentView(watchFsEnabledProvider);
 
@@ -179,7 +177,6 @@
   }
 
   @Test
-  @Ignore("Test is flaky; see https://github.com/bazelbuild/bazel/issues/10776")
   public void testRenameDirectory() throws Exception {
     scratchDir("dir1");
     scratchFile("dir1/file.c", "first");
@@ -194,7 +191,6 @@
   }
 
   @Test
-  @Ignore("Test is flaky; see https://github.com/bazelbuild/bazel/issues/10776")
   public void testStress() throws Exception {
     View view1 = underTest.getCurrentView(watchFsEnabledProvider);