)]}'
{
  "commit": "ac8930de1d5bae71bd0bf702a197d425ddc95f92",
  "tree": "b827acd7ea2957852a173cc2cc99e47b42124d4e",
  "parents": [
    "d9795a7c28833a2a43084418b329bf032fa4bad2"
  ],
  "author": {
    "name": "Googler",
    "email": "jhorvitz@google.com",
    "time": "Tue Feb 14 12:28:03 2023 -0800"
  },
  "committer": {
    "name": "Copybara-Service",
    "email": "copybara-worker@google.com",
    "time": "Tue Feb 14 12:31:16 2023 -0800"
  },
  "message": "Prevent arbitrary modifications to the backing `InMemoryGraph` map by removing the `getAllValuesMutable()` method in favor of more specific methods that don\u0027t expose a mutable map.\n\nThe primary use case for exposing the graph as a `ConcurrentHashMap` is for the parallel `forEach` method. However, that is now implemented directly on `InMemoryGraph` as `parallelForEach`.\n\nThe motivation for this change is for upcoming work on using `InMemoryGraph` as a `SkyKeyPool`, in which the `remove()` method will need to do some additional work to ensure weak interning of keys when they are removed from the pool. This change ensures that the only way to remove keys from the graph is to go through `InMemoryGraph#remove`.\n\nPiperOrigin-RevId: 509605561\nChange-Id: I7ec69aeb58c26fa3e17f757fc357514f58480c1e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "d7b790c512b6b4f7a2710d1473d456d63c2ab951",
      "old_mode": 33188,
      "old_path": "src/main/java/com/google/devtools/build/lib/skyframe/SkyframeExecutor.java",
      "new_id": "d277d959c3fcb9500b701d6d59ca8700c19d37ba",
      "new_mode": 33188,
      "new_path": "src/main/java/com/google/devtools/build/lib/skyframe/SkyframeExecutor.java"
    },
    {
      "type": "modify",
      "old_id": "314003f584b5ee80e84b451130406b567f25df56",
      "old_mode": 33188,
      "old_path": "src/main/java/com/google/devtools/build/skyframe/AbstractInMemoryMemoizingEvaluator.java",
      "new_id": "3d303a609a6434c2c10196dfcd37674fef7890c7",
      "new_mode": 33188,
      "new_path": "src/main/java/com/google/devtools/build/skyframe/AbstractInMemoryMemoizingEvaluator.java"
    },
    {
      "type": "modify",
      "old_id": "e698e107449db909cd24a3088fcc3dff26f3643a",
      "old_mode": 33188,
      "old_path": "src/main/java/com/google/devtools/build/skyframe/InMemoryGraph.java",
      "new_id": "e9485259d081f6810cdea37a1734bcc9d78528ac",
      "new_mode": 33188,
      "new_path": "src/main/java/com/google/devtools/build/skyframe/InMemoryGraph.java"
    },
    {
      "type": "modify",
      "old_id": "9e57490d62a97c120ca95a2282f74b060ff26b11",
      "old_mode": 33188,
      "old_path": "src/main/java/com/google/devtools/build/skyframe/InMemoryGraphImpl.java",
      "new_id": "1790a7c1c95d0fb7245c43577cc0427c24e5f994",
      "new_mode": 33188,
      "new_path": "src/main/java/com/google/devtools/build/skyframe/InMemoryGraphImpl.java"
    },
    {
      "type": "modify",
      "old_id": "980f77c80bece99e35f1af8a12cd246b9a61f244",
      "old_mode": 33188,
      "old_path": "src/main/java/com/google/devtools/build/skyframe/InMemoryMemoizingEvaluator.java",
      "new_id": "89d5f50b6fad6a5c4dfd2685e6379cd703964604",
      "new_mode": 33188,
      "new_path": "src/main/java/com/google/devtools/build/skyframe/InMemoryMemoizingEvaluator.java"
    },
    {
      "type": "modify",
      "old_id": "8abc8d00dc3087238b928035f4496a691bd9a86e",
      "old_mode": 33188,
      "old_path": "src/main/java/com/google/devtools/build/skyframe/MemoizingEvaluator.java",
      "new_id": "f8de977a58df80a02c72c89b7c7c2cbcc86fdd08",
      "new_mode": 33188,
      "new_path": "src/main/java/com/google/devtools/build/skyframe/MemoizingEvaluator.java"
    },
    {
      "type": "modify",
      "old_id": "6af9811b2a7d4b90f431a6d8acec909c76c53e52",
      "old_mode": 33188,
      "old_path": "src/test/java/com/google/devtools/build/lib/analysis/util/BuildViewForTesting.java",
      "new_id": "56c01924ce95b7b8ee07950747a26b88b332078f",
      "new_mode": 33188,
      "new_path": "src/test/java/com/google/devtools/build/lib/analysis/util/BuildViewForTesting.java"
    },
    {
      "type": "modify",
      "old_id": "bbfea141afcf237d525b34ff2ec1907b5b854a13",
      "old_mode": 33188,
      "old_path": "src/test/java/com/google/devtools/build/skyframe/DeterministicInMemoryGraph.java",
      "new_id": "27ba5867dfc838cb2705a7595a05b61bd4943d75",
      "new_mode": 33188,
      "new_path": "src/test/java/com/google/devtools/build/skyframe/DeterministicInMemoryGraph.java"
    },
    {
      "type": "modify",
      "old_id": "b45a772154e4a7b95bc438e825082e75330a62c1",
      "old_mode": 33188,
      "old_path": "src/test/java/com/google/devtools/build/skyframe/NotifyingInMemoryGraph.java",
      "new_id": "dbc91e0fd1e96be6de7b537efa79c3b2c01ebf5b",
      "new_mode": 33188,
      "new_path": "src/test/java/com/google/devtools/build/skyframe/NotifyingInMemoryGraph.java"
    }
  ]
}