)]}'
{
  "commit": "afb05cc96a039c58e6b9330add8eea52acebc111",
  "tree": "da166dc5ae7487948c0859678a273357ffa30d0d",
  "parents": [
    "29bbad78c3a3a6edb1d3c80b760cc1622a35a686"
  ],
  "author": {
    "name": "Googler",
    "email": "hvd@google.com",
    "time": "Fri Sep 08 03:38:51 2023 -0700"
  },
  "committer": {
    "name": "Copybara-Service",
    "email": "copybara-worker@google.com",
    "time": "Fri Sep 08 03:40:18 2023 -0700"
  },
  "message": "Lift all subrule attributes to a rule that uses it.\n\nWe just add the attributes defined on the subrules to the rule class as if they were defined on the rule itself (renaming them to avoid conflict). This seems to be the simplest way to leverage all the existing rule machinery to resolve dependencies *and* get the right results for `bazel query`\n\nA downside of doing it this way, is that it makes these attributes bona fide attributes of the rule. So if we want to ensure these attributes are not accessible via the rule context, it will require performing some extra checks. I haven\u0027t done that here and I\u0027m not sure if that is worth it. The subrule proposal is meant to help make the code modular and have better abstractions. If one wishes to go the extra mile to violate that, :shrugs:\n\nPiperOrigin-RevId: 563703792\nChange-Id: Ifdb0893208e3693a5cde473f0cfeb3d16583d402\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "903b01b18d2d196b640fc24a16ed625596f9da3e",
      "old_mode": 33188,
      "old_path": "src/main/java/com/google/devtools/build/lib/analysis/starlark/StarlarkRuleClassFunctions.java",
      "new_id": "47e52e7ffa13ac7c8e0be688389a7a76fa5705e0",
      "new_mode": 33188,
      "new_path": "src/main/java/com/google/devtools/build/lib/analysis/starlark/StarlarkRuleClassFunctions.java"
    },
    {
      "type": "modify",
      "old_id": "32089970e060ad492b3ec00cfc4cf8084e52fda4",
      "old_mode": 33188,
      "old_path": "src/main/java/com/google/devtools/build/lib/analysis/starlark/StarlarkSubrule.java",
      "new_id": "b510538b3414891017d0fdf3e4f83e39147a25e7",
      "new_mode": 33188,
      "new_path": "src/main/java/com/google/devtools/build/lib/analysis/starlark/StarlarkSubrule.java"
    },
    {
      "type": "modify",
      "old_id": "b6168dcc9c8ccec7c6c3ebc4e2e74a58ac372523",
      "old_mode": 33188,
      "old_path": "src/main/java/com/google/devtools/build/lib/packages/StarlarkDefinedAspect.java",
      "new_id": "e8983a8bf2a210386b74c4b0a43eb2a1271f76b2",
      "new_mode": 33188,
      "new_path": "src/main/java/com/google/devtools/build/lib/packages/StarlarkDefinedAspect.java"
    },
    {
      "type": "modify",
      "old_id": "2655f2e2558d4cc3b9cdcba6a4258abe8013e211",
      "old_mode": 33188,
      "old_path": "src/test/java/com/google/devtools/build/lib/analysis/BUILD",
      "new_id": "64f1c02e09299c005da4f82444e8a8e76ee41c65",
      "new_mode": 33188,
      "new_path": "src/test/java/com/google/devtools/build/lib/analysis/BUILD"
    },
    {
      "type": "modify",
      "old_id": "5096b53b74ab89db5180136235127c9ec7a3bcc0",
      "old_mode": 33188,
      "old_path": "src/test/java/com/google/devtools/build/lib/analysis/starlark/StarlarkSubruleTest.java",
      "new_id": "ebe63c431f4e87cfe3b456b51e788960c8841ad3",
      "new_mode": 33188,
      "new_path": "src/test/java/com/google/devtools/build/lib/analysis/starlark/StarlarkSubruleTest.java"
    },
    {
      "type": "modify",
      "old_id": "cab3d59c49949b006c5d68d2a1b32e37f9f341a7",
      "old_mode": 33188,
      "old_path": "src/test/shell/integration/BUILD",
      "new_id": "b977b64809186c098a4d11ca71bd50b9128ff884",
      "new_mode": 33188,
      "new_path": "src/test/shell/integration/BUILD"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "20d3e0a871275a8ee80956c8392e38bd3a8ad7c9",
      "new_mode": 33261,
      "new_path": "src/test/shell/integration/subrules_test.sh"
    }
  ]
}