)]}'
{
  "commit": "b1778f2f3556271a4e01bc246ffd795cc249bb1c",
  "tree": "34eae597d7d768d54676cdc9badfda40ed0e96b8",
  "parents": [
    "36cac8a5d5f4f2397bf5b5632c4ad97c7be98a1b"
  ],
  "author": {
    "name": "Fabian Meumertzheim",
    "email": "fabian@meumertzhe.im",
    "time": "Tue Aug 18 08:35:53 2026 -0700"
  },
  "committer": {
    "name": "Copybara-Service",
    "email": "copybara-worker@google.com",
    "time": "Tue Aug 18 08:37:51 2026 -0700"
  },
  "message": "Don\u0027t GC dirty nodes that change pruning would verify clean (https://github.com/bazelbuild/bazel/pull/29965)\n\n### Description\n\nThe dirty-node garbage collector (`--version_window_for_dirty_node_gc`, run after every build via `BuildTool`) deletes dirty nodes that were not part of the build. A dirty node whose direct deps all turned out unchanged would be verified clean by change pruning the next time it is requested, but still ended up being deleted simply for not being part of the current evaluation.\n\n`AbstractInMemoryMemoizingEvaluator.deleteDirty` now keeps any dirty node that change pruning would verify clean if the new `--experimental_keep_change_prunable_nodes_during_gc` is enabled.\n\n### Motivation\n\nThis is motivated by https://github.com/bazelbuild/bazel/issues/29956, but doesn\u0027t quite fix it by itself (see https://github.com/bazelbuild/bazel/pull/29946#issuecomment-4797081830 and `deleteDirtyDeletesNodeNeedingRebuildToPrune`). It does help any change-prunable `SkyValue` (see the new integration test `test_unrelated_glob_change_pruned`).\n\n### Build API Changes\n\nNo\n\n### Checklist\n\n- [x] I have added tests for the new use cases (if any).\n- [ ] I have updated the documentation (if applicable).\n\nRELNOTES[NEW]: With the new `--experimental_keep_change_prunable_nodes_during_gc` flag, Skyframe will keep computed nodes that aren\u0027t requested by the current evaluation but whose dependencies would be verified clean after change pruning.\n\nCloses #29965.\n\nPiperOrigin-RevId: 966612698\nChange-Id: Ib809d5f50cd6647897a660a27bc5d531e30f2374\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "2ddd6c91acc5ddd81262f41dbcbca6430ca3c3d1",
      "old_mode": 33188,
      "old_path": "src/main/java/com/google/devtools/build/lib/analysis/AnalysisOptions.java",
      "new_id": "0ba603ed89bc3b15a521f20d3bab11e38e5f4aed",
      "new_mode": 33188,
      "new_path": "src/main/java/com/google/devtools/build/lib/analysis/AnalysisOptions.java"
    },
    {
      "type": "modify",
      "old_id": "9ad3568be14f6d51f93977d6a43cd02ada164a06",
      "old_mode": 33188,
      "old_path": "src/main/java/com/google/devtools/build/lib/buildtool/BuildTool.java",
      "new_id": "46787c8afc94beccbc8058545a37cdda412a520c",
      "new_mode": 33188,
      "new_path": "src/main/java/com/google/devtools/build/lib/buildtool/BuildTool.java"
    },
    {
      "type": "modify",
      "old_id": "eae8e33a5f67c132927b56ca98c9c754cc5b0134",
      "old_mode": 33188,
      "old_path": "src/main/java/com/google/devtools/build/lib/buildtool/PostAnalysisQueryProcessor.java",
      "new_id": "014510ae8686c3149f1c83e4fa13682cd20af872",
      "new_mode": 33188,
      "new_path": "src/main/java/com/google/devtools/build/lib/buildtool/PostAnalysisQueryProcessor.java"
    },
    {
      "type": "modify",
      "old_id": "bae2e7f73f0d48abc212eb1865271d20e87df33f",
      "old_mode": 33188,
      "old_path": "src/main/java/com/google/devtools/build/lib/skyframe/SequencedSkyframeExecutor.java",
      "new_id": "70c1162e3f966f680d876053d43b09bdcc6336a2",
      "new_mode": 33188,
      "new_path": "src/main/java/com/google/devtools/build/lib/skyframe/SequencedSkyframeExecutor.java"
    },
    {
      "type": "modify",
      "old_id": "e9879ab8fdebcd879b1b9ee606c7b86ba90c040e",
      "old_mode": 33188,
      "old_path": "src/main/java/com/google/devtools/build/lib/skyframe/SkyframeExecutor.java",
      "new_id": "4d7d693d347a6f82ddc86d8d0ca533969d8344ab",
      "new_mode": 33188,
      "new_path": "src/main/java/com/google/devtools/build/lib/skyframe/SkyframeExecutor.java"
    },
    {
      "type": "modify",
      "old_id": "95fc8c4b8fc1cf50763aa148d82e9864489774ce",
      "old_mode": 33188,
      "old_path": "src/main/java/com/google/devtools/build/skyframe/AbstractInMemoryMemoizingEvaluator.java",
      "new_id": "2cdf4da1ae61ac7e77b0e60300a08d2d1fb90ea5",
      "new_mode": 33188,
      "new_path": "src/main/java/com/google/devtools/build/skyframe/AbstractInMemoryMemoizingEvaluator.java"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "2eb4ff9b4731779ab9e7fc63f6c368dbc09b0713",
      "new_mode": 33188,
      "new_path": "src/main/java/com/google/devtools/build/skyframe/ChangePrunableNodesFinder.java"
    },
    {
      "type": "modify",
      "old_id": "7e478ba7090c3bb7ade33c1bd51086e4a4ff3bb7",
      "old_mode": 33188,
      "old_path": "src/main/java/com/google/devtools/build/skyframe/IncrementalInMemoryNodeEntry.java",
      "new_id": "db179aa96ac11127868ded8fcc2a1f23b8440741",
      "new_mode": 33188,
      "new_path": "src/main/java/com/google/devtools/build/skyframe/IncrementalInMemoryNodeEntry.java"
    },
    {
      "type": "modify",
      "old_id": "3053d4adb91b84eede66377677a4b191b68f0da4",
      "old_mode": 33188,
      "old_path": "src/main/java/com/google/devtools/build/skyframe/MemoizingEvaluator.java",
      "new_id": "de34dd491422113ff4bfe5f41429a7b2d7ce5678",
      "new_mode": 33188,
      "new_path": "src/main/java/com/google/devtools/build/skyframe/MemoizingEvaluator.java"
    },
    {
      "type": "modify",
      "old_id": "136fb9f7f74230a0093a4893acad65fdfe2616c8",
      "old_mode": 33188,
      "old_path": "src/test/java/com/google/devtools/build/skyframe/MemoizingEvaluatorTest.java",
      "new_id": "9c6a336dbcf62129f786a6259ff9c274af7433ff",
      "new_mode": 33188,
      "new_path": "src/test/java/com/google/devtools/build/skyframe/MemoizingEvaluatorTest.java"
    },
    {
      "type": "modify",
      "old_id": "c828ec5da87e60577c6f68c032cf461239ae8f36",
      "old_mode": 33261,
      "old_path": "src/test/shell/integration/loading_phase_test.sh",
      "new_id": "ae9369e795667539f4fc9319e9460c03d681effc",
      "new_mode": 33261,
      "new_path": "src/test/shell/integration/loading_phase_test.sh"
    }
  ]
}