tree febfcf392c1ca7fb0b0354e04e91403779725e22
parent 063c19df00873b4f8d4af91a3776575a00c8de0b
author dchai <dchai@google.com> 1575581817 -0800
committer Copybara-Service <copybara-worker@google.com> 1575581873 -0800

Remove broken no-op code for supporting <public/>

This was intended for supporting <public id="0xdeadbeef"/>, but since other
parts of RPBB invoke aapt2 with --static-lib, aapt2 will reject these anyway.
Even if RPBB removed usage of --static-lib [1], this code is still wrong:

* RPBB removed the top 16 bits of resource IDs.  An entry ID (aapt.pb.EntryId)
  is the lower 16 bits of a 32-bit resource ID (0xPPTTEEEE).

* aapt.pb.Entry messages with PUBLIC visibility are not guaranteed to have
  zero values.  aapt2 can and does fold a declaration+definition:
      <public name="foo" type="string" id="0x7f05537"/>
      <string name="foo">asdf</string>
  into a single Entry message if they occur in a single XML file.

[1] And it should.

PiperOrigin-RevId: 284041867