tree 37396181dbd75a8e858dce7ddffd7d36e5170dfa
parent 0c00d0300128d2b3e202f64a01015ae8cf761290
author twerth CA <twerth@google.com> 1787836372 -0700
committer Copybara-Service <copybara-worker@google.com> 1787836448 -0700

Fix infinite hang on Windows compilation actions in WaitableProcess.

Occasionally on Windows, Bazel compilation actions (such as MSVC cl.exe) get stuck in an infinite wait in the Bazel server even after the compiler process has finished. When cl.exe runs, it can launch background child processes such as Microsoft's telemetry uploader (vctip.exe), which can enter an unkillable zombie state inside the Windows Job Object. Because Bazel previously waited with an INFINITE timeout for JOB_OBJECT_MSG_ACTIVE_PROCESS_ZERO after calling TerminateJobObject, any stuck child process caused the entire build server to hang forever.

Replace INFINITE with a finite 5-second timeout (kJobCompletionTimeoutMsec) when calling GetQueuedCompletionStatus in WaitableProcess::WaitFor after the primary process has terminated and TerminateJobObject has been invoked. This allows Bazel to proceed after a short grace period even if background subprocesses like vctip.exe refuse to terminate. Fixes https://github.com/bazelbuild/bazel/issues/15094.

PiperOrigin-RevId: 971912626
Change-Id: I8e289d376ee7ac4bf61de7abd7a32f64893eb85d