)]}' { "commit": "b8bc284fea96cdfd0e3b68f366030cb06efd0bf3", "tree": "e5bd89db559ab3db458bd12cb01ba89c959c32e1", "parents": [ "ba5d4dee684087f17287f13eb6cc5a7d86984b2c" ], "author": { "name": "janakr", "email": "janakr@google.com", "time": "Wed Dec 08 12:48:02 2021 -0800" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Dec 08 12:49:31 2021 -0800" }, "message": "Properly handle missing packages and I/O exceptions when parsing target patterns in no-keep-going mode. Additionally, eagerly terminate evaluation on \"inconsistent filesystem exceptions\" even in keep-going mode, by analogy with a source file changing mid-build, which terminates the build even in keep-going mode. Note that we still don\u0027t terminate an evaluation eagerly on all inconsistent filesystem exceptions, but this is incrementally better than before, IMO (I think the remaining holes are bzl files and reading source artifacts for the first time).\n\nTargetPatternFunction can recover from missing packages/other errors in keep-going mode, and so before this change it very rarely threw an exception. However, in a no-keep-going evaluation (or a keep-going evaluation that failed catastrophically), the failure to throw an exception meant that it missed a chance to transform a lower-level exception into a more intelligible one. To allow TargetPatternFunction to distinguish these cases, we add a new method on SkyFunction.Environment.\n\nPiperOrigin-RevId: 415073167\n", "tree_diff": [ { "type": "modify", "old_id": "9861a47c415223edae51346d80cd8efd9839694d", "old_mode": 33188, "old_path": "src/main/java/com/google/devtools/build/lib/cmdline/BUILD", "new_id": "21a2e040ddebf0a45abe9d8da699536a27fa8669", "new_mode": 33188, "new_path": "src/main/java/com/google/devtools/build/lib/cmdline/BUILD" }, { "type": "modify", "old_id": "1b592b6fa2060716ce83073e03afaa5a0b8a0935", "old_mode": 33188, "old_path": "src/main/java/com/google/devtools/build/lib/cmdline/TargetParsingException.java", "new_id": "aadddeeb94c601bdfb5d1619cfa5c0586fb6ff26", "new_mode": 33188, "new_path": "src/main/java/com/google/devtools/build/lib/cmdline/TargetParsingException.java" }, { "type": "modify", "old_id": "ba41c108933ae14bfb5cd5619948a34279c6df6a", "old_mode": 33188, "old_path": "src/main/java/com/google/devtools/build/lib/cmdline/TargetPattern.java", "new_id": "8f830057cf9f9584b7382bd68e6c25d07c7a0e74", "new_mode": 33188, "new_path": "src/main/java/com/google/devtools/build/lib/cmdline/TargetPattern.java" }, { "type": "modify", "old_id": "f1c81df33f9765d66b8d5482bb6e6b2fca6cd399", "old_mode": 33188, "old_path": "src/main/java/com/google/devtools/build/lib/cmdline/TargetPatternResolver.java", "new_id": "03fdb98ba6107122d6a9cf422ec43653c6a818f2", "new_mode": 33188, "new_path": "src/main/java/com/google/devtools/build/lib/cmdline/TargetPatternResolver.java" }, { "type": "modify", "old_id": "fdd02feb0d54c4f8d62eba795c3e64202db0d5aa", "old_mode": 33188, "old_path": "src/main/java/com/google/devtools/build/lib/io/BUILD", "new_id": "540cd48ca96fff528b5aa879d723cdd8dc5bd792", "new_mode": 33188, "new_path": "src/main/java/com/google/devtools/build/lib/io/BUILD" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "4cc6ea5df1bd26049d1aa69f08801a91a3c7c266", "new_mode": 33188, "new_path": "src/main/java/com/google/devtools/build/lib/io/ProcessPackageDirectoryException.java" }, { "type": "modify", "old_id": "66e91bd4f5908135dcaea6e46bc50388e93064aa", "old_mode": 33188, "old_path": "src/main/java/com/google/devtools/build/lib/pkgcache/BUILD", "new_id": "df8ed133f83df470518b6d3bfb9c023230d9a12e", "new_mode": 33188, "new_path": "src/main/java/com/google/devtools/build/lib/pkgcache/BUILD" }, { "type": "modify", "old_id": "e04a7c6f5f325f2adada79f5aa7cbeab27c2fdcb", "old_mode": 33188, "old_path": "src/main/java/com/google/devtools/build/lib/pkgcache/PackageProvider.java", "new_id": "923ad48fb8b4e73968a916f745f8d32b373f5e5c", "new_mode": 33188, "new_path": "src/main/java/com/google/devtools/build/lib/pkgcache/PackageProvider.java" }, { "type": "modify", "old_id": "94de4cda1326c9eb99d8678036e940503fd38956", "old_mode": 33188, "old_path": "src/main/java/com/google/devtools/build/lib/pkgcache/RecursivePackageProvider.java", "new_id": "a513f390316093f62ba102fbe6356617962fe7d1", "new_mode": 33188, "new_path": "src/main/java/com/google/devtools/build/lib/pkgcache/RecursivePackageProvider.java" }, { "type": "modify", "old_id": "888d53c5ad686760f2c8c94e6ed96bc8ee3cb420", "old_mode": 33188, "old_path": "src/main/java/com/google/devtools/build/lib/query2/BUILD", "new_id": "202dd35256518c527d5780f320f0ff2f922edae4", "new_mode": 33188, "new_path": "src/main/java/com/google/devtools/build/lib/query2/BUILD" }, { "type": "modify", "old_id": "b706e2ab7d0b08eaf529371685262c2cbfc9bb71", "old_mode": 33188, "old_path": "src/main/java/com/google/devtools/build/lib/query2/SkyQueryEnvironment.java", "new_id": "265c4b397d30e1a60608ca2fcae4dd6ededfa953", "new_mode": 33188, "new_path": "src/main/java/com/google/devtools/build/lib/query2/SkyQueryEnvironment.java" }, { "type": "modify", "old_id": "84c67b6f1f8bd4640fa4783bc5609aa5849e5aef", "old_mode": 33188, "old_path": "src/main/java/com/google/devtools/build/lib/query2/common/AbstractBlazeQueryEnvironment.java", "new_id": "83e7efab8b0364daafecef28083201751d73eed5", "new_mode": 33188, "new_path": "src/main/java/com/google/devtools/build/lib/query2/common/AbstractBlazeQueryEnvironment.java" }, { "type": "modify", "old_id": "e28908795e4306d40ec0967b02eb0d79a900223f", "old_mode": 33188, "old_path": "src/main/java/com/google/devtools/build/lib/skyframe/BUILD", "new_id": "8057aa58f4a3cda44761586aedc962c8e19efd72", "new_mode": 33188, "new_path": "src/main/java/com/google/devtools/build/lib/skyframe/BUILD" }, { "type": "modify", "old_id": "35f7572c7b3200c7c45fa1f6d55adf0162974de1", "old_mode": 33188, "old_path": "src/main/java/com/google/devtools/build/lib/skyframe/CollectPackagesUnderDirectoryFunction.java", "new_id": "c71df9b35b0e28b84c3a2572ce9c625042422ee5", "new_mode": 33188, "new_path": "src/main/java/com/google/devtools/build/lib/skyframe/CollectPackagesUnderDirectoryFunction.java" }, { "type": "modify", "old_id": "cd3dcd30555523ed2c76b283231b27d57c3ac5dc", "old_mode": 33188, "old_path": "src/main/java/com/google/devtools/build/lib/skyframe/EnvironmentBackedRecursivePackageProvider.java", "new_id": "acb616ef9838a5431415ec02939a592a7f646b20", "new_mode": 33188, "new_path": "src/main/java/com/google/devtools/build/lib/skyframe/EnvironmentBackedRecursivePackageProvider.java" }, { "type": "modify", "old_id": "ea9db34bf9ce2021fa088c94ba10d9170205f8f3", "old_mode": 33188, "old_path": "src/main/java/com/google/devtools/build/lib/skyframe/FileStateFunction.java", "new_id": "de7f6d4962aca3a58117b8c662480bf1d1c0a4ad", "new_mode": 33188, "new_path": "src/main/java/com/google/devtools/build/lib/skyframe/FileStateFunction.java" }, { "type": "modify", "old_id": "0f9fdc1ee2f74ae66e04873e1c81756182197fcf", "old_mode": 33188, "old_path": "src/main/java/com/google/devtools/build/lib/skyframe/GraphBackedRecursivePackageProvider.java", "new_id": "f61cecf8e80f723f49b95aedb189c1caac7367cd", "new_mode": 33188, "new_path": "src/main/java/com/google/devtools/build/lib/skyframe/GraphBackedRecursivePackageProvider.java" }, { "type": "modify", "old_id": "0ab4fda535699352adc679187cfa2fb594ff2d09", "old_mode": 33188, "old_path": "src/main/java/com/google/devtools/build/lib/skyframe/PackageLookupFunction.java", "new_id": "c1d4e4be251733a937423394e6cb97075fb2ae77", "new_mode": 33188, "new_path": "src/main/java/com/google/devtools/build/lib/skyframe/PackageLookupFunction.java" }, { "type": "modify", "old_id": "9f1e87ae53728614ea85fc6dd3f37a97583823ae", "old_mode": 33188, "old_path": "src/main/java/com/google/devtools/build/lib/skyframe/PrepareDepsOfPatternFunction.java", "new_id": "eab41e073e3619dbf9c018d36bc163bf997cd534", "new_mode": 33188, "new_path": "src/main/java/com/google/devtools/build/lib/skyframe/PrepareDepsOfPatternFunction.java" }, { "type": "modify", "old_id": "844e9669b5e3b1ad18e1580b085b74a5a48023af", "old_mode": 33188, "old_path": "src/main/java/com/google/devtools/build/lib/skyframe/PrepareDepsOfTargetsUnderDirectoryFunction.java", "new_id": "2dfad7daf3fef923a4bb0c8dd9592f5c6e71de5f", "new_mode": 33188, "new_path": "src/main/java/com/google/devtools/build/lib/skyframe/PrepareDepsOfTargetsUnderDirectoryFunction.java" }, { "type": "modify", "old_id": "a8819d5a3529782484e0513928555e5628db8f53", "old_mode": 33188, "old_path": "src/main/java/com/google/devtools/build/lib/skyframe/PrepareTestSuitesUnderDirectoryFunction.java", "new_id": "77ddd2dda5d69ba8079b0d785f9fcdffd2b41fee", "new_mode": 33188, "new_path": "src/main/java/com/google/devtools/build/lib/skyframe/PrepareTestSuitesUnderDirectoryFunction.java" }, { "type": "modify", "old_id": "57294aaf9372c7c5e0bbbe044182ef479053aefa", "old_mode": 33188, "old_path": "src/main/java/com/google/devtools/build/lib/skyframe/ProcessPackageDirectory.java", "new_id": "23712d1d6ca480d2372263679c3a3455847f0b7d", "new_mode": 33188, "new_path": "src/main/java/com/google/devtools/build/lib/skyframe/ProcessPackageDirectory.java" }, { "type": "modify", "old_id": "4d2fdc46693d08f3d587b230938e5cc11ce5df14", "old_mode": 33188, "old_path": "src/main/java/com/google/devtools/build/lib/skyframe/ProgressEventSuppressingEnvironment.java", "new_id": "da3be2aba24e898a3b5ae0503da559434e7d4f15", "new_mode": 33188, "new_path": "src/main/java/com/google/devtools/build/lib/skyframe/ProgressEventSuppressingEnvironment.java" }, { "type": "modify", "old_id": "2fcf29ba3c17af23aa101de40b894c57bf3a3758", "old_mode": 33188, "old_path": "src/main/java/com/google/devtools/build/lib/skyframe/RecursiveDirectoryTraversalFunction.java", "new_id": "130e78b077aee26380f782aec6211b3e4c475efe", "new_mode": 33188, "new_path": "src/main/java/com/google/devtools/build/lib/skyframe/RecursiveDirectoryTraversalFunction.java" }, { "type": "modify", "old_id": "e9abf1b721d6f945ae1ea15c447ff97d2c33c5f0", "old_mode": 33188, "old_path": "src/main/java/com/google/devtools/build/lib/skyframe/RecursivePackageProviderBackedTargetPatternResolver.java", "new_id": "56a5a5934608595d5b5c5549ff4772e392808ab8", "new_mode": 33188, "new_path": "src/main/java/com/google/devtools/build/lib/skyframe/RecursivePackageProviderBackedTargetPatternResolver.java" }, { "type": "modify", "old_id": "e7881f144915976ef58e0157e011d575e7d3e3f0", "old_mode": 33188, "old_path": "src/main/java/com/google/devtools/build/lib/skyframe/RecursivePkgFunction.java", "new_id": "c569c596b6f0f9f5ca372116c0c44aa006a61639", "new_mode": 33188, "new_path": "src/main/java/com/google/devtools/build/lib/skyframe/RecursivePkgFunction.java" }, { "type": "modify", "old_id": "912c1326948f132059808c9f8e340f6b9d77a656", "old_mode": 33188, "old_path": "src/main/java/com/google/devtools/build/lib/skyframe/SkyFunctionEnvironmentForTesting.java", "new_id": "ad536cd4f1f556c1cd19f947885ac6c2a05f726d", "new_mode": 33188, "new_path": "src/main/java/com/google/devtools/build/lib/skyframe/SkyFunctionEnvironmentForTesting.java" }, { "type": "modify", "old_id": "dcf4cccb00c79097fec5272725a84fc25631155c", "old_mode": 33188, "old_path": "src/main/java/com/google/devtools/build/lib/skyframe/SkyframePackageManager.java", "new_id": "ce432779005359d152a56074e42b52278f033188", "new_mode": 33188, "new_path": "src/main/java/com/google/devtools/build/lib/skyframe/SkyframePackageManager.java" }, { "type": "modify", "old_id": "e6437fd6c9c2feb298574dcc247a2bb569c88c6a", "old_mode": 33188, "old_path": "src/main/java/com/google/devtools/build/lib/skyframe/SkyframeTargetPatternEvaluator.java", "new_id": "b95b4bec4958ea762bb6361ba01571793151bbea", "new_mode": 33188, "new_path": "src/main/java/com/google/devtools/build/lib/skyframe/SkyframeTargetPatternEvaluator.java" }, { "type": "modify", "old_id": "0cbb8edaf2b1a152068f190740597e77df5273d5", "old_mode": 33188, "old_path": "src/main/java/com/google/devtools/build/lib/skyframe/StateInformingSkyFunctionEnvironment.java", "new_id": "84315fc6511b13dc8a602be3b4dbbbe3263035e1", "new_mode": 33188, "new_path": "src/main/java/com/google/devtools/build/lib/skyframe/StateInformingSkyFunctionEnvironment.java" }, { "type": "modify", "old_id": "23d554f310ff335fda97cfd074ded23217f394af", "old_mode": 33188, "old_path": "src/main/java/com/google/devtools/build/lib/skyframe/TargetPatternErrorFunction.java", "new_id": "dadf2411df867305fe83a50f4312432ba5c94008", "new_mode": 33188, "new_path": "src/main/java/com/google/devtools/build/lib/skyframe/TargetPatternErrorFunction.java" }, { "type": "modify", "old_id": "53aa19f0e38c2390e8269df969c98fd21ae95630", "old_mode": 33188, "old_path": "src/main/java/com/google/devtools/build/lib/skyframe/TargetPatternFunction.java", "new_id": "5284f5653c05bfcd113ca20feb5b915d6084287b", "new_mode": 33188, "new_path": "src/main/java/com/google/devtools/build/lib/skyframe/TargetPatternFunction.java" }, { "type": "modify", "old_id": "b1168ec49e78f1fd81de164f9424da2bd9db8066", "old_mode": 33188, "old_path": "src/main/java/com/google/devtools/build/lib/skyframe/TargetPatternPhaseFunction.java", "new_id": "df7bc71c7ac7bb33fbd472972c6e4e279191b0a7", "new_mode": 33188, "new_path": "src/main/java/com/google/devtools/build/lib/skyframe/TargetPatternPhaseFunction.java" }, { "type": "modify", "old_id": "fc48fc1b1c5b6c1832d38cba0525021335ba0a6c", "old_mode": 33188, "old_path": "src/main/java/com/google/devtools/build/skyframe/RecordingSkyFunctionEnvironment.java", "new_id": "661e7ef83577726d7756b0d7dabd584e09defa2b", "new_mode": 33188, "new_path": "src/main/java/com/google/devtools/build/skyframe/RecordingSkyFunctionEnvironment.java" }, { "type": "modify", "old_id": "f618243927b33c9a5f81a57f767acf06c3154413", "old_mode": 33188, "old_path": "src/main/java/com/google/devtools/build/skyframe/SkyFunction.java", "new_id": "fdee133389a8e69d9bc54ff7ced336b46a4296a9", "new_mode": 33188, "new_path": "src/main/java/com/google/devtools/build/skyframe/SkyFunction.java" }, { "type": "modify", "old_id": "f6407adba94905b2f9d408c7532aaf03471ed42f", "old_mode": 33188, "old_path": "src/main/java/com/google/devtools/build/skyframe/SkyFunctionEnvironment.java", "new_id": "2af7b38b5813e2d1012b6aacaeae4e52bf018481", "new_mode": 33188, "new_path": "src/main/java/com/google/devtools/build/skyframe/SkyFunctionEnvironment.java" }, { "type": "modify", "old_id": "eec52791902a1e6c6b338fc9eb91f426c9cf3a88", "old_mode": 33188, "old_path": "src/main/protobuf/failure_details.proto", "new_id": "ad8a715db29af2962a2974eefc5cb04325746d08", "new_mode": 33188, "new_path": "src/main/protobuf/failure_details.proto" }, { "type": "modify", "old_id": "54dfa809459015ffa678822a50ede6b7fbcea680", "old_mode": 33188, "old_path": "src/test/java/com/google/devtools/build/lib/actions/util/ActionsTestUtil.java", "new_id": "dbf8fcd1a4b54e1f52aac24a6892a68affdbaf7e", "new_mode": 33188, "new_path": "src/test/java/com/google/devtools/build/lib/actions/util/ActionsTestUtil.java" }, { "type": "modify", "old_id": "b06c6b87891509b02d55321266a5bee84add3f90", "old_mode": 33188, "old_path": "src/test/java/com/google/devtools/build/lib/buildtool/BUILD", "new_id": "5efcdc7261b7a97df2cbb009e2aba1a579de90b0", "new_mode": 33188, "new_path": "src/test/java/com/google/devtools/build/lib/buildtool/BUILD" }, { "type": "modify", "old_id": "36e35dbbd77fff0ebf9db8f3a194b9e873a17999", "old_mode": 33188, "old_path": "src/test/java/com/google/devtools/build/lib/buildtool/QueryIntegrationTest.java", "new_id": "4c129511f1f706c2613e40977d568b5bbfce63e4", "new_mode": 33188, "new_path": "src/test/java/com/google/devtools/build/lib/buildtool/QueryIntegrationTest.java" }, { "type": "modify", "old_id": "36a98a769e75e9edcbc652a449e33157ef41e8f0", "old_mode": 33188, "old_path": "src/test/java/com/google/devtools/build/lib/pkgcache/BUILD", "new_id": "fd9d220274ee59346f8eb944d852c4db1f0eccfd", "new_mode": 33188, "new_path": "src/test/java/com/google/devtools/build/lib/pkgcache/BUILD" }, { "type": "modify", "old_id": "6a6236d698acf5e36c22b7400b81109a16f038fc", "old_mode": 33188, "old_path": "src/test/java/com/google/devtools/build/lib/pkgcache/TargetPatternEvaluatorIOTest.java", "new_id": "f148a5f7b43c24c22ad91b8f21f72ac8585aed59", "new_mode": 33188, "new_path": "src/test/java/com/google/devtools/build/lib/pkgcache/TargetPatternEvaluatorIOTest.java" }, { "type": "modify", "old_id": "1c761fd21ef038aecdaec15e2da890761c06c3d2", "old_mode": 33188, "old_path": "src/test/java/com/google/devtools/build/lib/pkgcache/TargetPatternEvaluatorTest.java", "new_id": "b144f20b9c42d420ac173c42d521490f460c4c1d", "new_mode": 33188, "new_path": "src/test/java/com/google/devtools/build/lib/pkgcache/TargetPatternEvaluatorTest.java" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "7cc3d3672a33d591862009528c1d9ae7ddd1053d", "new_mode": 33188, "new_path": "src/test/java/com/google/devtools/build/lib/platform/darwin/BUILD" }, { "type": "modify", "old_id": "233521aeb309681c11a4c8903f17beaea8c0615a", "old_mode": 33188, "old_path": "src/test/java/com/google/devtools/build/lib/query2/cquery/ConfiguredTargetQuerySemanticsTest.java", "new_id": "023a0339880e33649190a7df29c7979dbef70b6c", "new_mode": 33188, "new_path": "src/test/java/com/google/devtools/build/lib/query2/cquery/ConfiguredTargetQuerySemanticsTest.java" }, { "type": "modify", "old_id": "33ab53bf16e503d56df3a602b8d5cdfbcdc684ac", "old_mode": 33188, "old_path": "src/test/java/com/google/devtools/build/lib/query2/testutil/AbstractQueryTest.java", "new_id": "0dd74745994aef1a225660b504b486d06774fff6", "new_mode": 33188, "new_path": "src/test/java/com/google/devtools/build/lib/query2/testutil/AbstractQueryTest.java" }, { "type": "modify", "old_id": "5341c6ce15b8950a962bc55eb00bbafd876bd884", "old_mode": 33188, "old_path": "src/test/java/com/google/devtools/build/lib/query2/testutil/BUILD", "new_id": "2009df8efc0133e5a88c6d064ede947a8572a223", "new_mode": 33188, "new_path": "src/test/java/com/google/devtools/build/lib/query2/testutil/BUILD" }, { "type": "modify", "old_id": "856443d519d06126f05948d6e413545e77bd1e63", "old_mode": 33188, "old_path": "src/test/java/com/google/devtools/build/lib/query2/testutil/PostAnalysisQueryHelper.java", "new_id": "8f818064a503d358bdc66d217d46281e8c1f4f94", "new_mode": 33188, "new_path": "src/test/java/com/google/devtools/build/lib/query2/testutil/PostAnalysisQueryHelper.java" }, { "type": "modify", "old_id": "5c474b7c69dbced1a43dd4481379de7e8270142a", "old_mode": 33188, "old_path": "src/test/java/com/google/devtools/build/lib/query2/testutil/PostAnalysisQueryTest.java", "new_id": "2718cce85286c2e2a274833ae6605edfee38a8c7", "new_mode": 33188, "new_path": "src/test/java/com/google/devtools/build/lib/query2/testutil/PostAnalysisQueryTest.java" }, { "type": "modify", "old_id": "86f695ae88136407ec19051d7b71c07c80cd0935", "old_mode": 33188, "old_path": "src/test/java/com/google/devtools/build/skyframe/ParallelEvaluatorTest.java", "new_id": "45f25cae2486b29e4ba2079888e01ad5a2c5a14d", "new_mode": 33188, "new_path": "src/test/java/com/google/devtools/build/skyframe/ParallelEvaluatorTest.java" } ] }