tree 1ccfada75196981d6eee987f36237a0068588fd0
parent 6793b9358e51f0be8ea02376d530a847e2f3e2d4
author ulfjack <ulfjack@google.com> 1554375501 -0700
committer Copybara-Service <copybara-worker@google.com> 1554375602 -0700

Simplify Test summary creation

- return a TestSummary rather than a Builder
- only call build() once
- remove some dead code
- avoid creating some unnecessary intermediate lists

This code is performance critical in that the thread executing it is
holding a lock on AggregatingTestListener. On builds which have a lot of
executing tests (e.g., high values of --runs_per_test) this can lead to
significant lock contention.

It might be better to refactor this code to just store the received test
attempt results and only aggregate when all attempts for a specific test
are done, rather than trying to do incremental work. That should make
the code simpler, although it might be a bit slower, but allows multiple
test reports to process in parallel.

PiperOrigin-RevId: 241903073