)]}' { "commit": "bc884e14f16ab7d1f6729a0485dfc281239d16a5", "tree": "7ba46c9de0383f3c47194d8b4767ba3afc269327", "parents": [ "7154be04665e2d957b2b38b624f50ff3d006fced" ], "author": { "name": "brandjon", "email": "brandjon@google.com", "time": "Fri May 22 10:24:37 2020 -0700" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri May 22 10:25:55 2020 -0700" }, "message": "Tighten the types of some of the machinery surrounding .bzl skyframe inlining\n\nTighten SkyKey to StarlarkImportLookupValue.Key for the internal functions of StarlarkImportLookupFunction and its inlined (non-Skyframe) caller. This avoids all but one downcast to [...].Key, in compute(), as is expected. Note the naming convention for vars -- \"SkyKey skyKey\", but \"StarlarkImportLookupFunction.Key key\".\n\nAlso eliminate a redundant case in PackageFunction#computeStarlarkImportMapWithInlining, at the expense of making the quick return path not self-evident; added a comment to compensate.\n\nThis is refactoring work toward adding a new kind of .bzl loading context, for Bazel-internal .bzl files.\n\nWork toward #11437.\n\nRELNOTES: None\nPiperOrigin-RevId: 312840745\n", "tree_diff": [ { "type": "modify", "old_id": "cca5d993cbe1a42292bac1e70786c7f47e613bb9", "old_mode": 33188, "old_path": "src/main/java/com/google/devtools/build/lib/skyframe/PackageFunction.java", "new_id": "266be0c443c3b5856b456c850f19b74b33ef4d31", "new_mode": 33188, "new_path": "src/main/java/com/google/devtools/build/lib/skyframe/PackageFunction.java" }, { "type": "modify", "old_id": "cb926299451b06f4ca3a4780cbc67b49c7c4e84f", "old_mode": 33188, "old_path": "src/main/java/com/google/devtools/build/lib/skyframe/StarlarkImportLookupFunction.java", "new_id": "cb270118eedae65f1b3006d1251109e01b196175", "new_mode": 33188, "new_path": "src/main/java/com/google/devtools/build/lib/skyframe/StarlarkImportLookupFunction.java" } ] }