tree 2b9440804532c30278b3fdba81bd8d988b5a9d45
parent 400dbc45b180fc2c0ef302a932f3f34bd2c32c31
author nharmata <nharmata@google.com> 1584172376 -0700
committer Copybara-Service <copybara-worker@google.com> 1584172457 -0700

Bazel client: Refactor startup options parsing to gracefully handle user errors, rather than crash.

blaze::OptionProcessor::SplitCommandLine is a nice standalone helper function, and so it's undesirable for blaze::StartupOptions::IsNullary to intentionally crash the host program via BAZEL_DIE.

Even ignoring that, option_processor.h's comment for SplitCommandLine says "... If the method fails then error will contain the cause..." and so transitive BAZEL_DIE usage makes this comment technically incorrect. Therefore, this change here can be motivated by a desire to make that comment correct.

RELNOTES: None
PiperOrigin-RevId: 300896347