)]}'
{
  "commit": "c5d9e2b2034ee7b3c7bc26db095ff0a14e7785f1",
  "tree": "6aabcde59da425cce3a4e2544077eb3e832f5231",
  "parents": [
    "8b0f51b142417ed94949f71711a6c3c122599a17"
  ],
  "author": {
    "name": "brandjon",
    "email": "brandjon@google.com",
    "time": "Fri Aug 07 10:23:17 2020 -0700"
  },
  "committer": {
    "name": "Copybara-Service",
    "email": "copybara-worker@google.com",
    "time": "Fri Aug 07 10:24:22 2020 -0700"
  },
  "message": "Eliminate package lookup from ASTFileLookupFunction\n\nBzlLoadFunction does a package lookup to confirm that the requested bzl label does indeed have a corresponding package. However, ASTFileLookupFunction repeats this lookup so that it can obtain the Root for the actual file retrieval. This is an unnecessary Skyframe dep, and is replaced by incorporating the Root into the ast key.\n\nThere may be some observable changes, e.g. regarding the error messages for edge cases like a prelude file that crosses package boundaries. The bigger changes will be when we load the prelude using BzlLoadFunction.\n\nThis resolves a TODO left behind in the wake of --incompatible_disallow_load_labels_to_cross_package_boundaries. It follows in the footsteps of unknown commit (parts of which were subsequently done in unknown commit).\n\nPackageFunction changes:\n- Auto-format file, add \"static\"\n- Inline away preludeLabel field\n- Factor off prelude lookup into a helper. This will go away when prelude loading is merged into bzl loading. In the meantime, this logic gets more complicated due to the new need to do package lookup for the prelude file (since it won\u0027t be done inside ASTFileLookupFunction).\n\nOther notes:\n- Eliminate a redundant test in ASTFileLookupFunctionTest, and rename some scratch files (the test cases appear to believe ASTFileLookupFunction can be used to load BUILD files)\n\nWork toward #11437 and toward flat Starlark environments.\n\nRELNOTES: None\nPiperOrigin-RevId: 325459040\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "fd165fc3805ab450f928f722eac4b2e038c37ce1",
      "old_mode": 33188,
      "old_path": "src/main/java/com/google/devtools/build/lib/skyframe/ASTFileLookupFunction.java",
      "new_id": "59cf34fba12107914c0f49a86284ab0da1897882",
      "new_mode": 33188,
      "new_path": "src/main/java/com/google/devtools/build/lib/skyframe/ASTFileLookupFunction.java"
    },
    {
      "type": "modify",
      "old_id": "dbf9401496ae8456989d4a123e281e2dc675dbfa",
      "old_mode": 33188,
      "old_path": "src/main/java/com/google/devtools/build/lib/skyframe/ASTFileLookupValue.java",
      "new_id": "2e6ae4fa2e3130446e710f20cff7896437009655",
      "new_mode": 33188,
      "new_path": "src/main/java/com/google/devtools/build/lib/skyframe/ASTFileLookupValue.java"
    },
    {
      "type": "modify",
      "old_id": "8cd0635c3620304781081f4e71d4388fb6862859",
      "old_mode": 33188,
      "old_path": "src/main/java/com/google/devtools/build/lib/skyframe/BUILD",
      "new_id": "df012386cdc72f943ac4f1ddaeeccdcc7c2d7006",
      "new_mode": 33188,
      "new_path": "src/main/java/com/google/devtools/build/lib/skyframe/BUILD"
    },
    {
      "type": "modify",
      "old_id": "ff139b6e6b3fa0df17c73a54dace90cfce3bc230",
      "old_mode": 33188,
      "old_path": "src/main/java/com/google/devtools/build/lib/skyframe/BzlLoadFunction.java",
      "new_id": "60b33b6bf854387fb2e2acd12647505c62b0c5a1",
      "new_mode": 33188,
      "new_path": "src/main/java/com/google/devtools/build/lib/skyframe/BzlLoadFunction.java"
    },
    {
      "type": "modify",
      "old_id": "bc2a71fcdff658858c405241a501ed638ee9cd32",
      "old_mode": 33188,
      "old_path": "src/main/java/com/google/devtools/build/lib/skyframe/BzlLoadValue.java",
      "new_id": "85228eec44a538f09c7b47d81b45bfe3edac8437",
      "new_mode": 33188,
      "new_path": "src/main/java/com/google/devtools/build/lib/skyframe/BzlLoadValue.java"
    },
    {
      "type": "modify",
      "old_id": "39d03f904c0b301a12ea599c96e215ba9218dfd8",
      "old_mode": 33188,
      "old_path": "src/main/java/com/google/devtools/build/lib/skyframe/PackageFunction.java",
      "new_id": "439c550028379b436880f4bbd88e4e86d7cf2f04",
      "new_mode": 33188,
      "new_path": "src/main/java/com/google/devtools/build/lib/skyframe/PackageFunction.java"
    },
    {
      "type": "modify",
      "old_id": "065088bb620adf5315e5e27a905ebdbfe2739f08",
      "old_mode": 33188,
      "old_path": "src/test/java/com/google/devtools/build/lib/skyframe/ASTFileLookupFunctionTest.java",
      "new_id": "7cdf93dc5215a7836bb089767ab0724e785da3d3",
      "new_mode": 33188,
      "new_path": "src/test/java/com/google/devtools/build/lib/skyframe/ASTFileLookupFunctionTest.java"
    }
  ]
}