tree b11ab7406ae8345b76375cab5e3b8a06032ce86d
parent c2d088f547bfeda2c5978883dae02aef18685cb1
author ulfjack <ulfjack@google.com> 1561994790 -0700
committer Copybara-Service <copybara-worker@google.com> 1561994845 -0700

GC reduction: convertStarlarkArgumentsToJavaMethodArguments

- use ArrayList instead of ImmutableList.Builder
  This reduces the number of copies by one, because
  ImmutableList.Builder.build makes a copy, and toArray makes another
  copy, whereas with ArrayList the first copy goes away (the second still
  applies).
- use CompactHashSet instead of LinkedHashSet
- avoid creating a new Set if it's going to be empty
  note that CompactHashSet actually _increases_ memory consumption for
  empty sets, so we need to make sure that we don't do that

On a benchmark, this reduces memory allocation by this method by a
factor of more than 2.

PiperOrigin-RevId: 255959188