tree 10acd9ea5f0ad0c3ad4c4d153a2f919cd56834e3
parent 14db507c284a936dc14559f095a4629d5c52f5d8
author Laszlo Csomor <laszlocsomor@google.com> 1490026239 +0000
committer Yue Gan <yueg@google.com> 1490100540 +0000

Bazel client, Windows: fix server kill failures

Fix the (spurious) error messages about the Bazel
client's failure to kill the server process, with
"Access Denied" errors.

This was caused by our attempt to kill the server
process twice, and the error was coming from the
second attempt.

The culprit was an unimplemented
VerifyServerProcess method (which ensures that the
PID read from the server.pid.txt indeed refers to
a running Bazel server) which always returned
false, to avoid accidentally killing an unrelated
process that got the same PID as the last alive
Bazel server.

The new code follows the same logic as the Linux
version of Bazel, namely storing the process'
start time in a file next to the PID file, and
checking that the process with said PID was
indeed started at the time we read from the file.

This change also fixes a problem that the now
working VerifyServerProcess uncovered: we need to
wait for the previous Bazel server to properly
shut down before we can open the new jvm.out log
file.

Fixes https://github.com/bazelbuild/bazel/issues/2684

--
PiperOrigin-RevId: 150632429
MOS_MIGRATED_REVID=150632429