tree ec84868f78a2080556f1e6b56149bff4d283b166
parent a61b53a8ef65881c6c4a69f16edc52ed7f1662a3
author ulfjack <ulfjack@google.com> 1526568407 -0700
committer Copybara-Service <copybara-piper@google.com> 1526568490 -0700

Rename CommandAction.getEnvironment, add AbstractAction.getEnvironment

This is a cleanup to clarify the code.

1. The getEnvironment method in the CommandAction interface does not have
   access to the clientEnv, so it's return value is necessarily incomplete.
   Rename to getIncompleteEnvironmentForTesting.
2. Add a final getEnvironment method to AbstractAction, which returns the
   ActionEnvironment, which is intended to be a complete description of the
   intended final environment of the action (technically, of any spawn running
   within the action). This is not currently used, but is provided to prevent
   action subclasses to add such a method (it may be used in the future).

PiperOrigin-RevId: 196991091